[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308393#comment-17308393 ] Qi Zhu commented on YARN-10571: --- Thanks [~gandras] for update, LGTM +1 (Non-binding). > Refactor dynamic

[jira] [Commented] (YARN-10517) QueueMetrics has incorrect Allocated Resource when labelled partitions updated

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308392#comment-17308392 ] Qi Zhu commented on YARN-10517: --- Thanks a lot [~epayne] for review. :D > QueueMetrics has incorrect

[jira] [Commented] (YARN-10713) ClusterMetrics should support custom resource capacity related metrics.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308334#comment-17308334 ] Qi Zhu commented on YARN-10713: --- cc [~ebadger] Fixed checkstyle in latest patch. Could you help review

[jira] [Updated] (YARN-10713) ClusterMetrics should support custom resource capacity related metrics.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qi Zhu updated YARN-10713: -- Attachment: YARN-10713.002.patch > ClusterMetrics should support custom resource capacity related metrics. >

[jira] [Created] (YARN-10715) Remove hardcoded resource values (e.g. GPU/FPGA) in code.

2021-03-24 Thread Qi Zhu (Jira)
Qi Zhu created YARN-10715: - Summary: Remove hardcoded resource values (e.g. GPU/FPGA) in code. Key: YARN-10715 URL: https://issues.apache.org/jira/browse/YARN-10715 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308330#comment-17308330 ] Qi Zhu commented on YARN-10503: --- Thanks [~ebadger] for confirm. I have updated a patch to make sure no

[jira] [Updated] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qi Zhu updated YARN-10503: -- Attachment: YARN-10503.005.patch > Support queue capacity in terms of absolute resources with custom >

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Matthew Sharp (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308201#comment-17308201 ] Matthew Sharp commented on YARN-10493: -- Good news for the test.  I can add that to the improvement

[jira] [Comment Edited] (YARN-10493) RunC container repository v2

2021-03-24 Thread Matthew Sharp (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308201#comment-17308201 ] Matthew Sharp edited comment on YARN-10493 at 3/24/21, 10:04 PM: - Good

[jira] [Commented] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308187#comment-17308187 ] Eric Badger commented on YARN-10503: I'm fine with moving the effort of removing hardcoded resource

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308180#comment-17308180 ] Eric Badger commented on YARN-10493: I did have a weird umask set. Reverting back to the default

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308173#comment-17308173 ] Eric Badger commented on YARN-10493: Hmm, must be a default umask issue or something on my testing

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Matthew Sharp (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308172#comment-17308172 ] Matthew Sharp commented on YARN-10493: -- No I don't see that in our cluster.  We have 755 perms on

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308169#comment-17308169 ] Eric Badger commented on YARN-10493: {noformat} [ebadger@foo hadoop]$ hadoop fs -ls /runc-root/*/*/*

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308167#comment-17308167 ] Eric Badger commented on YARN-10493: {noformat} 2021-03-24 20:21:56,225 WARN [Public Localizer]

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308165#comment-17308165 ] Eric Badger commented on YARN-10493: Yea, I think that would be a good improvement to the plugin

[jira] [Commented] (YARN-10517) QueueMetrics has incorrect Allocated Resource when labelled partitions updated

2021-03-24 Thread Eric Payne (Jira)
[ https://issues.apache.org/jira/browse/YARN-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308158#comment-17308158 ] Eric Payne commented on YARN-10517: --- I'll try to look this afternoon. > QueueMetrics has incorrect

[jira] [Commented] (YARN-10713) ClusterMetrics should support custom resource capacity related metrics.

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308135#comment-17308135 ] Hadoop QA commented on YARN-10713: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Created] (YARN-10714) Remove dangling dynamic queues on reinitialization

2021-03-24 Thread Andras Gyori (Jira)
Andras Gyori created YARN-10714: --- Summary: Remove dangling dynamic queues on reinitialization Key: YARN-10714 URL: https://issues.apache.org/jira/browse/YARN-10714 Project: Hadoop YARN Issue

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308012#comment-17308012 ] Gergely Pollak commented on YARN-10597: --- I checked and [~ahussein] was right, the configuration

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307968#comment-17307968 ] Hadoop QA commented on YARN-10597: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10713) ClusterMetrics should support custom resource capacity related metrics.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307966#comment-17307966 ] Qi Zhu commented on YARN-10713: --- [~pbacsko]   [~ebadger]  [~gandras]   [~Jim_Brennan] I have changed to 

[jira] [Created] (YARN-10713) ClusterMetrics should support custom resource capacity related metrics.

2021-03-24 Thread Qi Zhu (Jira)
Qi Zhu created YARN-10713: - Summary: ClusterMetrics should support custom resource capacity related metrics. Key: YARN-10713 URL: https://issues.apache.org/jira/browse/YARN-10713 Project: Hadoop YARN

[jira] [Commented] (YARN-10493) RunC container repository v2

2021-03-24 Thread Matthew Sharp (Jira)
[ https://issues.apache.org/jira/browse/YARN-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307897#comment-17307897 ] Matthew Sharp commented on YARN-10493: -- I looked at YARN-10494 (CLI Tool) design and that was the

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307845#comment-17307845 ] Qi Zhu commented on YARN-9618: -- The test failed not related this.  > NodeListManager event improvement >

[jira] [Updated] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10597: -- Attachment: YARN-10597.002.patch > CSMappingPlacementRule should not create new instance of

[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307805#comment-17307805 ] Gergely Pollak commented on YARN-10571: --- [~gandras] thank you for the update, patch 2 LGTM+1

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307776#comment-17307776 ] Hadoop QA commented on YARN-9618: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Comment Edited] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307772#comment-17307772 ] Qi Zhu edited comment on YARN-10503 at 3/24/21, 12:08 PM: -- Thanks [~gandras] for

[jira] [Comment Edited] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307772#comment-17307772 ] Qi Zhu edited comment on YARN-10503 at 3/24/21, 12:06 PM: -- Thanks [~gandras] for

[jira] [Commented] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307772#comment-17307772 ] Qi Zhu commented on YARN-10503: --- Thanks [~gandras] for review. I agree with you. After this jira, if we

[jira] [Commented] (YARN-10637) We should support fs to cs support for auto refresh queues when conf changed, after YARN-10623 finished.

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307769#comment-17307769 ] Hadoop QA commented on YARN-10637: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307760#comment-17307760 ] Andras Gyori commented on YARN-10503: - Thank you [~zhuqi] for the patch. I agree with [~pbacsko] and

[jira] [Updated] (YARN-10712) Fix word errors in class comments

2021-03-24 Thread chaosju (Jira)
[ https://issues.apache.org/jira/browse/YARN-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaosju updated YARN-10712: --- Target Version/s: (was: 3.3.0) Affects Version/s: (was: 3.2.0) 3.2.1 > Fix

[jira] [Updated] (YARN-10712) Fix word errors in class comments

2021-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/YARN-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated YARN-10712: -- Labels: pull-request-available (was: ) > Fix word errors in class comments >

[jira] [Updated] (YARN-10712) Fix word errors in class comments

2021-03-24 Thread chaosju (Jira)
[ https://issues.apache.org/jira/browse/YARN-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaosju updated YARN-10712: --- Description: Class of LocalityMulticastAMRMProxyPolicy’s class comment has error word

[jira] [Created] (YARN-10712) Fix word errors in class comments

2021-03-24 Thread chaosju (Jira)
chaosju created YARN-10712: -- Summary: Fix word errors in class comments Key: YARN-10712 URL: https://issues.apache.org/jira/browse/YARN-10712 Project: Hadoop YARN Issue Type: Improvement

[jira] [Comment Edited] (YARN-10517) QueueMetrics has incorrect Allocated Resource when labelled partitions updated

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307509#comment-17307509 ] Qi Zhu edited comment on YARN-10517 at 3/24/21, 9:13 AM: - Thanks [~ebadger] for

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307688#comment-17307688 ] Qi Zhu commented on YARN-9618: -- [~gandras] [~ebadger] [~pbacsko] I have updated in the patch as [~gandras]

[jira] [Updated] (YARN-9618) NodeListManager event improvement

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qi Zhu updated YARN-9618: - Attachment: YARN-9618.006.patch > NodeListManager event improvement > - > >

[jira] [Comment Edited] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307529#comment-17307529 ] Qi Zhu edited comment on YARN-10503 at 3/24/21, 9:04 AM: - Thanks [~ebadger] for

[jira] [Commented] (YARN-10637) We should support fs to cs support for auto refresh queues when conf changed, after YARN-10623 finished.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307681#comment-17307681 ] Qi Zhu commented on YARN-10637: --- [~gandras] [~pbacsko] Since YARN-10674 has finished. I have updated a

[jira] [Updated] (YARN-10637) We should support fs to cs support for auto refresh queues when conf changed, after YARN-10623 finished.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qi Zhu updated YARN-10637: -- Attachment: YARN-10637.004.patch > We should support fs to cs support for auto refresh queues when conf

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307674#comment-17307674 ] Qi Zhu commented on YARN-9618: -- Thanks [~ebadger]  [~gandras] for review and clarify. It make sense to me, i

[jira] [Commented] (YARN-10707) Support gpu in ResourceUtilization, and update Node GPU Utilization to use.

2021-03-24 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307654#comment-17307654 ] Qi Zhu commented on YARN-10707: --- Thanks [~ebadger] for review. I will updated a patch for custom resource

[jira] [Commented] (YARN-10683) Add total resource in NodeManager metrics

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307643#comment-17307643 ] Hadoop QA commented on YARN-10683: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Updated] (YARN-10036) Install yarnpkg and upgrade nodejs in Dockerfile

2021-03-24 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/YARN-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated YARN-10036: - Fix Version/s: 3.1.5 Backported to branch-3.1. > Install yarnpkg and upgrade nodejs in

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-03-24 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307611#comment-17307611 ] Andras Gyori commented on YARN-9618: [~ebadger] that is correct. In my opinion the proposal in

[jira] [Commented] (YARN-10674) fs2cs should generate auto-created queue deletion properties

2021-03-24 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307605#comment-17307605 ] Peter Bacsko commented on YARN-10674: - Thanks [~zhuqi] for the patch and [~gandras] for the review.

[jira] [Commented] (YARN-10674) fs2cs should generate auto-created queue deletion properties

2021-03-24 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307602#comment-17307602 ] Peter Bacsko commented on YARN-10674: - +1 LGTM. I'm going to commit this soon. > fs2cs should

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-24 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307599#comment-17307599 ] Andras Gyori commented on YARN-10674: - Thank you [~zhuqi] for incorporating our suggestions. I have

[jira] [Updated] (YARN-10674) fs2cs should generate auto-created queue deletion properties

2021-03-24 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10674: Summary: fs2cs should generate auto-created queue deletion properties (was: fs2cs: should support

[jira] [Updated] (YARN-10683) Add total resource in NodeManager metrics

2021-03-24 Thread Minni Mittal (Jira)
[ https://issues.apache.org/jira/browse/YARN-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Minni Mittal updated YARN-10683: Attachment: YARN-10683.v1.patch > Add total resource in NodeManager metrics >

[jira] [Commented] (YARN-10503) Support queue capacity in terms of absolute resources with custom resourceType.

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307585#comment-17307585 ] Hadoop QA commented on YARN-10503: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem