[jira] [Reopened] (YARN-9615) Add dispatcher metrics to RM

2021-05-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reopened YARN-9615: > Add dispatcher metrics to RM > > > Key: YARN-9615 >

[jira] [Updated] (YARN-9615) Add dispatcher metrics to RM

2021-05-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9615: --- Attachment: YARN-9615-branch-3.3-001.patch > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-05-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342462#comment-17342462 ] Peter Bacsko commented on YARN-10571: - Finally, no javac issues! [~gandras] please check the test

[jira] [Commented] (YARN-10763) add the speed of containers assigned metrics to ClusterMetrics

2021-05-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342360#comment-17342360 ] Peter Bacsko commented on YARN-10763: - [~chaosju] some comments: 1. {{Timer}} / {{TimerTask}} are

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

2021-05-06 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340163#comment-17340163 ] Peter Bacsko commented on YARN-9615: [~BilwaST] I'm currently on vacation, I can get back to this on

[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-04-28 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334674#comment-17334674 ] Peter Bacsko commented on YARN-10571: - Thanks [~gandras] for the patch. Do you know what's going on

[jira] [Commented] (YARN-10739) GenericEventHandler.printEventQueueDetails causes RM recovery to take too much time

2021-04-27 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17333171#comment-17333171 ] Peter Bacsko commented on YARN-10739: - +1 thanks [~zhuqi] for the patch and [~gandras] /

[jira] [Updated] (YARN-10739) GenericEventHandler.printEventQueueDetails causes RM recovery to take too much time

2021-04-27 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10739: Summary: GenericEventHandler.printEventQueueDetails causes RM recovery to take too much time

[jira] [Commented] (YARN-10739) GenericEventHandler.printEventQueueDetails cause RM recovery cost too much time

2021-04-26 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332076#comment-17332076 ] Peter Bacsko commented on YARN-10739: - Thanks for the patch [~zhuqi]. I have some comments: 1.

[jira] [Comment Edited] (YARN-10739) GenericEventHandler.printEventQueueDetails cause RM recovery cost too much time

2021-04-26 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332076#comment-17332076 ] Peter Bacsko edited comment on YARN-10739 at 4/26/21, 12:14 PM: Thanks

[jira] [Commented] (YARN-10637) fs2cs: add queue autorefresh policy during conversion

2021-04-26 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332014#comment-17332014 ] Peter Bacsko commented on YARN-10637: - +1 Thanks [~zhuqi] for the patch and [~gandras] for the

[jira] [Updated] (YARN-10637) fs2cs: add queue autorefresh policy during conversion

2021-04-26 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10637: Summary: fs2cs: add queue autorefresh policy during conversion (was: We should support fs to cs

[jira] [Updated] (YARN-10637) fs2cs: add queue autorefresh policy during conversion

2021-04-26 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10637: Labels: fs2cs (was: ) > fs2cs: add queue autorefresh policy during conversion >

[jira] [Commented] (YARN-10732) Disallow restarting a queue while it is in DRAINING state on CS reinitialization

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330917#comment-17330917 ] Peter Bacsko commented on YARN-10732: - [~BilwaST] thanks for your comment - I think this is a

[jira] [Commented] (YARN-10705) Misleading DEBUG log for container assignment needs to be removed when the container is actually reserved, not assigned in FairScheduler

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330872#comment-17330872 ] Peter Bacsko commented on YARN-10705: - Thanks for the patch [~sahuja], committed to trunk. >

[jira] [Commented] (YARN-10732) Disallow restarting a queue while it is in DRAINING state on CS reinitialization

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330865#comment-17330865 ] Peter Bacsko commented on YARN-10732: - [~gandras] the old queue state comes from a {{CSQueueStore}}

[jira] [Commented] (YARN-10732) Disallow restarting a queue while it is in DRAINING state on CS reinitialization

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330859#comment-17330859 ] Peter Bacsko commented on YARN-10732: - I manually triggered a build and set the status to "Patch

[jira] [Assigned] (YARN-10732) Disallow restarting a queue while it is in DRAINING state on CS reinitialization

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-10732: --- Assignee: Andras Gyori (was: Peter Bacsko) > Disallow restarting a queue while it is in

[jira] [Assigned] (YARN-10732) Disallow restarting a queue while it is in DRAINING state on CS reinitialization

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-10732: --- Assignee: Peter Bacsko (was: Andras Gyori) > Disallow restarting a queue while it is in

[jira] [Commented] (YARN-10705) Misleading DEBUG log for container assignment needs to be removed when the container is actually reserved, not assigned in FairScheduler

2021-04-23 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330857#comment-17330857 ] Peter Bacsko commented on YARN-10705: - +1 LGTM. > Misleading DEBUG log for container assignment

[jira] [Commented] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-04-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321128#comment-17321128 ] Peter Bacsko commented on YARN-10654: - [~snemeth] [~shuzirra] do you guys have some time to review

[jira] [Commented] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-04-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320954#comment-17320954 ] Peter Bacsko commented on YARN-10654: - Uploaded patch v1 which is probably the simplest approach to

[jira] [Updated] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-04-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10654: Attachment: YARN-10654-001.patch > Dots '.' in CSMappingRule path variables should be replaced >

[jira] [Assigned] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-04-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-10654: --- Assignee: Peter Bacsko (was: Gergely Pollak) > Dots '.' in CSMappingRule path variables

[jira] [Commented] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-08 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317080#comment-17317080 ] Peter Bacsko commented on YARN-10564: - +1 Committed to trunk. Thanks [~gandras] for the patch and

[jira] [Commented] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316309#comment-17316309 ] Peter Bacsko commented on YARN-10564: - Thanks [~gandras] I have the following suggestions: please add

[jira] [Comment Edited] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316277#comment-17316277 ] Peter Bacsko edited comment on YARN-10564 at 4/7/21, 12:16 PM: --- Thanks

[jira] [Commented] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316277#comment-17316277 ] Peter Bacsko commented on YARN-10564: - Thanks [~gandras], I think I get it. I guess the trick is the

[jira] [Comment Edited] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316213#comment-17316213 ] Peter Bacsko edited comment on YARN-10564 at 4/7/21, 11:51 AM: --- [~gandras]

[jira] [Comment Edited] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316213#comment-17316213 ] Peter Bacsko edited comment on YARN-10564 at 4/7/21, 10:49 AM: --- [~gandras]

[jira] [Commented] (YARN-10564) Support Auto Queue Creation template configurations

2021-04-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316213#comment-17316213 ] Peter Bacsko commented on YARN-10564: - [~gandras] thanks for the patch. >From coding POV it looks ok,

[jira] [Commented] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313241#comment-17313241 ] Peter Bacsko commented on YARN-10726: - Ok, I strongly believe that the failing tests are flaky.

[jira] [Commented] (YARN-10693) Add document for YARN-10623 auto refresh queue conf in cs.

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313219#comment-17313219 ] Peter Bacsko commented on YARN-10693: - I'll review this as soon as I have some spare cycles. > Add

[jira] [Commented] (YARN-10637) We should support fs to cs support for auto refresh queues when conf changed, after YARN-10623 finished.

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313218#comment-17313218 ] Peter Bacsko commented on YARN-10637: - Thanks [~zhuqi] I think it's good then. [~gandras] do you

[jira] [Commented] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313192#comment-17313192 ] Peter Bacsko commented on YARN-10726: - Ah, I already committed the change. Let's hope Jenkins comes

[jira] [Commented] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313189#comment-17313189 ] Peter Bacsko commented on YARN-10726: -

[jira] [Commented] (YARN-10637) We should support fs to cs support for auto refresh queues when conf changed, after YARN-10623 finished.

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313184#comment-17313184 ] Peter Bacsko commented on YARN-10637: - Thanks [~zhuqi] this makes sense. Is this always enabled in

[jira] [Commented] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313138#comment-17313138 ] Peter Bacsko commented on YARN-10726: - This is from {{AsyncDispatcher}}: {noformat} if (qSize

[jira] [Comment Edited] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313123#comment-17313123 ] Peter Bacsko edited comment on YARN-10726 at 4/1/21, 12:01 PM: --- Thanks

[jira] [Commented] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313123#comment-17313123 ] Peter Bacsko commented on YARN-10726: - Thanks [~zhuqi]. I think it's a good idea. My only "concern"

[jira] [Updated] (YARN-10726) Log the size of DelegationTokenRenewer event queue in case of too many pending events

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10726: Summary: Log the size of DelegationTokenRenewer event queue in case of too many pending events

[jira] [Commented] (YARN-9618) NodesListManager event improvement

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313105#comment-17313105 ] Peter Bacsko commented on YARN-9618: Thanks for the patch [~zhuqi] and [~gandras] for the review, I

[jira] [Updated] (YARN-9618) NodesListManager event improvement

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9618: --- Summary: NodesListManager event improvement (was: NodeListManager event improvement) >

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312989#comment-17312989 ] Peter Bacsko commented on YARN-9618: +1 LGTM [~gandras] are you OK with the patch? > NodeListManager

[jira] [Commented] (YARN-10720) YARN WebAppProxyServlet should support connection timeout to prevent proxy server from hanging

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312945#comment-17312945 ] Peter Bacsko commented on YARN-10720: - +1 thanks [~zhuqi] for the patch, committed to trunk. > YARN

[jira] [Updated] (YARN-10720) YARN WebAppProxyServlet should support connection timeout to prevent proxy server from hanging

2021-04-01 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10720: Summary: YARN WebAppProxyServlet should support connection timeout to prevent proxy server from

[jira] [Commented] (YARN-9618) NodeListManager event improvement

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312516#comment-17312516 ] Peter Bacsko commented on YARN-9618: Small things: 1. {noformat} //Is trigger RMAppNodeUpdateEvent

[jira] [Commented] (YARN-10720) YARN WebAppProxyServlet should support connection timeout to prevent proxy server hang.

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312492#comment-17312492 ] Peter Bacsko commented on YARN-10720: - {noformat} } catch (InterruptedException e) {

[jira] [Commented] (YARN-10720) YARN WebAppProxyServlet should support connection timeout to prevent proxy server hang.

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312253#comment-17312253 ] Peter Bacsko commented on YARN-10720: - Thanks [~zhuqi] for the patch. 1. As you said

[jira] [Commented] (YARN-10718) Fix CapacityScheduler#initScheduler log error.

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312203#comment-17312203 ] Peter Bacsko commented on YARN-10718: - Committed to trunk. Closing. > Fix

[jira] [Updated] (YARN-10718) Fix CapacityScheduler#initScheduler log error.

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10718: Labels: resourcemanager (was: ) > Fix CapacityScheduler#initScheduler log error. >

[jira] [Updated] (YARN-10718) Fix CapacityScheduler#initScheduler log error.

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10718: Labels: capacity-scheduler capacityscheduler (was: resourcemanager) > Fix

[jira] [Commented] (YARN-10718) Fix CapacityScheduler#initScheduler log error.

2021-03-31 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312195#comment-17312195 ] Peter Bacsko commented on YARN-10718: - Thanks [~zhuqi], +1 LGTM. Will commit this soon. > Fix

[jira] [Commented] (YARN-10674) fs2cs should generate auto-created queue deletion properties

2021-03-24 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307605#comment-17307605 ] Peter Bacsko commented on YARN-10674: - Thanks [~zhuqi] for the patch and [~gandras] for the review.

[jira] [Commented] (YARN-10674) fs2cs should generate auto-created queue deletion properties

2021-03-24 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307602#comment-17307602 ] Peter Bacsko commented on YARN-10674: - +1 LGTM. I'm going to commit this soon. > fs2cs should

[jira] [Updated] (YARN-10674) fs2cs should generate auto-created queue deletion properties

2021-03-24 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10674: Summary: fs2cs should generate auto-created queue deletion properties (was: fs2cs: should support

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-22 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306240#comment-17306240 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] I had a discussion with [~gandras], he will post an

[jira] [Commented] (YARN-10645) Fix queue state related update for auto created queue.

2021-03-22 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306203#comment-17306203 ] Peter Bacsko commented on YARN-10645: - [~zhuqi] [~gandras] is this patch still needed? Looking at

[jira] [Commented] (YARN-10503) Support queue capacity in terms of absolute resources with gpu resourceType.

2021-03-22 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306157#comment-17306157 ] Peter Bacsko commented on YARN-10503: - The question is this part: {noformat} public enum

[jira] [Commented] (YARN-10704) The CS effective capacity for absolute mode in UI should support GPU and other custom resources.

2021-03-22 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306154#comment-17306154 ] Peter Bacsko commented on YARN-10704: - Thanks [~zhuqi] I have some minor comments: 1. {noformat}

[jira] [Comment Edited] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-19 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304971#comment-17304971 ] Peter Bacsko edited comment on YARN-10597 at 3/19/21, 3:35 PM: --- [~shuzirra]

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-19 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304971#comment-17304971 ] Peter Bacsko commented on YARN-10597: - [~shuzirra] is it really that simple? You told me that there

[jira] [Commented] (YARN-10641) Refactor the max app related update, and fix maxApllications update error when add new queues.

2021-03-18 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304117#comment-17304117 ] Peter Bacsko commented on YARN-10641: - +1 Thanks for the patch [~zhuqi] and [~gandras] for the

[jira] [Commented] (YARN-10692) Add Node GPU Utilization and apply to NodeMetrics.

2021-03-18 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304089#comment-17304089 ] Peter Bacsko commented on YARN-10692: - Thanks [~zhuqi] for the patch, committed to trunk. > Add Node

[jira] [Commented] (YARN-10692) Add Node GPU Utilization and apply to NodeMetrics.

2021-03-18 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304078#comment-17304078 ] Peter Bacsko commented on YARN-10692: - +1 LGTM. Committing this soon. > Add Node GPU Utilization

[jira] [Commented] (YARN-10685) Fix typos in AbstractCSQueue

2021-03-18 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304041#comment-17304041 ] Peter Bacsko commented on YARN-10685: - +1 thanks [~zhuqi] for the patch, committed to trunk. > Fix

[jira] [Updated] (YARN-10685) Fix typos in AbstractCSQueue

2021-03-18 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10685: Summary: Fix typos in AbstractCSQueue (was: Fixed some Typo in AbstractCSQueue.) > Fix typos in

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-18 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304027#comment-17304027 ] Peter Bacsko commented on YARN-10674: - Thanks [~zhuqi] for the patch. I think we are very close. I

[jira] [Comment Edited] (YARN-10692) Add Node GPU Utilization and apply to NodeMetrics.

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303542#comment-17303542 ] Peter Bacsko edited comment on YARN-10692 at 3/17/21, 4:11 PM: --- Thanks

[jira] [Commented] (YARN-10692) Add Node GPU Utilization and apply to NodeMetrics.

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303542#comment-17303542 ] Peter Bacsko commented on YARN-10692: - Thanks [~zhuqi] in general this looks good. I just have two

[jira] [Updated] (YARN-10497) Fix an issue in CapacityScheduler which fails to delete queues

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10497: Labels: capacity-scheduler capacityscheduler (was: ) > Fix an issue in CapacityScheduler which

[jira] [Commented] (YARN-10497) Fix an issue in CapacityScheduler which fails to delete queues

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303365#comment-17303365 ] Peter Bacsko commented on YARN-10497: - +1 Thanks [~wangda] / [~zhuqi] for the patch and [~gandras],

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303342#comment-17303342 ] Peter Bacsko commented on YARN-10674: - [~gandras] good suggestions, thanks! [~zhuqi] please apply the

[jira] [Commented] (YARN-10497) Fix an issue in CapacityScheduler which fails to delete queues

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303245#comment-17303245 ] Peter Bacsko commented on YARN-10497: - I think it's good. Let's wait for Jenkins and I'll commit it.

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-17 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303222#comment-17303222 ] Peter Bacsko commented on YARN-10674: - [~gandras] do you have further comments? I think the patch is

[jira] [Comment Edited] (YARN-10370) [Umbrella] Reduce the feature gap between FS Placement Rules and CS Queue Mapping rules

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302878#comment-17302878 ] Peter Bacsko edited comment on YARN-10370 at 3/16/21, 8:36 PM: --- [~shuzirra]

[jira] [Commented] (YARN-10370) [Umbrella] Reduce the feature gap between FS Placement Rules and CS Queue Mapping rules

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302878#comment-17302878 ] Peter Bacsko commented on YARN-10370: - [~shuzirra] [~snemeth] the vast majority of tasks in this JIRA

[jira] [Commented] (YARN-10686) Fix TestCapacitySchedulerAutoQueueCreation#testAutoQueueCreationFailsForEmptyPathWithAQCAndWeightMode

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302599#comment-17302599 ] Peter Bacsko commented on YARN-10686: - +1 Thanks [~zhuqi] for the patch and [~gandras] for the

[jira] [Updated] (YARN-10686) Fix TestCapacitySchedulerAutoQueueCreation#testAutoQueueCreationFailsForEmptyPathWithAQCAndWeightMode

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10686: Summary: Fix

[jira] [Commented] (YARN-10682) The scheduler monitor policies conf should trim values separated by comma

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302567#comment-17302567 ] Peter Bacsko commented on YARN-10682: - +1 Thanks for the patch [~zhuqi] and [~gandras] for the

[jira] [Updated] (YARN-10682) The scheduler monitor policies conf should trim values separated by comma

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-10682: Summary: The scheduler monitor policies conf should trim values separated by comma (was: The

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-16 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302548#comment-17302548 ] Peter Bacsko commented on YARN-10674: - Thanks [~zhuqi] this is definitely looks better. We're close

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-12 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300319#comment-17300319 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] I didn't have too much time to deeply review the

[jira] [Comment Edited] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-12 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300319#comment-17300319 ] Peter Bacsko edited comment on YARN-10674 at 3/12/21, 1:34 PM: --- [~zhuqi] I

[jira] [Comment Edited] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299602#comment-17299602 ] Peter Bacsko edited comment on YARN-10674 at 3/11/21, 3:25 PM: --- Ok, I did

[jira] [Comment Edited] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299602#comment-17299602 ] Peter Bacsko edited comment on YARN-10674 at 3/11/21, 2:43 PM: --- Ok, I did

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299602#comment-17299602 ] Peter Bacsko commented on YARN-10674: - Ok, I did some research, I think we 3 options to completely

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299466#comment-17299466 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] yes that's right. This is the default setting for

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299456#comment-17299456 ] Peter Bacsko commented on YARN-10674: - [~gandras] h - that's true. I just overcomplicated the

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299427#comment-17299427 ] Peter Bacsko commented on YARN-10674: - I'll do a deeper review today. [~gandras] you say: "Is

[jira] [Commented] (YARN-10685) Fixed some Typo in AbstractCSQueue.

2021-03-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298874#comment-17298874 ] Peter Bacsko commented on YARN-10685: - Sure, I'll check it out. > Fixed some Typo in

[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-03-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298861#comment-17298861 ] Peter Bacsko commented on YARN-10571: - [~gandras] thanks for the patch. I just have one question:

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298842#comment-17298842 ] Peter Bacsko commented on YARN-10674: - Ok, here is what I found: 1. {{RM_SCHEDULER_ENABLE_MONITORS}}

[jira] [Comment Edited] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298776#comment-17298776 ] Peter Bacsko edited comment on YARN-10674 at 3/10/21, 12:03 PM: [~zhuqi]

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298776#comment-17298776 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] thanks for the patch. I found a new property which is

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-09 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298156#comment-17298156 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] this is very interesting. If we set RM Monitors to

[jira] [Comment Edited] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-09 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298112#comment-17298112 ] Peter Bacsko edited comment on YARN-10674 at 3/9/21, 3:23 PM: -- [~zhuqi] I

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-09 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298112#comment-17298112 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] I have the following comments: 1. This change seems

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-09 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298092#comment-17298092 ] Peter Bacsko commented on YARN-10674: - Ok thanks, I'll review this one soon. > fs2cs: should support

[jira] [Commented] (YARN-10674) fs2cs: should support auto created queue deletion.

2021-03-09 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298074#comment-17298074 ] Peter Bacsko commented on YARN-10674: - [~zhuqi] am I right when I think that this patch depends on

<    1   2   3   4   5   6   7   8   9   10   >