[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797023#comment-16797023 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] the reason I introduced the method reference is

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797267#comment-16797267 ] Peter Bacsko commented on YARN-9398: I'll try to fix this quickly including the warnings. > Javadoc

[jira] [Comment Edited] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797023#comment-16797023 ] Peter Bacsko edited comment on YARN-9267 at 3/20/19 10:32 AM: -- [~devaraj.k]

[jira] [Assigned] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-9398: -- Assignee: Peter Bacsko (was: Daniel Templeton) > Javadoc error on FPGA related java files >

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797282#comment-16797282 ] Peter Bacsko commented on YARN-9398: [~templedf] [~eyang] pls check patch v2. > Javadoc error on FPGA

[jira] [Updated] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9398: --- Attachment: YARN-9398-002.patch > Javadoc error on FPGA related java files >

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797190#comment-16797190 ] Peter Bacsko commented on YARN-9398: Shall we fix warnings in a separate JIRA? > Javadoc error on

[jira] [Commented] (YARN-9356) Add more tests to ratio method in TestResourceCalculator

[ https://issues.apache.org/jira/browse/YARN-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797175#comment-16797175 ] Peter Bacsko commented on YARN-9356: +1 (non-binding) > Add more tests to ratio method in

[jira] [Updated] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9267: --- Attachment: YARN-9267-008.patch > General improvements in FpgaResourceHandlerImpl >

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796011#comment-16796011 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] I think now you can submit the patch. > General

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795916#comment-16795916 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] yes there was a commit in the meantime which caused

[jira] [Commented] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795918#comment-16795918 ] Peter Bacsko commented on YARN-9268: [~devaraj.k] this patch depends on the previous ones (the same

[jira] [Updated] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9267: --- Attachment: YARN-9267-007.patch > General improvements in FpgaResourceHandlerImpl >

[jira] [Updated] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9268: --- Attachment: YARN-9268-004.patch > General improvements in FpgaDevice >

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795928#comment-16795928 ] Peter Bacsko commented on YARN-9398: Thanks [~eyang] for reporting. Will fix these soon. > Javadoc

[jira] [Assigned] (YARN-9398) Javadoc error on FPGA related java files

[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-9398: -- Assignee: Peter Bacsko > Javadoc error on FPGA related java files >

[jira] [Commented] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795944#comment-16795944 ] Peter Bacsko commented on YARN-9268: Just as I thought, it fails to apply. It should be good after

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794947#comment-16794947 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] thanks for the tip, will check this out. > General

[jira] [Commented] (YARN-9358) Add javadoc to new methods introduced in FSQueueMetrics with YARN-9322

[ https://issues.apache.org/jira/browse/YARN-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796143#comment-16796143 ] Peter Bacsko commented on YARN-9358: Just minor things: * "fair share for queue" --> I think "fair

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798235#comment-16798235 ] Peter Bacsko commented on YARN-9267: Ah sure, didn't see that. Will fix it in a minute. > General

[jira] [Updated] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9267: --- Attachment: YARN-9267-010.patch > General improvements in FpgaResourceHandlerImpl >

[jira] [Commented] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798394#comment-16798394 ] Peter Bacsko commented on YARN-9268: Test failures + checkstyle are fixed in patch v5. > General

[jira] [Updated] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9268: --- Attachment: YARN-9268-005.patch > General improvements in FpgaDevice >

[jira] [Commented] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798485#comment-16798485 ] Peter Bacsko commented on YARN-9268: Test failure seems to be unrelated. > General improvements in

[jira] [Commented] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799070#comment-16799070 ] Peter Bacsko commented on YARN-9268: [~devaraj.k] thanks for the comments. 1. "aliasDevName is used

[jira] [Updated] (YARN-9268) General improvements in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9268: --- Attachment: YARN-9268-006.patch > General improvements in FpgaDevice >

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797635#comment-16797635 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] modified the patch as you requested. > General

[jira] [Commented] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762946#comment-16762946 ] Peter Bacsko commented on YARN-9269: Thanks [~adam.antal] for the comments. 1. {{allowedFpgas}} is

[jira] [Updated] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9270: --- Attachment: YARN-9270-001.patch > Minor cleanup in TestFpgaDiscoverer >

[jira] [Updated] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9269: --- Attachment: YARN-9269-001.patch > Minor cleanup in FpgaResourceAllocator >

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761821#comment-16761821 ] Peter Bacsko commented on YARN-9265: Today we had a meeting with [~snemeth], [~shuzirra], [~zsiegl],

[jira] [Assigned] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-9265: -- Assignee: Peter Bacsko > FPGA plugin fails to recognize Intel Processing Accelerator Card >

[jira] [Comment Edited] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761821#comment-16761821 ] Peter Bacsko edited comment on YARN-9265 at 2/6/19 3:08 PM: Today we had a

[jira] [Updated] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9269: --- Attachment: YARN-9269-002.patch > Minor cleanup in FpgaResourceAllocator >

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763083#comment-16763083 ] Peter Bacsko commented on YARN-9265: [~snemeth] yes that is a possibility. A property value has to be

[jira] [Comment Edited] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763083#comment-16763083 ] Peter Bacsko edited comment on YARN-9265 at 2/7/19 9:16 PM: [~snemeth] yes

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-007.patch > Various fixes are needed in IntelFpgaOpenclPlugin >

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771005#comment-16771005 ] Peter Bacsko commented on YARN-9265: Thanks [~zsiegl] it's a reasonable improvement. Will update the

[jira] [Updated] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9265: --- Attachment: YARN-9265-003.patch > FPGA plugin fails to recognize Intel Processing Accelerator Card >

[jira] [Updated] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9265: --- Attachment: YARN-9265-004.patch > FPGA plugin fails to recognize Intel Processing Accelerator Card >

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771097#comment-16771097 ] Peter Bacsko commented on YARN-9265: Fixed chekstyle + findbugs issues. Regarding Findbugs, I removed

[jira] [Commented] (YARN-9267) Various fixes are needed in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771240#comment-16771240 ] Peter Bacsko commented on YARN-9267: Thanks for the comment [~snemeth]. "FpgaDevice.hash should

[jira] [Updated] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9265: --- Attachment: YARN-9265-005.patch > FPGA plugin fails to recognize Intel Processing Accelerator Card >

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-004.patch > Various fixes are needed in IntelFpgaOpenclPlugin >

[jira] [Updated] (YARN-9268) Various fixes are needed in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9268: --- Attachment: YARN-9268-003.patch > Various fixes are needed in FpgaDevice >

[jira] [Commented] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767085#comment-16767085 ] Peter Bacsko commented on YARN-9270: " could we remove the wildcard import import java.util.*."

[jira] [Commented] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767153#comment-16767153 ] Peter Bacsko commented on YARN-9270: Uploaded v2. Changes: * FpgaDiscoverer is no longer singleton *

[jira] [Updated] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9270: --- Attachment: YARN-9270-002.patch > Minor cleanup in TestFpgaDiscoverer >

[jira] [Updated] (YARN-9268) Various fixes are needed in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9268: --- Description: Need to fix the following in the class {{FpgaDevice}}: * It implements {{Comparable}},

[jira] [Commented] (YARN-9217) Nodemanager will fail to start if GPU is misconfigured on the node or GPU drivers missing

[ https://issues.apache.org/jira/browse/YARN-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767203#comment-16767203 ] Peter Bacsko commented on YARN-9217: Minor comments: 1. Do we need a separate variable here?

[jira] [Commented] (YARN-9139) Simplify initializer code of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767257#comment-16767257 ] Peter Bacsko commented on YARN-9139: [~snemeth] 1. Please fix the remaining checkstyle issues 2. Why

[jira] [Comment Edited] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263 ] Peter Bacsko edited comment on YARN-9138 at 2/13/19 2:47 PM: - [~snemeth] 1.

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263 ] Peter Bacsko commented on YARN-9138: [~snemeth] now you can remove this unnecessary code-paths:

[jira] [Commented] (YARN-9133) Make tests more easy to comprehend in TestGpuResourceHandler

[ https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767279#comment-16767279 ] Peter Bacsko commented on YARN-9133: +1 (non-binding) > Make tests more easy to comprehend in

[jira] [Commented] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767226#comment-16767226 ] Peter Bacsko commented on YARN-9118: Minor: {{Configuration conf = new Configuration(false);}} - this

[jira] [Comment Edited] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263 ] Peter Bacsko edited comment on YARN-9138 at 2/13/19 2:38 PM: - [~snemeth] now

[jira] [Updated] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9265: --- Attachment: YARN-9265-002.patch > FPGA plugin fails to recognize Intel Processing Accelerator Card >

[jira] [Comment Edited] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767351#comment-16767351 ] Peter Bacsko edited comment on YARN-9118 at 2/13/19 4:03 PM: - "If I put those

[jira] [Commented] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767351#comment-16767351 ] Peter Bacsko commented on YARN-9118: "If I put those method names into a newline, it looks really

[jira] [Updated] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9269: --- Attachment: YARN-9269-003.patch > Minor cleanup in FpgaResourceAllocator >

[jira] [Updated] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9270: --- Attachment: YARN-9270-003.patch > Minor cleanup in TestFpgaDiscoverer >

[jira] [Commented] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768139#comment-16768139 ] Peter Bacsko commented on YARN-9270: Patch v3 - handled checkstyle issues. > Minor cleanup in

[jira] [Commented] (YARN-9264) [Umbrella] Follow-up on IntelOpenCL FPGA plugin

[ https://issues.apache.org/jira/browse/YARN-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768158#comment-16768158 ] Peter Bacsko commented on YARN-9264: Suggested order of committing the patches: YARN-9265 and

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768340#comment-16768340 ] Peter Bacsko commented on YARN-9138: +1 non-binding > Test error handling of nvidia-smi binary

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768437#comment-16768437 ] Peter Bacsko commented on YARN-9266: Thanks [~adam.antal] I'll go through your suggestions one-by-one

[jira] [Commented] (YARN-9139) Simplify initializer code of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768333#comment-16768333 ] Peter Bacsko commented on YARN-9139: +1 non-binding > Simplify initializer code of GpuDiscoverer >

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768360#comment-16768360 ] Peter Bacsko commented on YARN-9135: {quote}Using the immutable type in the definition of the methods

[jira] [Commented] (YARN-9235) If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown

[ https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768331#comment-16768331 ] Peter Bacsko commented on YARN-9235: [~bsteinbach] can you add a simple unit test for this scenario?

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Description: Problems identified in this class: * {{InnerShellExecutor}} ignores the timeout

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768648#comment-16768648 ] Peter Bacsko commented on YARN-9266: "Some of the refactors that you performed are not included in the

[jira] [Commented] (YARN-9098) Separate mtab file reader code and cgroups file system hierarchy parser code from CGroupsHandlerImpl and ResourceHandlerModule

[ https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768590#comment-16768590 ] Peter Bacsko commented on YARN-9098: After some discussion with Szilard, now I can +1 this

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767287#comment-16767287 ] Peter Bacsko commented on YARN-9135: Thanks for updating the patch [~snemeth]. Please make sure that

[jira] [Commented] (YARN-9098) Separate mtab file reader code and cgroups file system hierarchy parser code from CGroupsHandlerImpl and ResourceHandlerModule

[ https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767298#comment-16767298 ] Peter Bacsko commented on YARN-9098: Maybe it's just nitpicking, but... {noformat} public

[jira] [Commented] (YARN-9123) Clean up and split testcases in TestNMWebServices for GPU support

[ https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767291#comment-16767291 ] Peter Bacsko commented on YARN-9123: " testGetNMResourceInfoFailBecauseOfUnknownPlugin is a bit

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-006.patch > Various fixes are needed in IntelFpgaOpenclPlugin >

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-005.patch > Various fixes are needed in IntelFpgaOpenclPlugin >

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769392#comment-16769392 ] Peter Bacsko commented on YARN-9266: Test failure is unrelated, see

[jira] [Comment Edited] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762595#comment-16762595 ] Peter Bacsko edited comment on YARN-9266 at 2/7/19 11:54 AM: - Patch v2 -

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762595#comment-16762595 ] Peter Bacsko commented on YARN-9266: Patvh v2 - removed {{aliasMap}}, fixed a lot of checkstyle

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-002.patch > Various fixes are needed in IntelFpgaOpenclPlugin >

[jira] [Commented] (YARN-9264) [Umbrella] Follow-up on IntelOpenCL FPGA plugin

[ https://issues.apache.org/jira/browse/YARN-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771997#comment-16771997 ] Peter Bacsko commented on YARN-9264: [~sunilg] [~tangzhankun] please review the first three patch:

[jira] [Updated] (YARN-9267) Various fixes are needed in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9267: --- Attachment: YARN-9267-002.patch > Various fixes are needed in FpgaResourceHandlerImpl >

[jira] [Updated] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9266: --- Attachment: YARN-9266-003.patch > Various fixes are needed in IntelFpgaOpenclPlugin >

[jira] [Updated] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9265: --- Attachment: YARN-9265-001.patch > FPGA plugin fails to recognize Intel Processing Accelerator Card >

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764841#comment-16764841 ] Peter Bacsko commented on YARN-9265: I started to work on this. I decided to handle the script output

[jira] [Commented] (YARN-9267) Various fixes are needed in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771960#comment-16771960 ] Peter Bacsko commented on YARN-9267: [~snemeth] you can check it again. > Various fixes are needed in

[jira] [Commented] (YARN-9098) Separate mtab file reader code and cgroups file system hierarchy parser code from CGroupsHandlerImpl and ResourceHandlerModule

[ https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751123#comment-16751123 ] Peter Bacsko commented on YARN-9098: Minor things: 1. Delete the {{tmpDir}} in {{testSelectCgroup}}

[jira] [Commented] (YARN-9092) Create an object for cgroups mount enable and cgroups mount path as they belong together

[ https://issues.apache.org/jira/browse/YARN-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1675#comment-1675 ] Peter Bacsko commented on YARN-9092: +1 LGTM (non-binding) > Create an object for cgroups mount

[jira] [Commented] (YARN-9099) GpuResourceAllocator.getReleasingGpus calculates number of GPUs in a wrong way

[ https://issues.apache.org/jira/browse/YARN-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751126#comment-16751126 ] Peter Bacsko commented on YARN-9099: [~snemeth] as [~tangzhankun] pointed out, is it possible to add a

[jira] [Commented] (YARN-9213) RM Web UI does not show custom resource allocations for containers page

[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751133#comment-16751133 ] Peter Bacsko commented on YARN-9213: Just one question regarding this code: {noformat} 161

[jira] [Assigned] (YARN-9264) [Umbrella] Follow-up on IntelOpenCL FPGA plugin

[ https://issues.apache.org/jira/browse/YARN-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko reassigned YARN-9264: -- Assignee: Peter Bacsko > [Umbrella] Follow-up on IntelOpenCL FPGA plugin >

[jira] [Created] (YARN-9264) [Umbrella] Follow-up on IntelOpenCL FPGA plugin

Peter Bacsko created YARN-9264: -- Summary: [Umbrella] Follow-up on IntelOpenCL FPGA plugin Key: YARN-9264 URL: https://issues.apache.org/jira/browse/YARN-9264 Project: Hadoop YARN Issue Type:

[jira] [Created] (YARN-9268) Various fixes are needed in FpgaDevice

Peter Bacsko created YARN-9268: -- Summary: Various fixes are needed in FpgaDevice Key: YARN-9268 URL: https://issues.apache.org/jira/browse/YARN-9268 Project: Hadoop YARN Issue Type: Sub-task

[jira] [Created] (YARN-9269) Minor cleanup in FpgaResourceAllocator

Peter Bacsko created YARN-9269: -- Summary: Minor cleanup in FpgaResourceAllocator Key: YARN-9269 URL: https://issues.apache.org/jira/browse/YARN-9269 Project: Hadoop YARN Issue Type: Sub-task

[jira] [Updated] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9269: --- Description: Some stuff that we observed: * {{addFpga()}} - we check for duplicate devices, but we

[jira] [Created] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

Peter Bacsko created YARN-9270: -- Summary: Minor cleanup in TestFpgaDiscoverer Key: YARN-9270 URL: https://issues.apache.org/jira/browse/YARN-9270 Project: Hadoop YARN Issue Type: Sub-task

[jira] [Comment Edited] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758296#comment-16758296 ] Peter Bacsko edited comment on YARN-9265 at 2/1/19 1:29 PM: We _really_ a good

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758296#comment-16758296 ] Peter Bacsko commented on YARN-9265: We _really_ a good solution to this. There are several approach I

[jira] [Created] (YARN-9267) Various fixes are needed in FpgaResourceHandlerImpl

Peter Bacsko created YARN-9267: -- Summary: Various fixes are needed in FpgaResourceHandlerImpl Key: YARN-9267 URL: https://issues.apache.org/jira/browse/YARN-9267 Project: Hadoop YARN Issue

[jira] [Updated] (YARN-9268) Various fixes are needed in FpgaDevice

[ https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko updated YARN-9268: --- Description: Need to fix the following the class {{FpgaDevice}}: * It implements {{Comparable}}, but

<    1   2   3   4   5   6   7   8   9   10   >