[jira] [Commented] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165892#comment-16165892 ] Sen Zhao commented on YARN-6878: I find other wrong order about asserEqual() in TestCapacityScheduler and some unused import. So I submit patch 001 to fix these. > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165892#comment-16165892 ] Sen Zhao edited comment on YARN-6878 at 9/14/17 7:42 AM: - I find other wrong order about asserEqual() in TestCapacityScheduler and some unused import. So I submit patch 001 to fix these. Patch 002 to fix the checkstyle. was (Author: sen zhao): I find other wrong order about asserEqual() in TestCapacityScheduler and some unused import. So I submit patch 001 to fix these. > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-6878: --- Attachment: YARN-6878.003.patch > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch, > YARN-6878.003.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165933#comment-16165933 ] Sen Zhao commented on YARN-6878: Oh, I did not notice this. I will fix it soon. Thanks, [~templedf] > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Reopened] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reopened YARN-7153: > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao >Assignee: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval > duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are > handled the same way. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172642#comment-16172642
]
Sen Zhao commented on YARN-7001:
[~miklos.szeg...@cloudera.com], I add a unit test in this patch. Could you
review it?
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7001:
---
Attachment: YARN-7001.002.patch
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171360#comment-16171360 ] Sen Zhao commented on YARN-6878: The failed tests are unrelated. [~templedf], can you give me some advises about the latest patch? > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch, > YARN-6878.003.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7001:
---
Attachment: YARN-7001.001.patch
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
> Attachments: YARN-7001.001.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao reassigned YARN-7001:
--
Assignee: Sen Zhao
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171520#comment-16171520
]
Sen Zhao commented on YARN-7001:
Hi, [~miklos.szeg...@cloudera.com]. I would like to try this issue. And I will
submit a patch.
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7001:
---
Attachment: YARN-7001.003.patch
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch,
> YARN-7001.003.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172824#comment-16172824
]
Sen Zhao commented on YARN-7001:
Patch 003 to fix failed junit test.
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch,
> YARN-7001.003.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7001:
---
Attachment: YARN-7001.004.patch
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch,
> YARN-7001.003.patch, YARN-7001.004.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172887#comment-16172887
]
Sen Zhao commented on YARN-7001:
Patch 004 to fix checkstyle.
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch,
> YARN-7001.003.patch, YARN-7001.004.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177445#comment-16177445 ] Sen Zhao commented on YARN-6878: Thanks for your review and commit, [~templedf]! > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Fix For: 3.1.0 > > Attachments: YARN-6878.001.patch, YARN-6878.002.patch, > YARN-6878.003.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7236) [Docs] In the TimelineClient example, there are some confusing logic
[
https://issues.apache.org/jira/browse/YARN-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7236:
---
Attachment: YARN-7236.001.patch
> [Docs] In the TimelineClient example, there are some confusing logic
>
>
> Key: YARN-7236
> URL: https://issues.apache.org/jira/browse/YARN-7236
> Project: Hadoop YARN
> Issue Type: Bug
> Components: docs, timelineclient
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Trivial
> Attachments: YARN-7236.001.patch
>
>
> Firstly, the entity and timelineClient are not defined in the example;
> Secondly, "TimelinePutResponse response" is defined twice;
> Finally, there is a problem with sequential logic.
> Like this:
> {quote}
> TimelinePutResponse response = client.putEntities(entity);
> ...
> myEntity.addEvent(event);
> TimelinePutResponse response = timelineClient.putEntities(entity);
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7236) [Docs] In the TimelineClient example, there are some confusing logic
[ https://issues.apache.org/jira/browse/YARN-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7236: --- Description: Firstly, the entity is not defined in the example; Secondly, "TimelinePutResponse response" is defined twice; Finally, there is a problem with sequential logic. Like this: TimelinePutResponse response = client.putEntities(entity); ... myEntity.addEvent(event); TimelinePutResponse response = timelineClient.putEntities(entity); > [Docs] In the TimelineClient example, there are some confusing logic > > > Key: YARN-7236 > URL: https://issues.apache.org/jira/browse/YARN-7236 > Project: Hadoop YARN > Issue Type: Bug > Components: docs, timelineclient >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Trivial > > Firstly, the entity is not defined in the example; > Secondly, "TimelinePutResponse response" is defined twice; > Finally, there is a problem with sequential logic. > Like this: > TimelinePutResponse response = client.putEntities(entity); > ... > myEntity.addEvent(event); > TimelinePutResponse response = timelineClient.putEntities(entity); -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7236) [Docs] In the TimelineClient example, there are some confusing logic
[
https://issues.apache.org/jira/browse/YARN-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7236:
---
Description:
Firstly, the entity is not defined in the example;
Secondly, "TimelinePutResponse response" is defined twice;
Finally, there is a problem with sequential logic.
Like this:
{quote}
TimelinePutResponse response = client.putEntities(entity);
...
myEntity.addEvent(event);
TimelinePutResponse response = timelineClient.putEntities(entity);
{quote}
was:
Firstly, the entity is not defined in the example;
Secondly, "TimelinePutResponse response" is defined twice;
Finally, there is a problem with sequential logic.
Like this:
TimelinePutResponse response = client.putEntities(entity);
...
myEntity.addEvent(event);
TimelinePutResponse response = timelineClient.putEntities(entity);
> [Docs] In the TimelineClient example, there are some confusing logic
>
>
> Key: YARN-7236
> URL: https://issues.apache.org/jira/browse/YARN-7236
> Project: Hadoop YARN
> Issue Type: Bug
> Components: docs, timelineclient
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Trivial
>
> Firstly, the entity is not defined in the example;
> Secondly, "TimelinePutResponse response" is defined twice;
> Finally, there is a problem with sequential logic.
> Like this:
> {quote}
> TimelinePutResponse response = client.putEntities(entity);
> ...
> myEntity.addEvent(event);
> TimelinePutResponse response = timelineClient.putEntities(entity);
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7236) [Docs] In the TimelineClient example, there are some confusing logic
[
https://issues.apache.org/jira/browse/YARN-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7236:
---
Description:
Firstly, the entity and timelineClient are not defined in the example;
Secondly, "TimelinePutResponse response" is defined twice;
Finally, there is a problem with sequential logic.
Like this:
{quote}
TimelinePutResponse response = client.putEntities(entity);
...
myEntity.addEvent(event);
TimelinePutResponse response = timelineClient.putEntities(entity);
{quote}
was:
Firstly, the entity is not defined in the example;
Secondly, "TimelinePutResponse response" is defined twice;
Finally, there is a problem with sequential logic.
Like this:
{quote}
TimelinePutResponse response = client.putEntities(entity);
...
myEntity.addEvent(event);
TimelinePutResponse response = timelineClient.putEntities(entity);
{quote}
> [Docs] In the TimelineClient example, there are some confusing logic
>
>
> Key: YARN-7236
> URL: https://issues.apache.org/jira/browse/YARN-7236
> Project: Hadoop YARN
> Issue Type: Bug
> Components: docs, timelineclient
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Trivial
>
> Firstly, the entity and timelineClient are not defined in the example;
> Secondly, "TimelinePutResponse response" is defined twice;
> Finally, there is a problem with sequential logic.
> Like this:
> {quote}
> TimelinePutResponse response = client.putEntities(entity);
> ...
> myEntity.addEvent(event);
> TimelinePutResponse response = timelineClient.putEntities(entity);
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7045) Remove FSLeafQueue#addAppSchedulable
[
https://issues.apache.org/jira/browse/YARN-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174542#comment-16174542
]
Sen Zhao commented on YARN-7045:
The failed test is unrelated. Please review the latest patch, thanks [~yufeigu].
> Remove FSLeafQueue#addAppSchedulable
>
>
> Key: YARN-7045
> URL: https://issues.apache.org/jira/browse/YARN-7045
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Reporter: Yufei Gu
>Assignee: Sen Zhao
> Labels: newbie++
> Attachments: YARN-7045.001.patch, YARN-7045.002.patch
>
>
> It is only for test, and not necessary be there since we got method
> {{addApp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-7236) [Docs] In the TimelineClient example, there are some confusing logic
Sen Zhao created YARN-7236: -- Summary: [Docs] In the TimelineClient example, there are some confusing logic Key: YARN-7236 URL: https://issues.apache.org/jira/browse/YARN-7236 Project: Hadoop YARN Issue Type: Bug Components: docs, timelineclient Reporter: Sen Zhao Assignee: Sen Zhao Priority: Trivial -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7045) Remove FSLeafQueue#addAppSchedulable
[
https://issues.apache.org/jira/browse/YARN-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7045:
---
Attachment: YARN-7045.002.patch
> Remove FSLeafQueue#addAppSchedulable
>
>
> Key: YARN-7045
> URL: https://issues.apache.org/jira/browse/YARN-7045
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Reporter: Yufei Gu
>Assignee: Sen Zhao
> Labels: newbie++
> Attachments: YARN-7045.001.patch, YARN-7045.002.patch
>
>
> It is only for test, and not necessary be there since we got method
> {{addApp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7045) Remove FSLeafQueue#addAppSchedulable
[
https://issues.apache.org/jira/browse/YARN-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao reassigned YARN-7045:
--
Assignee: Sen Zhao
> Remove FSLeafQueue#addAppSchedulable
>
>
> Key: YARN-7045
> URL: https://issues.apache.org/jira/browse/YARN-7045
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Reporter: Yufei Gu
>Assignee: Sen Zhao
> Labels: newbie++
>
> It is only for test, and not necessary be there since we got method
> {{addApp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174317#comment-16174317 ] Sen Zhao commented on YARN-6878: Thanks for your review, [~templedf] > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch, > YARN-6878.003.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7045) Remove FSLeafQueue#addAppSchedulable
[
https://issues.apache.org/jira/browse/YARN-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174310#comment-16174310
]
Sen Zhao commented on YARN-7045:
HI, [~yufeigu]. I would like to try this issue.
> Remove FSLeafQueue#addAppSchedulable
>
>
> Key: YARN-7045
> URL: https://issues.apache.org/jira/browse/YARN-7045
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Reporter: Yufei Gu
>Assignee: Sen Zhao
> Labels: newbie++
>
> It is only for test, and not necessary be there since we got method
> {{addApp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7045) Remove FSLeafQueue#addAppSchedulable
[
https://issues.apache.org/jira/browse/YARN-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7045:
---
Attachment: YARN-7045.001.patch
> Remove FSLeafQueue#addAppSchedulable
>
>
> Key: YARN-7045
> URL: https://issues.apache.org/jira/browse/YARN-7045
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Reporter: Yufei Gu
>Assignee: Sen Zhao
> Labels: newbie++
> Attachments: YARN-7045.001.patch
>
>
> It is only for test, and not necessary be there since we got method
> {{addApp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-6878: --- Attachment: YARN-6878.003.patch > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch, > YARN-6878.003.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-6878: --- Attachment: (was: YARN-6878.003.patch) > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169597#comment-16169597
]
Sen Zhao commented on YARN-7172:
Thank you, [~leftnoteasy] and [~templedf]
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Fix For: 3.1.0
>
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch, YARN-7172.004.patch, YARN-7172.005.patch,
> YARN-7172.006.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169538#comment-16169538
]
Sen Zhao commented on YARN-7172:
HI, [~templedf]. Could you help me to review the latest patch? If there are
other problems, I will fix it
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch, YARN-7172.004.patch, YARN-7172.005.patch,
> YARN-7172.006.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-6878: --- Attachment: YARN-6878.001.patch > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-6878: -- Assignee: Sen Zhao > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7045) Remove FSLeafQueue#addAppSchedulable
[
https://issues.apache.org/jira/browse/YARN-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175765#comment-16175765
]
Sen Zhao commented on YARN-7045:
Thanks for your review and commit, [~yufeigu]
> Remove FSLeafQueue#addAppSchedulable
>
>
> Key: YARN-7045
> URL: https://issues.apache.org/jira/browse/YARN-7045
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Reporter: Yufei Gu
>Assignee: Sen Zhao
> Labels: newbie++
> Fix For: 2.9.0, 3.1.0
>
> Attachments: YARN-7045.001.patch, YARN-7045.002.patch
>
>
> It is only for test, and not necessary be there since we got method
> {{addApp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6878) TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the args to assertEqual() in the wrong order
[ https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-6878: --- Attachment: YARN-6878.002.patch > TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the > args to assertEqual() in the wrong order > -- > > Key: YARN-6878 > URL: https://issues.apache.org/jira/browse/YARN-6878 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, test >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-6878.001.patch, YARN-6878.002.patch > > > The expected value should come before the actual value. It would be nice to > add some assert messages as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao reassigned YARN-7172:
--
Assignee: Sen Zhao
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7172:
---
Attachment: YARN-7172.001.patch
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
> Labels: newbie
> Attachments: YARN-7172.001.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-7153: -- Assignee: Sen Zhao > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao >Assignee: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval > duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are > handled the same way. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158239#comment-16158239
]
Sen Zhao commented on YARN-7172:
[~templedf],could you please add me into the contributor list so that I can
submit a patch.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
> Labels: newbie
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7172:
---
Attachment: YARN-7172.004.patch
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch, YARN-7172.004.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160741#comment-16160741
]
Sen Zhao commented on YARN-7172:
Patch to solve the issue of checkstyle.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch, YARN-7172.004.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153021#comment-16153021 ] Sen Zhao commented on YARN-7153: TestLogsCLI fails in trunk. > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl.java duplicate that in > AMRMClientAsync.java. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7153: --- Component/s: client > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl.java duplicate that in > AMRMClientAsync.java. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Issue Comment Deleted] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7153: --- Comment: was deleted (was: TestLogsCLI fails in trunk.) > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval > duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are > handled the same way. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164020#comment-16164020
]
Sen Zhao commented on YARN-7172:
Thanks for your review, [~templedf] and [~leftnoteasy]. I will commit patch 006
to remove unused imports.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch, YARN-7172.004.patch, YARN-7172.005.patch,
> YARN-7172.006.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7172:
---
Attachment: YARN-7172.006.patch
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch, YARN-7172.004.patch, YARN-7172.005.patch,
> YARN-7172.006.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7172:
---
Attachment: YARN-7172.002.patch
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159791#comment-16159791
]
Sen Zhao commented on YARN-7172:
Patch to address checkstyle issues.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158138#comment-16158138
]
Sen Zhao commented on YARN-7172:
I am very interested in this. For a while I will provide a patch.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
> Labels: newbie
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160590#comment-16160590
]
Sen Zhao commented on YARN-7172:
Thanks, [~templedf]. I will submit a patch to resolve this.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7172) ResourceCalculator.fitsIn() should not take a cluster resource parameter
[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7172:
---
Attachment: YARN-7172.003.patch
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
>
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch,
> YARN-7172.003.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5913) Consolidate "resource" and "amResourceRequest" in ApplicationSubmissionContext
[ https://issues.apache.org/jira/browse/YARN-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162844#comment-16162844 ] Sen Zhao commented on YARN-5913: In ApplicationSubmissionContext, "priority" can also be consolidate into "ResourceRequest". Is this right? And I would like to try this issue. > Consolidate "resource" and "amResourceRequest" in ApplicationSubmissionContext > -- > > Key: YARN-5913 > URL: https://issues.apache.org/jira/browse/YARN-5913 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Reporter: Yufei Gu >Priority: Minor > Labels: newbie > > Usage of these two variables overlaps and causes confusion. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7153: --- Description: I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are handled the same way. Submit a patch to fix it! (was: I notice there are some codes in AMRMClientAsyncImpl.java duplicate that in AMRMClientAsync.java. Submit a patch to fix it!) > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval > duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are > handled the same way. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156309#comment-16156309 ] Sen Zhao commented on YARN-7153: This patch simply removes duplicate code and does not require new tests. And the TestLogsCLI failure is unrelated and tracked by YARN-7148. > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval > duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are > handled the same way. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
[
https://issues.apache.org/jira/browse/YARN-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7255:
---
Description: In {{CapacityScheduler.allocate()}}, there is a call
{{getResourceCalculator()}} to get a value to pass as the resourceCalculator
parameter to {{getAllocation()}}, but the parameter is unuse in the method. So
I remove the parameter. (was: In CapacityScheduler.allocate(), there is a call
{{getResourceCalculator()}} to get a value to pass as the resourceCalculator
parameter to {{getAllocation()}}, but the parameter is unuse in the method. So
I remove the parameter.)
> FiCaSchedulerApp.getAllocation() have a unuse parameter
> ---
>
> Key: YARN-7255
> URL: https://issues.apache.org/jira/browse/YARN-7255
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Minor
> Attachments: YARN-7255.001.patch
>
>
> In {{CapacityScheduler.allocate()}}, there is a call
> {{getResourceCalculator()}} to get a value to pass as the resourceCalculator
> parameter to {{getAllocation()}}, but the parameter is unuse in the method.
> So I remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
[
https://issues.apache.org/jira/browse/YARN-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7255:
---
Description: In {{CapacityScheduler.allocate()}}, there is a call
{{getResourceCalculator()}} to get a value to pass as the resourceCalculator
parameter to {{getAllocation()}}, but the parameter is unused in the method. So
I remove the parameter. (was: In {{CapacityScheduler.allocate()}}, there is a
call {{getResourceCalculator()}} to get a value to pass as the
resourceCalculator parameter to {{getAllocation()}}, but the parameter is unuse
in the method. So I remove the parameter.)
> FiCaSchedulerApp.getAllocation() have a unuse parameter
> ---
>
> Key: YARN-7255
> URL: https://issues.apache.org/jira/browse/YARN-7255
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Minor
> Attachments: YARN-7255.001.patch
>
>
> In {{CapacityScheduler.allocate()}}, there is a call
> {{getResourceCalculator()}} to get a value to pass as the resourceCalculator
> parameter to {{getAllocation()}}, but the parameter is unused in the method.
> So I remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
[
https://issues.apache.org/jira/browse/YARN-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181828#comment-16181828
]
Sen Zhao commented on YARN-7255:
This modification does not involve any tests and the failed tests are
unrelated.
> FiCaSchedulerApp.getAllocation() have a unuse parameter
> ---
>
> Key: YARN-7255
> URL: https://issues.apache.org/jira/browse/YARN-7255
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Minor
> Attachments: YARN-7255.001.patch
>
>
> In {{CapacityScheduler.allocate()}}, there is a call
> {{getResourceCalculator()}} to get a value to pass as the resourceCalculator
> parameter to {{getAllocation()}}, but the parameter is unused in the method.
> So I remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7222) Merge org.apache.hadoop.yarn.server.resourcemanager.NodeManager with MockNM
[ https://issues.apache.org/jira/browse/YARN-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-7222: -- Assignee: Sen Zhao I agree with you. If you have time, please review the patch. > Merge org.apache.hadoop.yarn.server.resourcemanager.NodeManager with MockNM > --- > > Key: YARN-7222 > URL: https://issues.apache.org/jira/browse/YARN-7222 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 3.1.0 >Reporter: Yufei Gu >Assignee: Sen Zhao > Attachments: YARN-7222.001.patch > > > The existence of org.apache.hadoop.yarn.server.resourcemanager.NodeManager is > confusing. It is only for RM testing and basically another MockNM. There is > no Java Doc for class, which easily let people consider it a real > Nodemanager. Suggest to merge it with MockNM. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7222) Merge org.apache.hadoop.yarn.server.resourcemanager.NodeManager with MockNM
[ https://issues.apache.org/jira/browse/YARN-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7222: --- Attachment: YARN-7222.002.patch Patch 002 to fix the checkstytle. > Merge org.apache.hadoop.yarn.server.resourcemanager.NodeManager with MockNM > --- > > Key: YARN-7222 > URL: https://issues.apache.org/jira/browse/YARN-7222 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 3.1.0 >Reporter: Yufei Gu >Assignee: Sen Zhao > Attachments: YARN-7222.001.patch, YARN-7222.002.patch > > > The existence of org.apache.hadoop.yarn.server.resourcemanager.NodeManager is > confusing. It is only for RM testing and basically another MockNM. There is > no Java Doc for class, which easily let people consider it a real > Nodemanager. Suggest to merge it with MockNM. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7222) Merge org.apache.hadoop.yarn.server.resourcemanager.NodeManager with MockNM
[ https://issues.apache.org/jira/browse/YARN-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7222: --- Attachment: YARN-7222.001.patch > Merge org.apache.hadoop.yarn.server.resourcemanager.NodeManager with MockNM > --- > > Key: YARN-7222 > URL: https://issues.apache.org/jira/browse/YARN-7222 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 3.1.0 >Reporter: Yufei Gu > Attachments: YARN-7222.001.patch > > > The existence of org.apache.hadoop.yarn.server.resourcemanager.NodeManager is > confusing. It is only for RM testing and basically another MockNM. There is > no Java Doc for class, which easily let people consider it a real > Nodemanager. Suggest to merge it with MockNM. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
Sen Zhao created YARN-7255: -- Summary: FiCaSchedulerApp.getAllocation() have a unuse parameter Key: YARN-7255 URL: https://issues.apache.org/jira/browse/YARN-7255 Project: Hadoop YARN Issue Type: Bug Reporter: Sen Zhao Assignee: Sen Zhao Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180044#comment-16180044 ] Sen Zhao commented on YARN-7153: Thanks for your review, [~ajisakaa]! > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Minor > Fix For: 2.9.0, 3.0.0-beta1, 3.1.0 > > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl#setHeartbeatInterval > duplicate that in AMRMClientAsync#setHeartbeatInterval. The two methods are > handled the same way. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
[ https://issues.apache.org/jira/browse/YARN-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7255: --- Component/s: capacity scheduler > FiCaSchedulerApp.getAllocation() have a unuse parameter > --- > > Key: YARN-7255 > URL: https://issues.apache.org/jira/browse/YARN-7255 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
[
https://issues.apache.org/jira/browse/YARN-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7255:
---
Description: In CapacityScheduler.allocate(), there is a call
{{getResourceCalculator()}} to get a value to pass as the resourceCalculator
parameter to {{getAllocation()}}, but the parameter is unuse in the method. So
I remove the parameter.
> FiCaSchedulerApp.getAllocation() have a unuse parameter
> ---
>
> Key: YARN-7255
> URL: https://issues.apache.org/jira/browse/YARN-7255
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Minor
>
> In CapacityScheduler.allocate(), there is a call {{getResourceCalculator()}}
> to get a value to pass as the resourceCalculator parameter to
> {{getAllocation()}}, but the parameter is unuse in the method. So I remove
> the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7255) FiCaSchedulerApp.getAllocation() have a unuse parameter
[
https://issues.apache.org/jira/browse/YARN-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-7255:
---
Attachment: YARN-7255.001.patch
> FiCaSchedulerApp.getAllocation() have a unuse parameter
> ---
>
> Key: YARN-7255
> URL: https://issues.apache.org/jira/browse/YARN-7255
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Minor
> Attachments: YARN-7255.001.patch
>
>
> In CapacityScheduler.allocate(), there is a call {{getResourceCalculator()}}
> to get a value to pass as the resourceCalculator parameter to
> {{getAllocation()}}, but the parameter is unuse in the method. So I remove
> the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
[
https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178861#comment-16178861
]
Sen Zhao commented on YARN-7001:
HI, [~miklos.szeg...@cloudera.com]. Could you give me some advices about latest
patch?
> If shared cache upload is terminated in the middle, the temp file will never
> be deleted
> ---
>
> Key: YARN-7001
> URL: https://issues.apache.org/jira/browse/YARN-7001
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Sen Zhao
> Attachments: YARN-7001.001.patch, YARN-7001.002.patch,
> YARN-7001.003.patch, YARN-7001.004.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
> tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
> if (!uploadFile(actualPath, tempPath)) {
> LOG.warn("Could not copy the file to the shared cache at " +
> tempPath);
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152297#comment-16152297 ] Sen Zhao commented on YARN-7153: Submit patch001! > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl.java duplicate that in > AMRMClientAsync.java. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
Sen Zhao created YARN-7153: -- Summary: Remove duplicated code in AMRMClientAsyncImpl.java Key: YARN-7153 URL: https://issues.apache.org/jira/browse/YARN-7153 Project: Hadoop YARN Issue Type: Bug Reporter: Sen Zhao -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7153: --- Description: I notice that there are some duplicated codes in YARN-7153.001.patch (was: I notice that there are some duplicated codes in ) > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice that there are some duplicated codes in YARN-7153.001.patch -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7153: --- Description: I notice that there are some duplicated codes in > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice that there are some duplicated codes in -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7153) Remove duplicated code in AMRMClientAsyncImpl.java
[ https://issues.apache.org/jira/browse/YARN-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7153: --- Description: I notice there are some codes in AMRMClientAsyncImpl.java duplicate that in AMRMClientAsync.java. Submit a patch to fix it! (was: I notice that there are some duplicated codes in YARN-7153.001.patch ) > Remove duplicated code in AMRMClientAsyncImpl.java > -- > > Key: YARN-7153 > URL: https://issues.apache.org/jira/browse/YARN-7153 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 3.0.0-alpha4 >Reporter: Sen Zhao > Attachments: YARN-7153.001.patch > > > I notice there are some codes in AMRMClientAsyncImpl.java duplicate that in > AMRMClientAsync.java. Submit a patch to fix it! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7357) Several methods in TestZKRMStateStore.TestZKRMStateStoreTester.TestZKRMStateStoreInternal should have @Override annotations
[ https://issues.apache.org/jira/browse/YARN-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216180#comment-16216180 ] Sen Zhao commented on YARN-7357: Thanks for your review, [~templedf]. > Several methods in > TestZKRMStateStore.TestZKRMStateStoreTester.TestZKRMStateStoreInternal should > have @Override annotations > --- > > Key: YARN-7357 > URL: https://issues.apache.org/jira/browse/YARN-7357 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 3.0.0-beta1 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie, ready-to-commit > Fix For: 2.9.0, 3.1.0, 3.0 > > Attachments: YARN-7357.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7357) Several methods in TestZKRMStateStore.TestZKRMStateStoreTester.TestZKRMStateStoreInternal should have @Override annotations
[ https://issues.apache.org/jira/browse/YARN-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-7357: --- Attachment: YARN-7357.001.patch HI, [~templedf]. I submit a patch to fix it. Please review it. Thanks > Several methods in > TestZKRMStateStore.TestZKRMStateStoreTester.TestZKRMStateStoreInternal should > have @Override annotations > --- > > Key: YARN-7357 > URL: https://issues.apache.org/jira/browse/YARN-7357 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 3.0.0-beta1 >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > Attachments: YARN-7357.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7357) Several methods in TestZKRMStateStore.TestZKRMStateStoreTester.TestZKRMStateStoreInternal should have @Override annotations
[ https://issues.apache.org/jira/browse/YARN-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-7357: -- Assignee: Sen Zhao > Several methods in > TestZKRMStateStore.TestZKRMStateStoreTester.TestZKRMStateStoreInternal should > have @Override annotations > --- > > Key: YARN-7357 > URL: https://issues.apache.org/jira/browse/YARN-7357 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 3.0.0-beta1 >Reporter: Daniel Templeton >Assignee: Sen Zhao >Priority: Trivial > Labels: newbie > Attachments: YARN-7357.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-8604) Modify WebApps.Builder#at to parse IPv6 address
Sen Zhao created YARN-8604: -- Summary: Modify WebApps.Builder#at to parse IPv6 address Key: YARN-8604 URL: https://issues.apache.org/jira/browse/YARN-8604 Project: Hadoop YARN Issue Type: Improvement Reporter: Sen Zhao Assignee: Sen Zhao -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8604) Modify WebApps.Builder#at to parse IPv6 address
[ https://issues.apache.org/jira/browse/YARN-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8604: --- Description: If the bindAddress is an IPv6 address, the port number will not be returned correctly. It should consider parsing IPv4 and IPv6 addresses。 > Modify WebApps.Builder#at to parse IPv6 address > -- > > Key: YARN-8604 > URL: https://issues.apache.org/jira/browse/YARN-8604 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Minor > Labels: IPv6 > > If the bindAddress is an IPv6 address, the port number will not be returned > correctly. It should consider parsing IPv4 and IPv6 addresses。 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8604) Modify WebApps.Builder#at to parse IPv6 address
[ https://issues.apache.org/jira/browse/YARN-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8604: --- Attachment: YARN-8604.001.patch > Modify WebApps.Builder#at to parse IPv6 address > -- > > Key: YARN-8604 > URL: https://issues.apache.org/jira/browse/YARN-8604 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Minor > Labels: IPv6 > Attachments: YARN-8604.001.patch > > > If the bindAddress is an IPv6 address, the port number will not be returned > correctly. It should consider parsing IPv4 and IPv6 addresses。 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-8614) Some typos in YarnConfiguration
Sen Zhao created YARN-8614: -- Summary: Some typos in YarnConfiguration Key: YARN-8614 URL: https://issues.apache.org/jira/browse/YARN-8614 Project: Hadoop YARN Issue Type: Bug Reporter: Sen Zhao Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8613) Old RM UI shows wrong vcores total value
[
https://issues.apache.org/jira/browse/YARN-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566433#comment-16566433
]
Sen Zhao commented on YARN-8613:
Is it possible to use {{rs.getClusterResource().getVirtualCores()}} instead of
the corresponding total resource?
> Old RM UI shows wrong vcores total value
>
>
> Key: YARN-8613
> URL: https://issues.apache.org/jira/browse/YARN-8613
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Akhil PB
>Priority: Major
> Attachments: Screen Shot 2018-08-02 at 12.12.41 PM.png, Screen Shot
> 2018-08-02 at 12.16.53 PM.png
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8614) Some typos in YarnConfiguration
[ https://issues.apache.org/jira/browse/YARN-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8614: --- Attachment: YARN-8614.001.patch > Some typos in YarnConfiguration > --- > > Key: YARN-8614 > URL: https://issues.apache.org/jira/browse/YARN-8614 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sen Zhao >Priority: Minor > Attachments: YARN-8614.001.patch > > > Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-8614) Some typos in YarnConfiguration
[ https://issues.apache.org/jira/browse/YARN-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-8614: -- Assignee: Sen Zhao > Some typos in YarnConfiguration > --- > > Key: YARN-8614 > URL: https://issues.apache.org/jira/browse/YARN-8614 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Minor > Attachments: YARN-8614.001.patch > > > Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8614) Some typos in YarnConfiguration
[ https://issues.apache.org/jira/browse/YARN-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569861#comment-16569861 ] Sen Zhao commented on YARN-8614: No unit test is needed here. > Some typos in YarnConfiguration > --- > > Key: YARN-8614 > URL: https://issues.apache.org/jira/browse/YARN-8614 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Minor > Attachments: YARN-8614.001.patch > > > Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when a queue is configured only CPU and memory
[
https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-8662:
---
Component/s: fairscheduler
> Fair Scheduler stops scheduling when a queue is configured only CPU and memory
> --
>
> Key: YARN-8662
> URL: https://issues.apache.org/jira/browse/YARN-8662
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Major
> Attachments: NonResourceToSchedule.png, YARN-8662.001.patch
>
>
> Add a new resource type in resource-types.xml, eg: resource1.
> In Fair scheduler when queue's MaxResources is configured like:
> {code}4096 mb, 4 vcores{code}
> When submit a application which need resource like:
> {code} 1536 mb, 1 vcores, 10 resource1{code}
> The application will be pending. Because there is no resource1 in this queue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-8613) Old RM UI shows wrong vcores total value
[ https://issues.apache.org/jira/browse/YARN-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-8613: -- Assignee: (was: Sen Zhao) > Old RM UI shows wrong vcores total value > > > Key: YARN-8613 > URL: https://issues.apache.org/jira/browse/YARN-8613 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Akhil PB >Priority: Major > Attachments: Screen Shot 2018-08-02 at 12.12.41 PM.png, Screen Shot > 2018-08-02 at 12.16.53 PM.png, YARN-8613.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when the queue is configured only CPU and memory
[
https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-8662:
---
Description:
Add a new resource type in resource-types.xml, eg: resource1.
In fair scheduler when queue's MaxResources is configured like:
{code}4096 mb, 4 vcores{code}
When submit a application which need resource like:
{code} 1536 mb, 1 vcores, 10 resource1{code}
The application will be pending. Because there is no resource1 in this queue.
was:Add a new resource type in resource-types.xml.
> Fair Scheduler stops scheduling when the queue is configured only CPU and
> memory
>
>
> Key: YARN-8662
> URL: https://issues.apache.org/jira/browse/YARN-8662
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Sen Zhao
>Priority: Major
>
> Add a new resource type in resource-types.xml, eg: resource1.
> In fair scheduler when queue's MaxResources is configured like:
> {code}4096 mb, 4 vcores{code}
> When submit a application which need resource like:
> {code} 1536 mb, 1 vcores, 10 resource1{code}
> The application will be pending. Because there is no resource1 in this queue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when only memory and CPU were configured on maxResources
[ https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8662: --- Description: Add a new resource type in resource-types.xml. > Fair Scheduler stops scheduling when only memory and CPU were configured on > maxResources > > > Key: YARN-8662 > URL: https://issues.apache.org/jira/browse/YARN-8662 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sen Zhao >Priority: Major > > Add a new resource type in resource-types.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when the queue is configured only CPU and memory
[ https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8662: --- Summary: Fair Scheduler stops scheduling when the queue is configured only CPU and memory (was: Fair Scheduler stops scheduling when only memory and CPU were configured on maxResources) > Fair Scheduler stops scheduling when the queue is configured only CPU and > memory > > > Key: YARN-8662 > URL: https://issues.apache.org/jira/browse/YARN-8662 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sen Zhao >Priority: Major > > Add a new resource type in resource-types.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-8662) Fair Scheduler stops scheduling when only memory and CPU were configured on maxResources
Sen Zhao created YARN-8662: -- Summary: Fair Scheduler stops scheduling when only memory and CPU were configured on maxResources Key: YARN-8662 URL: https://issues.apache.org/jira/browse/YARN-8662 Project: Hadoop YARN Issue Type: Sub-task Reporter: Sen Zhao -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when a queue is configured only CPU and memory
[
https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-8662:
---
Summary: Fair Scheduler stops scheduling when a queue is configured only
CPU and memory (was: Fair Scheduler stops scheduling when the queue is
configured only CPU and memory)
> Fair Scheduler stops scheduling when a queue is configured only CPU and memory
> --
>
> Key: YARN-8662
> URL: https://issues.apache.org/jira/browse/YARN-8662
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Major
> Attachments: NonResourceToSchedule.png, YARN-8662.001.patch
>
>
> Add a new resource type in resource-types.xml, eg: resource1.
> In Fair scheduler when queue's MaxResources is configured like:
> {code}4096 mb, 4 vcores{code}
> When submit a application which need resource like:
> {code} 1536 mb, 1 vcores, 10 resource1{code}
> The application will be pending. Because there is no resource1 in this queue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-8662) Fair Scheduler stops scheduling when the queue is configured only CPU and memory
[
https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao reassigned YARN-8662:
--
Assignee: Sen Zhao
Attachment: YARN-8662.001.patch
> Fair Scheduler stops scheduling when the queue is configured only CPU and
> memory
>
>
> Key: YARN-8662
> URL: https://issues.apache.org/jira/browse/YARN-8662
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Major
> Attachments: NonResourceToSchedule.png, YARN-8662.001.patch
>
>
> Add a new resource type in resource-types.xml, eg: resource1.
> In fair scheduler when queue's MaxResources is configured like:
> {code}4096 mb, 4 vcores{code}
> When submit a application which need resource like:
> {code} 1536 mb, 1 vcores, 10 resource1{code}
> The application will be pending. Because there is no resource1 in this queue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when the queue is configured only CPU and memory
[
https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-8662:
---
Attachment: NonResourceToSchedule.png
> Fair Scheduler stops scheduling when the queue is configured only CPU and
> memory
>
>
> Key: YARN-8662
> URL: https://issues.apache.org/jira/browse/YARN-8662
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Sen Zhao
>Priority: Major
> Attachments: NonResourceToSchedule.png
>
>
> Add a new resource type in resource-types.xml, eg: resource1.
> In fair scheduler when queue's MaxResources is configured like:
> {code}4096 mb, 4 vcores{code}
> When submit a application which need resource like:
> {code} 1536 mb, 1 vcores, 10 resource1{code}
> The application will be pending. Because there is no resource1 in this queue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8614) Some typos in YarnConfiguration
[ https://issues.apache.org/jira/browse/YARN-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8614: --- Attachment: YARN-8614.002.patch > Some typos in YarnConfiguration > --- > > Key: YARN-8614 > URL: https://issues.apache.org/jira/browse/YARN-8614 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Trivial > Attachments: YARN-8614.001.patch, YARN-8614.002.patch > > > Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8614) Some typos in YarnConfiguration
[ https://issues.apache.org/jira/browse/YARN-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580617#comment-16580617 ] Sen Zhao commented on YARN-8614: Thanks [~cheersyang] for your comments. Patch 002 to fix it. > Some typos in YarnConfiguration > --- > > Key: YARN-8614 > URL: https://issues.apache.org/jira/browse/YARN-8614 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Trivial > Attachments: YARN-8614.001.patch, YARN-8614.002.patch > > > Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8614) Fix few annotation typos in YarnConfiguration
[ https://issues.apache.org/jira/browse/YARN-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580716#comment-16580716 ] Sen Zhao commented on YARN-8614: OK. Thanks for your review, [~cheersyang] > Fix few annotation typos in YarnConfiguration > - > > Key: YARN-8614 > URL: https://issues.apache.org/jira/browse/YARN-8614 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sen Zhao >Assignee: Sen Zhao >Priority: Trivial > Fix For: 3.2.0, 3.1.2 > > Attachments: YARN-8614.001.patch, YARN-8614.002.patch > > > Fix some typos in comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-8613) Old RM UI shows wrong vcores total value
[ https://issues.apache.org/jira/browse/YARN-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao reassigned YARN-8613: -- Assignee: Sen Zhao > Old RM UI shows wrong vcores total value > > > Key: YARN-8613 > URL: https://issues.apache.org/jira/browse/YARN-8613 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Akhil PB >Assignee: Sen Zhao >Priority: Major > Attachments: Screen Shot 2018-08-02 at 12.12.41 PM.png, Screen Shot > 2018-08-02 at 12.16.53 PM.png, YARN-8613.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8613) Old RM UI shows wrong vcores total value
[ https://issues.apache.org/jira/browse/YARN-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sen Zhao updated YARN-8613: --- Attachment: YARN-8613.001.patch > Old RM UI shows wrong vcores total value > > > Key: YARN-8613 > URL: https://issues.apache.org/jira/browse/YARN-8613 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Akhil PB >Priority: Major > Attachments: Screen Shot 2018-08-02 at 12.12.41 PM.png, Screen Shot > 2018-08-02 at 12.16.53 PM.png, YARN-8613.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8613) Old RM UI shows wrong vcores total value
[ https://issues.apache.org/jira/browse/YARN-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571316#comment-16571316 ] Sen Zhao commented on YARN-8613: Update a patch to fix this problem. > Old RM UI shows wrong vcores total value > > > Key: YARN-8613 > URL: https://issues.apache.org/jira/browse/YARN-8613 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Akhil PB >Assignee: Sen Zhao >Priority: Major > Attachments: Screen Shot 2018-08-02 at 12.12.41 PM.png, Screen Shot > 2018-08-02 at 12.16.53 PM.png, YARN-8613.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8662) Fair Scheduler stops scheduling when the queue is configured only CPU and memory
[
https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-8662:
---
Description:
Add a new resource type in resource-types.xml, eg: resource1.
In Fair scheduler when queue's MaxResources is configured like:
{code}4096 mb, 4 vcores{code}
When submit a application which need resource like:
{code} 1536 mb, 1 vcores, 10 resource1{code}
The application will be pending. Because there is no resource1 in this queue.
was:
Add a new resource type in resource-types.xml, eg: resource1.
In fair scheduler when queue's MaxResources is configured like:
{code}4096 mb, 4 vcores{code}
When submit a application which need resource like:
{code} 1536 mb, 1 vcores, 10 resource1{code}
The application will be pending. Because there is no resource1 in this queue.
> Fair Scheduler stops scheduling when the queue is configured only CPU and
> memory
>
>
> Key: YARN-8662
> URL: https://issues.apache.org/jira/browse/YARN-8662
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Sen Zhao
>Assignee: Sen Zhao
>Priority: Major
> Attachments: NonResourceToSchedule.png, YARN-8662.001.patch
>
>
> Add a new resource type in resource-types.xml, eg: resource1.
> In Fair scheduler when queue's MaxResources is configured like:
> {code}4096 mb, 4 vcores{code}
> When submit a application which need resource like:
> {code} 1536 mb, 1 vcores, 10 resource1{code}
> The application will be pending. Because there is no resource1 in this queue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Created] (YARN-8701) If the single parameter in Resources#createResourceWithSameValue is greater than Integer.MAX_VALUE, then the value of vcores will be -1
Sen Zhao created YARN-8701: -- Summary: If the single parameter in Resources#createResourceWithSameValue is greater than Integer.MAX_VALUE, then the value of vcores will be -1 Key: YARN-8701 URL: https://issues.apache.org/jira/browse/YARN-8701 Project: Hadoop YARN Issue Type: Bug Components: api Reporter: Sen Zhao -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-8701) If the single parameter in Resources#createResourceWithSameValue is greater than Integer.MAX_VALUE, then the value of vcores will be -1
[
https://issues.apache.org/jira/browse/YARN-8701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sen Zhao updated YARN-8701:
---
Description:
If I configure *MaxResources* in fair-scheduler.xml, like this:
{code}resource1=50{code}
In the queue, the *MaxResources* value will change to
{code}memory:CLUSTER_MEMORY, VCores:0,
resource1:50{code}
I think the value of VCores should be *CLUSTER_VCORES*.
> If the single parameter in Resources#createResourceWithSameValue is greater
> than Integer.MAX_VALUE, then the value of vcores will be -1
> ---
>
> Key: YARN-8701
> URL: https://issues.apache.org/jira/browse/YARN-8701
> Project: Hadoop YARN
> Issue Type: Bug
> Components: api
>Reporter: Sen Zhao
>Priority: Major
>
> If I configure *MaxResources* in fair-scheduler.xml, like this:
> {code}resource1=50{code}
> In the queue, the *MaxResources* value will change to
> {code}memory:CLUSTER_MEMORY, VCores:0,
> resource1:50{code}
> I think the value of VCores should be *CLUSTER_VCORES*.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
