[jira] [Updated] (YARN-10750) TestMetricsInvariantChecker.testManyRuns is broken since HADOOP-17524

2021-04-23 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10750: -- Description: HADOOP-17524 removed the metrics: LogFatal LogError LogWarn LogInfo

[jira] [Updated] (YARN-10750) TestMetricsInvariantChecker.testManyRuns is broken since HADOOP-17524

2021-04-23 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10750: -- Description: HADOOP-17524 removed the metrics: > TestMetricsInvariantChecker.testManyRuns is

[jira] [Updated] (YARN-10750) TestMetricsInvariantChecker.testManyRuns is broken since HADOOP-17524

2021-04-23 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10750: -- Attachment: YARN-10750.001.patch > TestMetricsInvariantChecker.testManyRuns is broken since

[jira] [Created] (YARN-10750) TestMetricsInvariantChecker.testManyRuns is broken since HADOOP-17524

2021-04-23 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10750: - Summary: TestMetricsInvariantChecker.testManyRuns is broken since HADOOP-17524 Key: YARN-10750 URL: https://issues.apache.org/jira/browse/YARN-10750 Project:

[jira] [Commented] (YARN-10746) RmWebApp add default-node-label-expression to the queue info

2021-04-23 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330380#comment-17330380 ] Gergely Pollak commented on YARN-10746: --- Test failure is unrelated, it fails without my patch as

[jira] [Updated] (YARN-10746) RmWebApp add default-node-label-expression to the queue info

2021-04-22 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10746: -- Attachment: YARN-10746.003.patch > RmWebApp add default-node-label-expression to the queue

[jira] [Updated] (YARN-10746) RmWebApp add default-node-label-expression to the queue info

2021-04-22 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10746: -- Attachment: YARN-10746.002.patch > RmWebApp add default-node-label-expression to the queue

[jira] [Commented] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-04-22 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329183#comment-17329183 ] Gergely Pollak commented on YARN-10654: --- [~pbacsko] thank you for the patch, LGTM+1 (Non-binding)

[jira] [Updated] (YARN-10746) RmWebApp add default-node-label-expression to the queue info

2021-04-21 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10746: -- Attachment: YARN-10746.001.patch > RmWebApp add default-node-label-expression to the queue

[jira] [Created] (YARN-10746) RmWebApp add default-node-label-expression to the queue info

2021-04-21 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10746: - Summary: RmWebApp add default-node-label-expression to the queue info Key: YARN-10746 URL: https://issues.apache.org/jira/browse/YARN-10746 Project: Hadoop YARN

[jira] [Commented] (YARN-10370) [Umbrella] Reduce the feature gap between FS Placement Rules and CS Queue Mapping rules

2021-04-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317319#comment-17317319 ] Gergely Pollak commented on YARN-10370: --- Resolved, moved the leftover to a followup umbrella, where

[jira] [Updated] (YARN-10586) Create a command line tool for converting from legacy CS mapping rule format

2021-04-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10586: -- Parent Issue: YARN-10729 (was: YARN-10370) > Create a command line tool for converting from

[jira] [Updated] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-04-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10654: -- Parent Issue: YARN-10729 (was: YARN-10370) > Dots '.' in CSMappingRule path variables should

[jira] [Updated] (YARN-10426) Cleanup CSMappingPlacementRule remaining minor issues

2021-04-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10426: -- Parent Issue: YARN-10729 (was: YARN-10370) > Cleanup CSMappingPlacementRule remaining minor

[jira] [Updated] (YARN-10414) Improve logging in CS placement rules to help debuggability

2021-04-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10414: -- Parent Issue: YARN-10729 (was: YARN-10370) > Improve logging in CS placement rules to help

[jira] [Created] (YARN-10729) CapacityScheduler placement rule improvements

2021-04-08 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10729: - Summary: CapacityScheduler placement rule improvements Key: YARN-10729 URL: https://issues.apache.org/jira/browse/YARN-10729 Project: Hadoop YARN Issue

[jira] [Resolved] (YARN-10370) [Umbrella] Reduce the feature gap between FS Placement Rules and CS Queue Mapping rules

2021-04-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak resolved YARN-10370. --- Resolution: Fixed > [Umbrella] Reduce the feature gap between FS Placement Rules and CS

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308012#comment-17308012 ] Gergely Pollak commented on YARN-10597: --- I checked and [~ahussein] was right, the configuration

[jira] [Updated] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10597: -- Attachment: YARN-10597.002.patch > CSMappingPlacementRule should not create new instance of

[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307805#comment-17307805 ] Gergely Pollak commented on YARN-10571: --- [~gandras] thank you for the update, patch 2 LGTM+1

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-22 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306175#comment-17306175 ] Gergely Pollak commented on YARN-10597: --- [~ahussein] thank you for the feedback, I'll take a look

[jira] [Updated] (YARN-10659) Improve CS MappingRule %secondary_group evaluation

2021-03-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10659: -- Attachment: YARN-10659.003.patch > Improve CS MappingRule %secondary_group evaluation >

[jira] [Commented] (YARN-10370) [Umbrella] Reduce the feature gap between FS Placement Rules and CS Queue Mapping rules

2021-03-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303767#comment-17303767 ] Gergely Pollak commented on YARN-10370: --- [~pbacsko] thank you for the advice, I agree we can close

[jira] [Updated] (YARN-10659) Improve CS MappingRule %secondary_group evaluation

2021-03-16 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10659: -- Attachment: YARN-10659.002.patch > Improve CS MappingRule %secondary_group evaluation >

[jira] [Comment Edited] (YARN-10571) Refactor dynamic queue handling logic

2021-03-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299260#comment-17299260 ] Gergely Pollak edited comment on YARN-10571 at 3/11/21, 3:16 AM: -

[jira] [Comment Edited] (YARN-10571) Refactor dynamic queue handling logic

2021-03-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299260#comment-17299260 ] Gergely Pollak edited comment on YARN-10571 at 3/11/21, 3:15 AM: - It's in

[jira] [Comment Edited] (YARN-10571) Refactor dynamic queue handling logic

2021-03-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299260#comment-17299260 ] Gergely Pollak edited comment on YARN-10571 at 3/11/21, 3:15 AM: - It's in

[jira] [Commented] (YARN-10571) Refactor dynamic queue handling logic

2021-03-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299260#comment-17299260 ] Gergely Pollak commented on YARN-10571: --- It's in the original code as well, but we can have a NPE

[jira] [Updated] (YARN-10659) Improve CS MappingRule %secondary_group evaluation

2021-03-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10659: -- Attachment: YARN-10659.001.patch > Improve CS MappingRule %secondary_group evaluation >

[jira] [Commented] (YARN-10679) Better logging of uncaught exceptions throughout SLS

2021-03-09 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298002#comment-17298002 ] Gergely Pollak commented on YARN-10679: --- [~snemeth] thank you for the patch, LGTM+1 (Non-binding)

[jira] [Commented] (YARN-10681) Fix assertion failure message in BaseSLSRunnerTest

2021-03-09 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298000#comment-17298000 ] Gergely Pollak commented on YARN-10681: --- [~snemeth] thank you for the patch LGTM+1(Non-binding) >

[jira] [Commented] (YARN-10678) Try blocks without catch blocks in SLS scheduler classes can swallow other exceptions

2021-03-09 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297999#comment-17297999 ] Gergely Pollak commented on YARN-10678: --- [~snemeth] thank you for the patch, LGTM+1 (Non-binding)

[jira] [Commented] (YARN-10676) Improve code quality in TestTimelineAuthenticationFilterForV1

2021-03-05 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296062#comment-17296062 ] Gergely Pollak commented on YARN-10676: --- [~snemeth] thank you for the patch, LGTM+1 (Non-binding)

[jira] [Assigned] (YARN-10659) Improve CS MappingRule %secondary_group evaluation

2021-03-01 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10659: - Assignee: Gergely Pollak > Improve CS MappingRule %secondary_group evaluation >

[jira] [Created] (YARN-10659) Improve CS MappingRule %secondary_group evaluation

2021-03-01 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10659: - Summary: Improve CS MappingRule %secondary_group evaluation Key: YARN-10659 URL: https://issues.apache.org/jira/browse/YARN-10659 Project: Hadoop YARN

[jira] [Assigned] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-03-01 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10654: - Assignee: Gergely Pollak > Dots '.' in CSMappingRule path variables should be replaced

[jira] [Commented] (YARN-10652) Capacity Scheduler fails to handle user weights for a user that has a "." (dot) in it

2021-02-26 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291614#comment-17291614 ] Gergely Pollak commented on YARN-10652: --- The problem here is the consistency. There are multiple

[jira] [Created] (YARN-10654) Dots '.' in CSMappingRule path variables should be replaced

2021-02-26 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10654: - Summary: Dots '.' in CSMappingRule path variables should be replaced Key: YARN-10654 URL: https://issues.apache.org/jira/browse/YARN-10654 Project: Hadoop YARN

[jira] [Commented] (YARN-10639) Queueinfo related capacity, should ajusted to weight mode.

2021-02-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290022#comment-17290022 ] Gergely Pollak commented on YARN-10639: --- While this fix fills the capacity field in the case of a

[jira] [Commented] (YARN-10623) Capacity scheduler should support refresh queue automatically by a thread policy.

2021-02-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290013#comment-17290013 ] Gergely Pollak commented on YARN-10623: --- [~zhuqi] thank you for the patch! I really like the idea

[jira] [Commented] (YARN-10632) Make maximum depth allowed configurable.

2021-02-19 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287256#comment-17287256 ] Gergely Pollak commented on YARN-10632: --- Also please note that this has an effect on the placement

[jira] [Updated] (YARN-10636) CS Auto Queue creation should reject submissions with empty path parts

2021-02-19 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10636: -- Attachment: YARN-10636.002.patch > CS Auto Queue creation should reject submissions with empty

[jira] [Commented] (YARN-10636) CS Auto Queue creation should reject submissions with empty path parts

2021-02-19 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287056#comment-17287056 ] Gergely Pollak commented on YARN-10636: --- Thank you for the feedbacks [~zhuqi] [~gandras] [~bteke] 

[jira] [Commented] (YARN-10414) Improve logging in CS placement rules to help debuggability

2021-02-19 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287000#comment-17287000 ] Gergely Pollak commented on YARN-10414: --- A message improvement suggestion was provided in:

[jira] [Assigned] (YARN-10636) CS Auto Queue creation should reject submissions with empty path parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10636: - Assignee: Gergely Pollak > CS Auto Queue creation should reject submissions with empty

[jira] [Created] (YARN-10636) CS Auto Queue creation should reject submissions with empty path parts

2021-02-18 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10636: - Summary: CS Auto Queue creation should reject submissions with empty path parts Key: YARN-10636 URL: https://issues.apache.org/jira/browse/YARN-10636 Project:

[jira] [Commented] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286816#comment-17286816 ] Gergely Pollak commented on YARN-10635: --- Reuploading to see if the yetus issue have been resolved.

[jira] [Updated] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10635: -- Attachment: YARN-10635.003.patch > CSMapping rule can return paths with empty parts >

[jira] [Commented] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286671#comment-17286671 ] Gergely Pollak commented on YARN-10635: --- Seems to be a YESTUS issue, reuploading to see if the

[jira] [Comment Edited] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286671#comment-17286671 ] Gergely Pollak edited comment on YARN-10635 at 2/18/21, 6:58 PM: - Seems

[jira] [Updated] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10635: -- Attachment: YARN-10635.002.patch > CSMapping rule can return paths with empty parts >

[jira] [Updated] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10635: -- Attachment: YARN-10635.001.patch > CSMapping rule can return paths with empty parts >

[jira] [Assigned] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10635: - Assignee: Gergely Pollak > CSMapping rule can return paths with empty parts >

[jira] [Created] (YARN-10635) CSMapping rule can return paths with empty parts

2021-02-18 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10635: - Summary: CSMapping rule can return paths with empty parts Key: YARN-10635 URL: https://issues.apache.org/jira/browse/YARN-10635 Project: Hadoop YARN Issue

[jira] [Commented] (YARN-10618) RM UI2 Application page shows the AM preempted containers instead of the nonAM ones

2021-02-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282642#comment-17282642 ] Gergely Pollak commented on YARN-10618: --- [~bteke] thank you for the patch it is quite

[jira] [Created] (YARN-10619) CS Mapping Rule %specified rule catches default submissions

2021-02-09 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10619: - Summary: CS Mapping Rule %specified rule catches default submissions Key: YARN-10619 URL: https://issues.apache.org/jira/browse/YARN-10619 Project: Hadoop YARN

[jira] [Comment Edited] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278453#comment-17278453 ] Gergely Pollak edited comment on YARN-10612 at 2/4/21, 1:25 AM: Trunk

[jira] [Comment Edited] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278453#comment-17278453 ] Gergely Pollak edited comment on YARN-10612 at 2/4/21, 1:18 AM: Trunk

[jira] [Commented] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278453#comment-17278453 ] Gergely Pollak commented on YARN-10612: --- Trunk compile shows the findbugs error, patch compile

[jira] [Commented] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278360#comment-17278360 ] Gergely Pollak commented on YARN-10585: --- [~ahussein] thank you for your suggestions. {code:java}

[jira] [Commented] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278354#comment-17278354 ] Gergely Pollak commented on YARN-10612: --- [~ahussein] I don't see how it will make anything better

[jira] [Assigned] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10612: - Assignee: Gergely Pollak > Fix find bugs issue introduced in YARN-10585 >

[jira] [Updated] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10612: -- Attachment: YARN-10612.001.patch > Fix find bugs issue introduced in YARN-10585 >

[jira] [Created] (YARN-10612) Fix find bugs issue introduced in YARN-10585

2021-02-03 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10612: - Summary: Fix find bugs issue introduced in YARN-10585 Key: YARN-10612 URL: https://issues.apache.org/jira/browse/YARN-10612 Project: Hadoop YARN Issue

[jira] [Commented] (YARN-10610) Add queuePath to restful api for CapacityScheduler consistent with FairScheduler queuePath.

2021-02-03 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277968#comment-17277968 ] Gergely Pollak commented on YARN-10610: --- [~zhuqi] thank  you for the patch! Nice change, when we

[jira] [Commented] (YARN-10604) Support auto queue creation without mapping rules

2021-02-01 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276351#comment-17276351 ] Gergely Pollak commented on YARN-10604: --- [~gandras]thank you for the patch, LGTM+1 (Non-binding) >

[jira] [Commented] (YARN-10605) Add queue-mappings-override.enable property in FS2CS conversions

2021-02-01 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276347#comment-17276347 ] Gergely Pollak commented on YARN-10605: --- [~gandras]Thank you for the patch! The only thing I've

[jira] [Commented] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-26 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272072#comment-17272072 ] Gergely Pollak commented on YARN-10585: --- Latest patch fixed [~gandras] "userGroupMappingRules and

[jira] [Updated] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-26 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10585: -- Attachment: YARN-10585.003.patch > Create a class which can convert from legacy mapping rule

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2021-01-25 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271331#comment-17271331 ] Gergely Pollak commented on YARN-10425: --- [~ahussein]Thank you for the feedback, I've created the

[jira] [Assigned] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-01-25 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10597: - Assignee: Gergely Pollak > CSMappingPlacementRule should not create new instance of

[jira] [Created] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-01-25 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10597: - Summary: CSMappingPlacementRule should not create new instance of Groups Key: YARN-10597 URL: https://issues.apache.org/jira/browse/YARN-10597 Project: Hadoop YARN

[jira] [Comment Edited] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-25 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271297#comment-17271297 ] Gergely Pollak edited comment on YARN-10585 at 1/25/21, 1:01 PM: -

[jira] [Commented] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-25 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271297#comment-17271297 ] Gergely Pollak commented on YARN-10585: --- [~gandras] thank you for the review and your comments, let

[jira] [Updated] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-21 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10585: -- Attachment: YARN-10585.002.patch > Create a class which can convert from legacy mapping rule

[jira] [Commented] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-21 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269316#comment-17269316 ] Gergely Pollak commented on YARN-10585: --- Fixed the unit test failures, improved the conversion of

[jira] [Created] (YARN-10586) Create a command line tool for converting from legacy CS mapping rule format

2021-01-20 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10586: - Summary: Create a command line tool for converting from legacy CS mapping rule format Key: YARN-10586 URL: https://issues.apache.org/jira/browse/YARN-10586

[jira] [Created] (YARN-10585) Create a class which can convert from legacy mapping rule format to the new JSON format

2021-01-20 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10585: - Summary: Create a class which can convert from legacy mapping rule format to the new JSON format Key: YARN-10585 URL: https://issues.apache.org/jira/browse/YARN-10585

[jira] [Created] (YARN-10584) Move the functionality of MappingRuleValidationHelper to CSQueueManager

2021-01-20 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10584: - Summary: Move the functionality of MappingRuleValidationHelper to CSQueueManager Key: YARN-10584 URL: https://issues.apache.org/jira/browse/YARN-10584 Project:

[jira] [Assigned] (YARN-10583) Increase the test coverage for validation in MappingRuleValidationHelper

2021-01-20 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10583: - Assignee: Gergely Pollak > Increase the test coverage for validation in

[jira] [Created] (YARN-10583) Increase the test coverage for validation in MappingRuleValidationHelper

2021-01-20 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10583: - Summary: Increase the test coverage for validation in MappingRuleValidationHelper Key: YARN-10583 URL: https://issues.apache.org/jira/browse/YARN-10583 Project:

[jira] [Created] (YARN-10582) Increase the test coverage for CSMappingPlacementRule

2021-01-20 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10582: - Summary: Increase the test coverage for CSMappingPlacementRule Key: YARN-10582 URL: https://issues.apache.org/jira/browse/YARN-10582 Project: Hadoop YARN

[jira] [Commented] (YARN-10578) Fix Auto Queue Creation parent handling

2021-01-19 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267869#comment-17267869 ] Gergely Pollak commented on YARN-10578: --- [~gandras] thank you for the patch, my only observation is

[jira] [Updated] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-18 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10535: -- Attachment: YARN-10535.006.patch > Make queue placement in CapacityScheduler compliant with

[jira] [Commented] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266941#comment-17266941 ] Gergely Pollak commented on YARN-10535: --- [~snemeth] thank you for the review, a good portion of

[jira] [Commented] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266771#comment-17266771 ] Gergely Pollak commented on YARN-10535: --- Patchset#5 fixes the new checkstyle/findbugs/javadoc

[jira] [Comment Edited] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266771#comment-17266771 ] Gergely Pollak edited comment on YARN-10535 at 1/17/21, 12:41 PM: --

[jira] [Updated] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10535: -- Attachment: YARN-10535.005.patch > Make queue placement in CapacityScheduler compliant with

[jira] [Commented] (YARN-10574) Fix the FindBugs warning introduced in YARN-10506

2021-01-17 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266769#comment-17266769 ] Gergely Pollak commented on YARN-10574: --- Test failure is unrelated, test seems to be flaky. Test

[jira] [Commented] (YARN-10574) Fix the FindBugs warning introduced in YARN-10506

2021-01-16 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266687#comment-17266687 ] Gergely Pollak commented on YARN-10574: --- I've just removed the null check, because the previous

[jira] [Commented] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-16 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266686#comment-17266686 ] Gergely Pollak commented on YARN-10535: --- Patchset 4 is supposed to fix all findbugs and checkstyle

[jira] [Updated] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-16 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10535: -- Attachment: YARN-10535.004.patch > Make queue placement in CapacityScheduler compliant with

[jira] [Assigned] (YARN-10574) Fix the FindBugs warning introduced in YARN-10506

2021-01-16 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak reassigned YARN-10574: - Assignee: Gergely Pollak > Fix the FindBugs warning introduced in YARN-10506 >

[jira] [Created] (YARN-10574) Fix the FindBugs warning introduced in YARN-10506

2021-01-16 Thread Gergely Pollak (Jira)
Gergely Pollak created YARN-10574: - Summary: Fix the FindBugs warning introduced in YARN-10506 Key: YARN-10574 URL: https://issues.apache.org/jira/browse/YARN-10574 Project: Hadoop YARN

[jira] [Commented] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266413#comment-17266413 ] Gergely Pollak commented on YARN-10535: --- Dependency merged patchset 3 is a reupload to retrigger

[jira] [Updated] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10535: -- Attachment: YARN-10535.003.patch > Make queue placement in CapacityScheduler compliant with

[jira] [Commented] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266139#comment-17266139 ] Gergely Pollak commented on YARN-10535: --- [~pbacsko] [~gandras] Thank you for the review, I fixed

[jira] [Updated] (YARN-10535) Make queue placement in CapacityScheduler compliant with auto-queue-placement

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gergely Pollak updated YARN-10535: -- Attachment: YARN-10535.002.patch > Make queue placement in CapacityScheduler compliant with

[jira] [Comment Edited] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266081#comment-17266081 ] Gergely Pollak edited comment on YARN-10506 at 1/15/21, 2:46 PM: - Thank

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266081#comment-17266081 ] Gergely Pollak commented on YARN-10506: --- Thank you [~gandras] for the fix, here are a few comments,

  1   2   3   4   >