[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116141#comment-16116141
]
Wenxin He commented on YARN-6873:
-
Verified +1:
I added {{EWMA}} to {{log4j.rootLogger}} in
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113991#comment-16113991
]
Wenxin He commented on YARN-6873:
-
[~Cyl], since HADOOP-14706 is commited, would you use the helper method
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108458#comment-16108458
]
Wenxin He commented on YARN-6873:
-
Is it a good idea to add a helper method in hadoop-common to determine
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107298#comment-16107298
]
Wenxin He commented on YARN-6873:
-
Looks good to me!
> Moving logging APIs over to slf4j in
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106792#comment-16106792
]
Wenxin He commented on YARN-6873:
-
Mostly looks good to me, except some minor nits:
# checkstyle