[jira] [Updated] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-7135:
--
Attachment: YARN-7135.004.patch
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
> Attachments: YARN-7135.001.patch, YARN-7135.002.patch,
> YARN-7135.003.patch, YARN-7135.004.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-7135:
--
Attachment: YARN-7135.003.patch
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
> Attachments: YARN-7135.001.patch, YARN-7135.002.patch,
> YARN-7135.003.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Issue Comment Deleted] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-7135:
--
Comment: was deleted
(was: [~templedf], thanks for your suggestion, I updated the patch again. )
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
> Attachments: YARN-7135.001.patch, YARN-7135.002.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171994#comment-16171994
]
weiyuan commented on YARN-7135:
---
[~templedf], thanks for your suggestion, I updated the patch again.
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
> Attachments: YARN-7135.001.patch, YARN-7135.002.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-7135:
--
Attachment: YARN-7135.002.patch
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
> Attachments: YARN-7135.001.patch, YARN-7135.002.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6799) Remove the duplicated code in CGroupsHandlerImp.java
[
https://issues.apache.org/jira/browse/YARN-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160798#comment-16160798
]
weiyuan commented on YARN-6799:
---
[~yufeigu], thanks for your help!
> Remove the duplicated code in CGroupsHandlerImp.java
>
>
> Key: YARN-6799
> URL: https://issues.apache.org/jira/browse/YARN-6799
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 3.0.0-alpha3
>Reporter: Yufei Gu
>Assignee: weiyuan
>Priority: Trivial
> Fix For: 2.9.0, 3.0.0-beta1
>
> Attachments: YARN-6799.001.patch, YARN-6799.002.patch
>
>
> The else clause in initializeCGroupController is not necessary.
> {code}
> public void initializeCGroupController(CGroupController controller) throws
> ResourceHandlerException {
> if (enableCGroupMount) {
> // We have a controller that needs to be mounted
> mountCGroupController(controller);
> } else {
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> }
> // We are working with a pre-mounted contoller
> // Make sure that Yarn cgroup hierarchy path exists
> initializePreMountedCGroupController(controller);
> }
> private void initializePreMountedCGroupController(CGroupController
> controller)
> throws ResourceHandlerException {
> // Check permissions to cgroup hierarchy and
> // create YARN cgroup if it does not exist, yet
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6799) Remove the duplicated code in CGroupsHandlerImp.java
[
https://issues.apache.org/jira/browse/YARN-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-6799:
--
Attachment: YARN-6799.002.patch
> Remove the duplicated code in CGroupsHandlerImp.java
>
>
> Key: YARN-6799
> URL: https://issues.apache.org/jira/browse/YARN-6799
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 3.0.0-alpha3
>Reporter: Yufei Gu
>Assignee: weiyuan
>Priority: Trivial
> Attachments: YARN-6799.001.patch, YARN-6799.002.patch
>
>
> The else clause in initializeCGroupController is not necessary.
> {code}
> public void initializeCGroupController(CGroupController controller) throws
> ResourceHandlerException {
> if (enableCGroupMount) {
> // We have a controller that needs to be mounted
> mountCGroupController(controller);
> } else {
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> }
> // We are working with a pre-mounted contoller
> // Make sure that Yarn cgroup hierarchy path exists
> initializePreMountedCGroupController(controller);
> }
> private void initializePreMountedCGroupController(CGroupController
> controller)
> throws ResourceHandlerException {
> // Check permissions to cgroup hierarchy and
> // create YARN cgroup if it does not exist, yet
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6799) Remove the duplicated code in CGroupsHandlerImp.java
[
https://issues.apache.org/jira/browse/YARN-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157128#comment-16157128
]
weiyuan commented on YARN-6799:
---
This patch is uploaded. [~yufeigu], do you have anything else to add? Thanks!
> Remove the duplicated code in CGroupsHandlerImp.java
>
>
> Key: YARN-6799
> URL: https://issues.apache.org/jira/browse/YARN-6799
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 3.0.0-alpha3
>Reporter: Yufei Gu
>Assignee: weiyuan
>Priority: Trivial
> Attachments: YARN-6799.001.patch
>
>
> The else clause in initializeCGroupController is not necessary.
> {code}
> public void initializeCGroupController(CGroupController controller) throws
> ResourceHandlerException {
> if (enableCGroupMount) {
> // We have a controller that needs to be mounted
> mountCGroupController(controller);
> } else {
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> }
> // We are working with a pre-mounted contoller
> // Make sure that Yarn cgroup hierarchy path exists
> initializePreMountedCGroupController(controller);
> }
> private void initializePreMountedCGroupController(CGroupController
> controller)
> throws ResourceHandlerException {
> // Check permissions to cgroup hierarchy and
> // create YARN cgroup if it does not exist, yet
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6799) Remove the duplicated code in CGroupsHandlerImp.java
[
https://issues.apache.org/jira/browse/YARN-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-6799:
--
Attachment: YARN-6799.001.patch
> Remove the duplicated code in CGroupsHandlerImp.java
>
>
> Key: YARN-6799
> URL: https://issues.apache.org/jira/browse/YARN-6799
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 3.0.0-alpha3
>Reporter: Yufei Gu
>Assignee: weiyuan
>Priority: Trivial
> Attachments: YARN-6799.001.patch
>
>
> The else clause in initializeCGroupController is not necessary.
> {code}
> public void initializeCGroupController(CGroupController controller) throws
> ResourceHandlerException {
> if (enableCGroupMount) {
> // We have a controller that needs to be mounted
> mountCGroupController(controller);
> } else {
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> }
> // We are working with a pre-mounted contoller
> // Make sure that Yarn cgroup hierarchy path exists
> initializePreMountedCGroupController(controller);
> }
> private void initializePreMountedCGroupController(CGroupController
> controller)
> throws ResourceHandlerException {
> // Check permissions to cgroup hierarchy and
> // create YARN cgroup if it does not exist, yet
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-7135:
--
Attachment: YARN-7135.001.patch
clean up lock-try order
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
> Attachments: YARN-7135.001.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan reassigned YARN-7135:
-
Assignee: weiyuan
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
> Labels: newbie
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7135) Clean up lock-try order in common scheduler code
[
https://issues.apache.org/jira/browse/YARN-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148591#comment-16148591
]
weiyuan commented on YARN-7135:
---
Hi, [~templedf], thanks for filling this form. I would like to try this issue,
so I assigned it to me directly.
> Clean up lock-try order in common scheduler code
>
>
> Key: YARN-7135
> URL: https://issues.apache.org/jira/browse/YARN-7135
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
> Labels: newbie
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6799) Remove the duplicated code in CGroupsHandlerImp.java
[
https://issues.apache.org/jira/browse/YARN-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142853#comment-16142853
]
weiyuan commented on YARN-6799:
---
Hi, [~yufeigu], thanks for filling this form. I would like to try this issue,
so I assigned it to me directly.
> Remove the duplicated code in CGroupsHandlerImp.java
>
>
> Key: YARN-6799
> URL: https://issues.apache.org/jira/browse/YARN-6799
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 3.0.0-alpha3
>Reporter: Yufei Gu
>Priority: Trivial
>
> The else clause in initializeCGroupController is not necessary.
> {code}
> public void initializeCGroupController(CGroupController controller) throws
> ResourceHandlerException {
> if (enableCGroupMount) {
> // We have a controller that needs to be mounted
> mountCGroupController(controller);
> } else {
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> }
> // We are working with a pre-mounted contoller
> // Make sure that Yarn cgroup hierarchy path exists
> initializePreMountedCGroupController(controller);
> }
> private void initializePreMountedCGroupController(CGroupController
> controller)
> throws ResourceHandlerException {
> // Check permissions to cgroup hierarchy and
> // create YARN cgroup if it does not exist, yet
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-6799) Remove the duplicated code in CGroupsHandlerImp.java
[
https://issues.apache.org/jira/browse/YARN-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan reassigned YARN-6799:
-
Assignee: weiyuan
> Remove the duplicated code in CGroupsHandlerImp.java
>
>
> Key: YARN-6799
> URL: https://issues.apache.org/jira/browse/YARN-6799
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 3.0.0-alpha3
>Reporter: Yufei Gu
>Assignee: weiyuan
>Priority: Trivial
>
> The else clause in initializeCGroupController is not necessary.
> {code}
> public void initializeCGroupController(CGroupController controller) throws
> ResourceHandlerException {
> if (enableCGroupMount) {
> // We have a controller that needs to be mounted
> mountCGroupController(controller);
> } else {
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> }
> // We are working with a pre-mounted contoller
> // Make sure that Yarn cgroup hierarchy path exists
> initializePreMountedCGroupController(controller);
> }
> private void initializePreMountedCGroupController(CGroupController
> controller)
> throws ResourceHandlerException {
> // Check permissions to cgroup hierarchy and
> // create YARN cgroup if it does not exist, yet
> String controllerPath = getControllerPath(controller);
> if (controllerPath == null) {
> throw new ResourceHandlerException(
> String.format("Controller %s not mounted."
> + " You either need to mount it with %s"
> + " or mount cgroups before launching Yarn",
> controller.getName(), YarnConfiguration.
> NM_LINUX_CONTAINER_CGROUPS_MOUNT));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6780) ResourceWeights.toString() cleanup
[
https://issues.apache.org/jira/browse/YARN-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127381#comment-16127381
]
weiyuan commented on YARN-6780:
---
[~templedf], the patch is updated again, thanks for your reminder.
> ResourceWeights.toString() cleanup
> --
>
> Key: YARN-6780
> URL: https://issues.apache.org/jira/browse/YARN-6780
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 2.8.1, 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
>Priority: Minor
> Labels: newbie
> Attachments: YARN-6780.001.patch, YARN-6780.002.patch
>
>
> The {{toString()}} method should have {{@Override}} and should use a
> {{StringBuilder}} instead of a {{StringBuffer}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6780) ResourceWeights.toString() cleanup
[
https://issues.apache.org/jira/browse/YARN-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-6780:
--
Attachment: YARN-6780.002.patch
> ResourceWeights.toString() cleanup
> --
>
> Key: YARN-6780
> URL: https://issues.apache.org/jira/browse/YARN-6780
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 2.8.1, 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
>Priority: Minor
> Labels: newbie
> Attachments: YARN-6780.001.patch, YARN-6780.002.patch
>
>
> The {{toString()}} method should have {{@Override}} and should use a
> {{StringBuilder}} instead of a {{StringBuffer}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6780) ResourceWeights.toString() cleanup
[
https://issues.apache.org/jira/browse/YARN-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-6780:
--
Attachment: YARN-6780.001.patch
> ResourceWeights.toString() cleanup
> --
>
> Key: YARN-6780
> URL: https://issues.apache.org/jira/browse/YARN-6780
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 2.8.1, 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
>Priority: Minor
> Labels: newbie
> Attachments: YARN-6780.001.patch
>
>
> The {{toString()}} method should have {{@Overrides}} and should use a
> {{StringBuilder}} instead of a {{StringBuffer}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-6780) ResourceWeights.toString() cleanup
[
https://issues.apache.org/jira/browse/YARN-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan reassigned YARN-6780:
-
Assignee: weiyuan
> ResourceWeights.toString() cleanup
> --
>
> Key: YARN-6780
> URL: https://issues.apache.org/jira/browse/YARN-6780
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 2.8.1, 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
>Priority: Minor
> Labels: newbie
>
> The {{toString()}} method should have {{@Overrides}} and should use a
> {{StringBuilder}} instead of a {{StringBuffer}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-6780) ResourceWeights.toString() cleanup
[
https://issues.apache.org/jira/browse/YARN-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124846#comment-16124846
]
weiyuan edited comment on YARN-6780 at 8/13/17 8:08 AM:
hi, Daniel, thanks for filling this form. I would like to try this issue, so I
assigned it to me.
was (Author: v123582):
hi, Daniel, thanks for filling this form. I would like to try this issue.
> ResourceWeights.toString() cleanup
> --
>
> Key: YARN-6780
> URL: https://issues.apache.org/jira/browse/YARN-6780
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 2.8.1, 3.0.0-alpha4
>Reporter: Daniel Templeton
>Priority: Minor
> Labels: newbie
>
> The {{toString()}} method should have {{@Overrides}} and should use a
> {{StringBuilder}} instead of a {{StringBuffer}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6780) ResourceWeights.toString() cleanup
[
https://issues.apache.org/jira/browse/YARN-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124846#comment-16124846
]
weiyuan commented on YARN-6780:
---
hi, Daniel, thanks for filling this form. I would like to try this issue.
> ResourceWeights.toString() cleanup
> --
>
> Key: YARN-6780
> URL: https://issues.apache.org/jira/browse/YARN-6780
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
>Affects Versions: 2.8.1, 3.0.0-alpha4
>Reporter: Daniel Templeton
>Priority: Minor
> Labels: newbie
>
> The {{toString()}} method should have {{@Overrides}} and should use a
> {{StringBuilder}} instead of a {{StringBuffer}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weiyuan updated YARN-6881: -- Attachment: YARN-6881.002.patch > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch, YARN-6881.002.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124844#comment-16124844 ] weiyuan edited comment on YARN-6881 at 8/13/17 7:55 AM: [~templedf], thanks for your reminder. I update the patch and upload again. was (Author: v123582): [~templedf], thanks for your reminder. I update the patch and upload agian. > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch, YARN-6881.002.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124844#comment-16124844 ] weiyuan commented on YARN-6881: --- [~templedf], thanks for your reminder. I update the patch and upload agian. > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6884) AllocationFileLoaderService.loadQueue() has an if without braces
[
https://issues.apache.org/jira/browse/YARN-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan updated YARN-6884:
--
Attachment: YARN-6884.001.patch
add braces to if block without braces in AllocationFileLoaderService.loadQueue()
> AllocationFileLoaderService.loadQueue() has an if without braces
>
>
> Key: YARN-6884
> URL: https://issues.apache.org/jira/browse/YARN-6884
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
>Priority: Trivial
> Labels: newbie
> Attachments: YARN-6884.001.patch
>
>
> {code} if (!(fieldNode instanceof Element))
> continue;{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Assigned] (YARN-6884) AllocationFileLoaderService.loadQueue() has an if without braces
[
https://issues.apache.org/jira/browse/YARN-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weiyuan reassigned YARN-6884:
-
Assignee: weiyuan
> AllocationFileLoaderService.loadQueue() has an if without braces
>
>
> Key: YARN-6884
> URL: https://issues.apache.org/jira/browse/YARN-6884
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: weiyuan
>Priority: Trivial
> Labels: newbie
>
> {code} if (!(fieldNode instanceof Element))
> continue;{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6884) AllocationFileLoaderService.loadQueue() has an if without braces
[
https://issues.apache.org/jira/browse/YARN-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123655#comment-16123655
]
weiyuan commented on YARN-6884:
---
hi Daniel, thanks for filling this form. I would like to try this issue.
> AllocationFileLoaderService.loadQueue() has an if without braces
>
>
> Key: YARN-6884
> URL: https://issues.apache.org/jira/browse/YARN-6884
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Priority: Trivial
> Labels: newbie
>
> {code} if (!(fieldNode instanceof Element))
> continue;{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120929#comment-16120929 ] weiyuan edited comment on YARN-6881 at 8/10/17 1:50 AM: [~templedf] The patch is attached and submitted. Please review it. I think the unit test failures are unrelated to this change. Thank you! was (Author: v123582): [~templedf] The patch is attached and submitted. Please review it. I think the unit test failures are unrelated to this change. Thank you! > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120929#comment-16120929 ] weiyuan edited comment on YARN-6881 at 8/10/17 1:49 AM: [~templedf] The patch is attached and submitted. Please review it. I think the unit test failures are unrelated to this change. Thank you! was (Author: v123582): [~templedf] The patch is attached and submitted. Please review it. I think the unit test failures are unrelated to this change. > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120929#comment-16120929 ] weiyuan commented on YARN-6881: --- [~templedf] The patch is attached and submitted. Please review it. I think the unit test failures are unrelated to this change. > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weiyuan updated YARN-6881: -- Attachment: YARN-6881.001.patch > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weiyuan updated YARN-6881: -- Attachment: (was: YARN-6881.001.patch) > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weiyuan updated YARN-6881: -- Attachment: YARN-6881.001.patch > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton >Assignee: weiyuan > Labels: newbie > Attachments: YARN-6881.001.patch > > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119644#comment-16119644 ] weiyuan commented on YARN-6881: --- Hi Daniel, I would try this issue, could you help for assigning to me. Thanks. (I mistakenly deleted former message.) > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton > Labels: newbie > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Issue Comment Deleted] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weiyuan updated YARN-6881: -- Comment: was deleted (was: Hi [~templedf], I would try this issue, could you help for assigning to me. Thanks. ) > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton > Labels: newbie > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115846#comment-16115846 ] weiyuan edited comment on YARN-6881 at 8/9/17 9:47 AM: --- Hi [~templedf], I would try this issue, could you help for assigning to me. Thanks. was (Author: v123582): Hi [~templedf], I can try this issue, but I am a newbie to upload patch to this issue without permissions. Can you help for assigning to me. Thanks. > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton > Labels: newbie > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6881) LOG is unused in AllocationConfiguration
[ https://issues.apache.org/jira/browse/YARN-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115846#comment-16115846 ] weiyuan commented on YARN-6881: --- Hi [~templedf], I can try this issue, but I am a newbie to upload patch to this issue without permissions. Can you help for assigning to me. Thanks. > LOG is unused in AllocationConfiguration > > > Key: YARN-6881 > URL: https://issues.apache.org/jira/browse/YARN-6881 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.0.0-alpha4 >Reporter: Daniel Templeton > Labels: newbie > > The variable can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
