[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388420#comment-14388420
]
Hudson commented on YARN-2495:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #149 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388440#comment-14388440
]
Hudson commented on YARN-2495:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #883 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388634#comment-14388634
]
Hudson commented on YARN-2495:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #140 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388611#comment-14388611
]
Hudson commented on YARN-2495:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2081 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389155#comment-14389155
]
Hudson commented on YARN-2495:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2099 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389086#comment-14389086
]
Hudson commented on YARN-2495:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #149 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387240#comment-14387240
]
Hudson commented on YARN-2495:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7467 (See
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384972#comment-14384972
]
Wangda Tan commented on YARN-2495:
--
Last call for comments, I'm planning to commit this by
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382299#comment-14382299
]
Jian Fang commented on YARN-2495:
-
In a cloud environment such as Amazon EMR, a hadoop
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382506#comment-14382506
]
Allen Wittenauer commented on YARN-2495:
That's effectively what the executable
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382555#comment-14382555
]
Jian Fang commented on YARN-2495:
-
Great, thanks. Will try them.
Allow admin specify
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382389#comment-14382389
]
Wangda Tan commented on YARN-2495:
--
Hi [~john.jian.fang],
Thanks for your comments,
I'm
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382388#comment-14382388
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~john.jian.fang],
Well this jira is
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382496#comment-14382496
]
Jian Fang commented on YARN-2495:
-
On each EC2 instance, the metadata about that instance
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382501#comment-14382501
]
Jian Fang commented on YARN-2495:
-
BTW, I haven't gone through all the details of YARN-2492
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382542#comment-14382542
]
Wangda Tan commented on YARN-2495:
--
bq. is it possible to provide a configuration to hook
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378203#comment-14378203
]
Wangda Tan commented on YARN-2495:
--
Thanks for update. Patch LGTM, +1. will wait and
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377356#comment-14377356
]
Hadoop QA commented on YARN-2495:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376605#comment-14376605
]
Wangda Tan commented on YARN-2495:
--
Hmm.. {{StringArrayProto.stringElement - elements}} is
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377252#comment-14377252
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~leftnoteasy],
Oops mistake from my
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372917#comment-14372917
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~leftnoteasy] following test case
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372280#comment-14372280
]
Wangda Tan commented on YARN-2495:
--
2) You decide. :)
5)/7) You're correct, provider
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372524#comment-14372524
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371830#comment-14371830
]
Naganarasimha G R commented on YARN-2495:
-
Thanks for review [~wangda] :
1)
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370333#comment-14370333
]
Wangda Tan commented on YARN-2495:
--
Go through patch again, hopefully this is last round
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370386#comment-14370386
]
Hadoop QA commented on YARN-2495:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369909#comment-14369909
]
Wangda Tan commented on YARN-2495:
--
Hi [~Naganarasimha],
For 1)
I suggest to use a
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370056#comment-14370056
]
Wangda Tan commented on YARN-2495:
--
ResourceTrackerForLabels.labels - lastReceivedLabels
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366562#comment-14366562
]
Naganarasimha G R commented on YARN-2495:
-
1. Well i think i am missing something
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366312#comment-14366312
]
Wangda Tan commented on YARN-2495:
--
Thanks for updating.
1. I saw you're trying to make
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366236#comment-14366236
]
Hadoop QA commented on YARN-2495:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357928#comment-14357928
]
Naganarasimha G R commented on YARN-2495:
-
bq. It's just that I don't like this
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357852#comment-14357852
]
Vinod Kumar Vavilapalli commented on YARN-2495:
---
bq. Well as craig informed,
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358109#comment-14358109
]
Wangda Tan commented on YARN-2495:
--
Hi [~Naganarasimha],
For areNodeLabelsSetInReq, one
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355283#comment-14355283
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda] [~vinodkv],
Also one
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355437#comment-14355437
]
Wangda Tan commented on YARN-2495:
--
Actually I've thought about this before, but since the
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355436#comment-14355436
]
Wangda Tan commented on YARN-2495:
--
Hi Naga,
--
bq. Well modifications side is clear to me
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355448#comment-14355448
]
Vinod Kumar Vavilapalli commented on YARN-2495:
---
bq. I'm wondering if we
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353241#comment-14353241
]
Naganarasimha G R commented on YARN-2495:
-
Most of the find bugs reported are from
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353217#comment-14353217
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353353#comment-14353353
]
Wangda Tan commented on YARN-2495:
--
For your comments:
1) For the name, do you think is
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353639#comment-14353639
]
Vinod Kumar Vavilapalli commented on YARN-2495:
---
Ah, right. Forgot about
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353397#comment-14353397
]
Craig Welch commented on YARN-2495:
---
-re
bq. How about we simply things? Instead of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353383#comment-14353383
]
Vinod Kumar Vavilapalli commented on YARN-2495:
---
Quick comments
-
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353897#comment-14353897
]
Wangda Tan commented on YARN-2495:
--
I think the two issues are identical, and we should
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354362#comment-14354362
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda],
1) IMO method name was not
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14349336#comment-14349336
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14349708#comment-14349708
]
Wangda Tan commented on YARN-2495:
--
1) Changes of CommonNodeLalelsManager is uncessary
2)
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329376#comment-14329376
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda],
Thanks for discussing and
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329399#comment-14329399
]
Wangda Tan commented on YARN-2495:
--
For your questions:
1. It's not first priority, let's
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327716#comment-14327716
]
Craig Welch commented on YARN-2495:
---
So, here's my proposal [~Naganarasimha]
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327718#comment-14327718
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328370#comment-14328370
]
Wangda Tan commented on YARN-2495:
--
[~cwelch],
Thanks for your thoughtful inputs,
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323076#comment-14323076
]
Craig Welch commented on YARN-2495:
---
My point is that everything necessary to manage
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320549#comment-14320549
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda],
Thanks for sharing your
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317048#comment-14317048
]
Wangda Tan commented on YARN-2495:
--
Hi [~cwelch],
Thanks for jumping in and providing your
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294441#comment-14294441
]
Craig Welch commented on YARN-2495:
---
[~Naganarasimha] I understand the desire to have the
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246882#comment-14246882
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~cwelch]
Thanks for taking time and
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243171#comment-14243171
]
Craig Welch commented on YARN-2495:
---
Sorry if I'm jumping in late and asking redundant
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243197#comment-14243197
]
Craig Welch commented on YARN-2495:
---
So, I see the language around the script based vs
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243217#comment-14243217
]
Allen Wittenauer commented on YARN-2495:
bq. This can already be accomplished
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243283#comment-14243283
]
Craig Welch commented on YARN-2495:
---
Other comments on the patch as such, assuming we
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239592#comment-14239592
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda]
All the test case issues
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238157#comment-14238157
]
Wangda Tan commented on YARN-2495:
--
[~Naganarasimha],
I meant you can leave it empty in
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238336#comment-14238336
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235317#comment-14235317
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda],
Yes i wanted to completely
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235363#comment-14235363
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235891#comment-14235891
]
Wangda Tan commented on YARN-2495:
--
[~Naganarasimha],
You don't have to specify the
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234506#comment-14234506
]
Wangda Tan commented on YARN-2495:
--
Hi [~Naganarasimha],
What I meant is completely remove
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14233644#comment-14233644
]
Wangda Tan commented on YARN-2495:
--
[~Naganarasimha],
Since size of the patch grows, and
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225432#comment-14225432
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225439#comment-14225439
]
Wangda Tan commented on YARN-2495:
--
[~Naganarasimha],
bq. In this case i feel we need to
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222424#comment-14222424
]
Wangda Tan commented on YARN-2495:
--
Hi [~Naganarasimha],
For 1#, sorry my bad, it has been
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222009#comment-14222009
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda], Thanks for the review
bq.
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14221342#comment-14221342
]
Wangda Tan commented on YARN-2495:
--
Hi [~Naganarasimha],
Thanks for update,
Several minor
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219287#comment-14219287
]
Naganarasimha G R commented on YARN-2495:
-
Following 3 test failure issues does not
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14218439#comment-14218439
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14206626#comment-14206626
]
Naganarasimha G R commented on YARN-2495:
-
{quote}
The benefit are
1) You don't
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204974#comment-14204974
]
Naganarasimha G R commented on YARN-2495:
-
Hi [~wangda], Thanks for reviewing and
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205689#comment-14205689
]
Wangda Tan commented on YARN-2495:
--
bq. I have already added the below code in the
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199494#comment-14199494
]
Wangda Tan commented on YARN-2495:
--
*Major comments:*
1.
As I commented,
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191656#comment-14191656
]
Hadoop QA commented on YARN-2495:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14184163#comment-14184163
]
Sunil G commented on YARN-2495:
---
Hi [~Naganarasimha Garla] [~gp.leftnoteasy]
I have one
83 matches
Mail list logo
