[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566056#comment-14566056
]
Hudson commented on YARN-3713:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
* hadoop-yarn-project/CHANGES.txt
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566045#comment-14566045
]
Hudson commented on YARN-3713:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
* hadoop-yarn-project/CHANGES.txt
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566018#comment-14566018
]
Hudson commented on YARN-3713:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566009#comment-14566009
]
Hudson commented on YARN-3713:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565961#comment-14565961
]
Hudson commented on YARN-3713:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565936#comment-14565936
]
Hudson commented on YARN-3713:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/943/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
* hadoop-yarn-project/CHANGES.txt
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565671#comment-14565671
]
zhihai xu commented on YARN-3713:
-
thanks [~rkanter] for the review and committing the patch.
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565598#comment-14565598
]
Hudson commented on YARN-3713:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7929 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7929/])
YARN-3713. Remove duplicate function call storeContainerDiagnostics in
ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev
6aec13cb338b0fe62ca915f78aa729c9b0b86fba)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0
>
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564031#comment-14564031
]
Robert Kanter commented on YARN-3713:
-
+1
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
[
https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558837#comment-14558837
]
Hadoop QA commented on YARN-3713:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 44s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 37s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 51s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 36s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 3s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 6m 11s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 42m 36s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735265/YARN-3713.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 56996a6 |
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8080/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8080/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8080/console |
This message was automatically generated.
> Remove duplicate function call storeContainerDiagnostics in
> ContainerDiagnosticsUpdateTransition
>
>
> Key: YARN-3713
> URL: https://issues.apache.org/jira/browse/YARN-3713
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.7.0
>Reporter: zhihai xu
>Assignee: zhihai xu
>Priority: Minor
> Labels: cleanup
> Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is
> already called at ContainerImpl#addDiagnostics.
> {code}
> private void addDiagnostics(String... diags) {
> for (String s : diags) {
> this.diagnostics.append(s);
> }
> try {
> stateStore.storeContainerDiagnostics(containerId, diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update diagnostics in state store for "
> + containerId, e);
> }
> }
> {code}
> So we don't need call {{storeContainerDiagnostics}} in
> ContainerDiagnosticsUpdateTransition#transition.
> {code}
> container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
> try {
> container.stateStore.storeContainerDiagnostics(container.containerId,
> container.diagnostics);
> } catch (IOException e) {
> LOG.warn("Unable to update state store diagnostics for "
> + container.containerId, e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
