[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2016-07-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369735#comment-15369735 ] Hudson commented on YARN-4053: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-20 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018447#comment-15018447 ] Varun Saxena commented on YARN-4053: Thanks [~sjlee0] for the review and commit. And [~jrottinghuis]

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014815#comment-15014815 ] Hadoop QA commented on YARN-4053: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014822#comment-15014822 ] Sangjin Lee commented on YARN-4053: --- Could you address that new checkstyle violation? Then I think it's

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014487#comment-15014487 ] Hadoop QA commented on YARN-4053: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014509#comment-15014509 ] Sangjin Lee commented on YARN-4053: --- Also, please look at the checkstyle violations. There are new ones

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014432#comment-15014432 ] Varun Saxena commented on YARN-4053: This patch removes ValueConverterImpl and uses generics as

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014673#comment-15014673 ] Varun Saxena commented on YARN-4053: This patch is similar to version 5 of the patch. No longer using

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014497#comment-15014497 ] Sangjin Lee commented on YARN-4053: --- As mentioned above the generic version is good only if {{add()}} and

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014518#comment-15014518 ] Varun Saxena commented on YARN-4053: Just to clarify, by mixing I meant I was thinking of a method like

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014525#comment-15014525 ] Varun Saxena commented on YARN-4053: Ok. > Change the way metric values are stored in HBase Storage >

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015332#comment-15015332 ] Hadoop QA commented on YARN-4053: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011590#comment-15011590 ] Hadoop QA commented on YARN-4053: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011789#comment-15011789 ] Joep Rottinghuis commented on YARN-4053: Thanks [~varun_saxena] patch looks good to me. Thanks for

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012508#comment-15012508 ] Sangjin Lee commented on YARN-4053: --- Sorry, I should have double checked. It would be more like {code}

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012620#comment-15012620 ] Sangjin Lee commented on YARN-4053: --- Yes, I spoke with [~jrottinghuis] regarding the stronger type safety

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012595#comment-15012595 ] Joep Rottinghuis commented on YARN-4053: [~sjlee0] the ValueConverterImpl is a remnant from earlier

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012185#comment-15012185 ] Sangjin Lee commented on YARN-4053: --- Sorry it took me awhile to review the latest patch. It looks good

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012244#comment-15012244 ] Sangjin Lee commented on YARN-4053: --- Is it the same question as what Varun answered earlier? bq. JAX-RS

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012422#comment-15012422 ] Vrushali C commented on YARN-4053: -- Alright, [~sjlee0] explained to me that there are writes coming via

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012208#comment-15012208 ] Vrushali C commented on YARN-4053: -- Thanks [~varun_saxena] for the patch! It looks good to me except for

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-18 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012313#comment-15012313 ] Vrushali C commented on YARN-4053: -- I thought that was only for client side read queries. Is the REST API

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-17 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009162#comment-15009162 ] Joep Rottinghuis commented on YARN-4053: Either throw exception, or document in javadoc that null

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009115#comment-15009115 ] Varun Saxena commented on YARN-4053: bq. public interface NumericValueConverter extends ValueConverter,

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007358#comment-15007358 ] Hadoop QA commented on YARN-4053: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-16 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008041#comment-15008041 ] Joep Rottinghuis commented on YARN-4053: Looks good [~varun_saxena] this is a nice separation of

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003688#comment-15003688 ] Hadoop QA commented on YARN-4053: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003690#comment-15003690 ] Varun Saxena commented on YARN-4053: Updating a renamed patch file so that QA build can run. > Change

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-13 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004550#comment-15004550 ] Joep Rottinghuis commented on YARN-4053: Patch looks good. The converter approach looks nice and

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-13 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004842#comment-15004842 ] Joep Rottinghuis commented on YARN-4053: Now that I'm looking at it again in detail with

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004727#comment-15004727 ] Varun Saxena commented on YARN-4053: bq. Would it be safe to always assume a long converter? I think

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-13 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004887#comment-15004887 ] Joep Rottinghuis commented on YARN-4053: In further discussion with [~sjlee0] it may actually be

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999660#comment-14999660 ] Sangjin Lee commented on YARN-4053: --- To make progress with this ticket, if you're in line with what

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999780#comment-14999780 ] Varun Saxena commented on YARN-4053: Ok > Change the way metric values are stored in HBase Storage >

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-10 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999822#comment-14999822 ] Vrushali C commented on YARN-4053: -- bq. Vrushali, thanks for your comments. I would like to work on this.

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999841#comment-14999841 ] Varun Saxena commented on YARN-4053: Moreover, whether to aggregate or not, the proposal is to not have

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999837#comment-14999837 ] Varun Saxena commented on YARN-4053: Attached a new patch addressing points above. Added a

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-09 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997121#comment-14997121 ] Varun Saxena commented on YARN-4053: Vrushali, thanks for your comments. I would like to work on this.

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-11-06 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994603#comment-14994603 ] Vrushali C commented on YARN-4053: -- Thanks [~varun_saxena] for the patch and [~djp] , [~gtCarrera],

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-10-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974100#comment-14974100 ] Hadoop QA commented on YARN-4053: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-10-26 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974623#comment-14974623 ] Varun Saxena commented on YARN-4053: [~sjlee0], [~djp], [~vrushalic] and others, kindly review. In this

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-09-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933492#comment-14933492 ] Varun Saxena commented on YARN-4053: I think we need to revive this JIRA and decide its scope. I will

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-09-02 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727641#comment-14727641 ] Varun Saxena commented on YARN-4053: bq. to use cell tag identify metrics value type In YARN-3816, by

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-09-02 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727620#comment-14727620 ] Junping Du commented on YARN-4053: -- Hi [~sjlee0] and all, sorry for coming late for this good discussion.

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-09-02 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727816#comment-14727816 ] Joep Rottinghuis commented on YARN-4053: Part of the issue is that there are many moving components

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717865#comment-14717865 ] Sangjin Lee commented on YARN-4053: --- [~vrushalic], [~jrottinghuis], and I discussed

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717863#comment-14717863 ] Sangjin Lee commented on YARN-4053: --- Thanks [~varun_saxena] for the discussion. As you

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-26 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715192#comment-14715192 ] Vrushali C commented on YARN-4053: -- The way I see this, it comes down to a basic question

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-25 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710651#comment-14710651 ] Varun Saxena commented on YARN-4053: Looking at the issues involved, IMO we should

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710638#comment-14710638 ] Varun Saxena commented on YARN-4053: There was a suggestion that we can support only

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710633#comment-14710633 ] Varun Saxena commented on YARN-4053: Wanted to discuss so that we can reach a consensus

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-20 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704368#comment-14704368 ] Varun Saxena commented on YARN-4053: bq. it might be good to restrict the numeric types

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703889#comment-14703889 ] Sangjin Lee commented on YARN-4053: --- I discussed this with [~jrottinghuis] a little more,

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700381#comment-14700381 ] Sangjin Lee commented on YARN-4053: --- And I do think that we need to support floating type

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700378#comment-14700378 ] Sangjin Lee commented on YARN-4053: --- Thanks [~varun_saxena] for pointing out an important

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Naganarasimha G R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700759#comment-14700759 ] Naganarasimha G R commented on YARN-4053: - bq. place a restriction on client that

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700757#comment-14700757 ] Varun Saxena commented on YARN-4053: [~sjlee0], bq. I'm just curious (and perhaps this

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699872#comment-14699872 ] Li Lu commented on YARN-4053: - Hi [~varun_saxena], thanks for the patch! With regard to the

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699885#comment-14699885 ] Varun Saxena commented on YARN-4053: [~gtCarrera9], yes, will update a patch by

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699907#comment-14699907 ] Varun Saxena commented on YARN-4053: Oh sorry in my original comment, I meant that we

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699883#comment-14699883 ] Varun Saxena commented on YARN-4053: bq. We may have something like TimelineData.FLOAT,

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699888#comment-14699888 ] Li Lu commented on YARN-4053: - Thanks! Tomorrow LGTM. Change the way metric values are

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699951#comment-14699951 ] Varun Saxena commented on YARN-4053: On second thoughts, all three types may make sense

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-17 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699971#comment-14699971 ] Li Lu commented on YARN-4053: - bq. Oh sorry in my original comment, I meant that we can carry

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698602#comment-14698602 ] Varun Saxena commented on YARN-4053: This patch demonstrates the approach mentioned

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698608#comment-14698608 ] Hadoop QA commented on YARN-4053: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698209#comment-14698209 ] Varun Saxena commented on YARN-4053: Naga, yes double can also be used. But the

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697449#comment-14697449 ] Varun Saxena commented on YARN-4053: Also for floating point metrics, query can be in

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697556#comment-14697556 ] Varun Saxena commented on YARN-4053: bq. What kind of metrics do you have in mind that

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697571#comment-14697571 ] Varun Saxena commented on YARN-4053: Tez may not be publishing any floating point

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697583#comment-14697583 ] Vrushali C commented on YARN-4053: -- Hmm good points. I think all metrics should be

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697443#comment-14697443 ] Varun Saxena commented on YARN-4053: Storing metric values(which are numbers) as string

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697500#comment-14697500 ] Vrushali C commented on YARN-4053: -- I think metric values should be stored (and read back)

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697445#comment-14697445 ] Varun Saxena commented on YARN-4053: So to resolve this we need some other way of

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697454#comment-14697454 ] Varun Saxena commented on YARN-4053: cc [~sjlee0], [~djp], [~zjshen], [~vinodkv].

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Naganarasimha G R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697967#comment-14697967 ] Naganarasimha G R commented on YARN-4053: - [~vrushalic] how about double ? I feel

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Naganarasimha G R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697968#comment-14697968 ] Naganarasimha G R commented on YARN-4053: - [~vrushalic] how about double ? I feel

[jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage

2015-08-14 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1469#comment-1469 ] Li Lu commented on YARN-4053: - Hi [~varun_saxena], I agree this is a valid issue. Before we get