[jira] [Commented] (YARN-9266) General improvements in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791030#comment-16791030 ] Hudson commented on YARN-9266: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16192 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16192/]) YARN-9266. General improvements in IntelFpgaOpenclPlugin. Contributed by (sunilg: rev 8e1539eca8175f58f836daa5b0ad598c890cbb02) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/fpga/TestFpgaResourceHandler.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/IntelFpgaOpenclPlugin.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/fpga/FpgaResourceHandlerImpl.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java * (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/TestAoclOutputParser.java * (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AoclDiagnosticOutputParser.java * (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/package-info.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/TestFpgaDiscoverer.java > General improvements in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Fix For: 3.3.0 > > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch, YARN-9266-005.patch, > YARN-9266-006.patch, YARN-9266-007.patch, YARN-9266-008.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9266) General improvements in IntelFpgaOpenclPlugin
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791022#comment-16791022 ] Sunil Govindan commented on YARN-9266: -- Committed to trunk. Thanks [~pbacsko], and thank [~tangzhankun] [~adam.antal] for additional reviews. Lets pull to other branches once all necessary patches are backported. > General improvements in IntelFpgaOpenclPlugin > - > > Key: YARN-9266 > URL: https://issues.apache.org/jira/browse/YARN-9266 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-9266-001.patch, YARN-9266-002.patch, > YARN-9266-003.patch, YARN-9266-004.patch, YARN-9266-005.patch, > YARN-9266-006.patch, YARN-9266-007.patch, YARN-9266-008.patch > > > Problems identified in this class: > * {{InnerShellExecutor}} ignores the timeout parameter > * {{configureIP()}} uses printStackTrace() instead of logging > * {{configureIP()}} does not log the output of aocl if the exit code != 0 > * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class > for better testability > * {{downloadIP()}} uses {{contains()}} for file name check – this can really > surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx > also matches) > * method name {{downloadIP()}} is misleading – it actually tries to finds > the file. Everything is downloaded (localized) at this point. > * {{@VisibleForTesting}} methods should be package private > * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} > class > * checkstyle fixes -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org