[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313006#comment-17313006
]
Qi Zhu commented on YARN-9618:
--
Thanks [~pbacsko] [~gandras] for confirm.
> NodeListManager event
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312997#comment-17312997
]
Andras Gyori commented on YARN-9618:
I think it is well done now, +1.
> NodeListManager event
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312989#comment-17312989
]
Peter Bacsko commented on YARN-9618:
+1 LGTM
[~gandras] are you OK with the patch?
> NodeListManager
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312664#comment-17312664
]
Hadoop QA commented on YARN-9618:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312525#comment-17312525
]
Qi Zhu commented on YARN-9618:
--
Thanks [~pbacsko] for very good suggestions.
Updated in latest patch.:D
>
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312516#comment-17312516
]
Peter Bacsko commented on YARN-9618:
Small things:
1.
{noformat}
//Is trigger RMAppNodeUpdateEvent
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312145#comment-17312145
]
Qi Zhu commented on YARN-9618:
--
Thanks a lot [~gandras] for your confirm. :D
Waiting [~ebadger] [~pbacsko]
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312139#comment-17312139
]
Andras Gyori commented on YARN-9618:
Thank you for the patch [~zhuqi]. I think this is a really good
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311627#comment-17311627
]
Qi Zhu commented on YARN-9618:
--
[~ebadger]
The code now is no new stress should be tested, this will helpful
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307845#comment-17307845
]
Qi Zhu commented on YARN-9618:
--
The test failed not related this.
> NodeListManager event improvement
>
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307776#comment-17307776
]
Hadoop QA commented on YARN-9618:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307688#comment-17307688
]
Qi Zhu commented on YARN-9618:
--
[~gandras] [~ebadger] [~pbacsko]
I have updated in the patch as [~gandras]
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307674#comment-17307674
]
Qi Zhu commented on YARN-9618:
--
Thanks [~ebadger] [~gandras] for review and clarify.
It make sense to me, i
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307611#comment-17307611
]
Andras Gyori commented on YARN-9618:
[~ebadger] that is correct. In my opinion the proposal in
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307413#comment-17307413
]
Eric Badger commented on YARN-9618:
---
bq. Actually, why we use an other async dispatcher here is try to
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305978#comment-17305978
]
Qi Zhu commented on YARN-9618:
--
[~gandras]
You are right, main performance gain here is due to eliminating
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305953#comment-17305953
]
Andras Gyori commented on YARN-9618:
Thank you [~zhuqi] for the patch. I have analysed the code a bit
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303278#comment-17303278
]
Qi Zhu commented on YARN-9618:
--
The test is not related.
> NodeListManager event improvement
>
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303256#comment-17303256
]
Hadoop QA commented on YARN-9618:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303184#comment-17303184
]
Hadoop QA commented on YARN-9618:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303124#comment-17303124
]
Qi Zhu commented on YARN-9618:
--
[~gandras] [~ebadger]
Added the EventDispatcher in created logic, to make
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302860#comment-17302860
]
Eric Badger commented on YARN-9618:
---
The patch looks reasonable to me. Agree with [~gandras] that some
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302670#comment-17302670
]
Hadoop QA commented on YARN-9618:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302660#comment-17302660
]
Andras Gyori commented on YARN-9618:
Thanks [~zhuqi] for the patch, it seems to be a good scalability
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302517#comment-17302517
]
Qi Zhu commented on YARN-9618:
--
Fixed test and checkstyle in latest patch. :D
> NodeListManager event
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302478#comment-17302478
]
Hadoop QA commented on YARN-9618:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302371#comment-17302371
]
Qi Zhu commented on YARN-9618:
--
[~bibinchundatt] [~pbacsko] [~ebadger] [~epayne] [~gandras] [~bteke]
Could
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242284#comment-17242284
]
Hadoop QA commented on YARN-9618:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242179#comment-17242179
]
zhuqi commented on YARN-9618:
-
[~bibinchundatt] [~leftnoteasy]
This is a big improvement for nodemanager
[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861022#comment-16861022
]
Bibin A Chundatt commented on YARN-9618:
cc:// [~sunil.gov...@gmail.com],[~leftnoteasy]
>
30 matches
Mail list logo
