[jira] [Updated] (YARN-2766) ApplicationHistoryManager is expected to return a sorted list of apps/attempts/containers
[
https://issues.apache.org/jira/browse/YARN-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated YARN-2766:
--
Labels: 2.6.1-candidate (was: )
Fix Version/s: 2.6.1
Pulled this into 2.6.1 as a dependency for YARN-3700. Patch applied cleanly.
Ran compilation before the push.
> ApplicationHistoryManager is expected to return a sorted list of
> apps/attempts/containers
> --
>
> Key: YARN-2766
> URL: https://issues.apache.org/jira/browse/YARN-2766
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Labels: 2.6.1-candidate
> Fix For: 2.7.0, 2.6.1
>
> Attachments: YARN-2766.patch, YARN-2766.patch, YARN-2766.patch,
> YARN-2766.patch
>
>
> {{TestApplicationHistoryClientService.testContainers}} and
> {{TestApplicationHistoryClientService.testApplicationAttempts}} both fail
> because the test assertions are assuming a returned Collection is in a
> certain order. The collection comes from a HashMap, so the order is not
> guaranteed, plus, according to [this
> page|http://docs.oracle.com/javase/8/docs/technotes/guides/collections/changes8.html],
> there are situations where the iteration order of a HashMap will be
> different between Java 7 and 8.
> We should fix the test code to not assume a specific ordering.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (YARN-2766) ApplicationHistoryManager is expected to return a sorted list of apps/attempts/containers
[
https://issues.apache.org/jira/browse/YARN-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Kanter updated YARN-2766:
Attachment: YARN-2766.patch
Makes sense. The new patch updates ApplicationHistoryManagerOnTimelineStore
instead of the protobuf classes. It replaces the HashMap with a LinkedHashMap,
which does maintain order (the data is loaded from the store into the Map in a
consistent order).
ApplicationHistoryManager is expected to return a sorted list of
apps/attempts/containers
--
Key: YARN-2766
URL: https://issues.apache.org/jira/browse/YARN-2766
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: 2.6.0
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: YARN-2766.patch, YARN-2766.patch, YARN-2766.patch,
YARN-2766.patch
{{TestApplicationHistoryClientService.testContainers}} and
{{TestApplicationHistoryClientService.testApplicationAttempts}} both fail
because the test assertions are assuming a returned Collection is in a
certain order. The collection comes from a HashMap, so the order is not
guaranteed, plus, according to [this
page|http://docs.oracle.com/javase/8/docs/technotes/guides/collections/changes8.html],
there are situations where the iteration order of a HashMap will be
different between Java 7 and 8.
We should fix the test code to not assume a specific ordering.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (YARN-2766) ApplicationHistoryManager is expected to return a sorted list of apps/attempts/containers
[
https://issues.apache.org/jira/browse/YARN-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhijie Shen updated YARN-2766:
--
Summary: ApplicationHistoryManager is expected to return a sorted list of
apps/attempts/containers (was: [JDK 8] TestApplicationHistoryClientService
fails)
ApplicationHistoryManager is expected to return a sorted list of
apps/attempts/containers
--
Key: YARN-2766
URL: https://issues.apache.org/jira/browse/YARN-2766
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: 2.6.0
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: YARN-2766.patch, YARN-2766.patch, YARN-2766.patch
{{TestApplicationHistoryClientService.testContainers}} and
{{TestApplicationHistoryClientService.testApplicationAttempts}} both fail
because the test assertions are assuming a returned Collection is in a
certain order. The collection comes from a HashMap, so the order is not
guaranteed, plus, according to [this
page|http://docs.oracle.com/javase/8/docs/technotes/guides/collections/changes8.html],
there are situations where the iteration order of a HashMap will be
different between Java 7 and 8.
We should fix the test code to not assume a specific ordering.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
