[ 
https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076305#comment-16076305
 ] 

Varun Saxena edited comment on YARN-6130 at 7/6/17 10:22 AM:
-------------------------------------------------------------

bq. One high level comment on the patch, To the AM, we are sending complete 
AppCollectorDataProto. This contains many unnecessary information which AM does 
not need it. I think it would be better to create another meta object inside 
AppCollectorDataProto which need to be sent to AM?
We can send the version info as it will make it easy for AM to update token 
only if it changes. But in future, we may add something to AppCollectorData 
which we may not need to send to AM. So the suggestion makes sense. So, will do 
it after QA report.


was (Author: varun_saxena):
bq. One high level comment on the patch, To the AM, we are sending complete 
AppCollectorDataProto. This contains many unnecessary information which AM does 
not need it. I think it would be better to create another meta object inside 
AppCollectorDataProto which need to be sent to AM?
Makes sense. Will do it after QA report.

> [Security] Generate a delegation token for AM when app collector is created 
> and pass it to AM via NM and RM
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6130
>                 URL: https://issues.apache.org/jira/browse/YARN-6130
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-6130-YARN-5355.01.patch, 
> YARN-6130-YARN-5355.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to