[
https://issues.apache.org/jira/browse/YARN-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837719#comment-16837719
]
Wanqiang Ji edited comment on YARN-9453 at 5/11/19 12:29 AM:
-------------------------------------------------------------
Hi [~giovanni.fumarola], 004 patch did it.
was (Author: jiwq):
Hi [~giovanni.fumarola], 004 patch do it.
> Clean up code long if-else chain in ApplicationCLI#run
> ------------------------------------------------------
>
> Key: YARN-9453
> URL: https://issues.apache.org/jira/browse/YARN-9453
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Wanqiang Ji
> Priority: Major
> Labels: newbie
> Attachments: YARN-9453.001.patch, YARN-9453.002.patch,
> YARN-9453.003.patch, YARN-9453.004.patch
>
>
> org.apache.hadoop.yarn.client.cli.ApplicationCLI#run is 630 lines long,
> contains a long if-else chain and many many conditions.
> As a start, the bodies of the conditions could be extracted to methods and a
> more clean solution could be introduced to parse the argument values.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
