[jira] [Commented] (YARN-10095) Fix help message for yarn rmadmin
[ https://issues.apache.org/jira/browse/YARN-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045085#comment-17045085 ] Akira Ajisaka commented on YARN-10095: -- Thanks [~risyomei] for providing the patch. "can only be used when RM HA is enabled" message is missing after the patch. Would you check this? * before {noformat} $ yarn rmadmin -help -getServiceState Usage: yarn rmadmin [-getServiceState ] -getServiceState can only be used when RM HA is enabled {noformat} * after {noformat} $ yarn rmadmin -help -getServiceState Usage: yarn rmadmin [-getServiceState ] -getServiceState : Returns the state of the service {noformat} Nit: Now we can use AssertJ for unit test. For example, the following code {code} assertTrue(errOut.contains("transitionToObserver: Unknown command")); {code} can be changed to {code} assertThat(errOut).contains("transitionToObserver: Unknown command"); {code} After the change, the error message will be more understandable when the error occurs. > Fix help message for yarn rmadmin > - > > Key: YARN-10095 > URL: https://issues.apache.org/jira/browse/YARN-10095 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Minor > Attachments: YARN-10095.000.patch > > > (This issue is identified by [~aajisaka] in > https://issues.apache.org/jira/browse/HADOOP-16753) > The help message of yarn rmadmin seems broken. > Current: > {code:java} > $ yarn rmadmin -Dyarn.resourcemanager.ha.enabled=true -help > -refreshNodesResources > Usage: yarn rmadmin [-refreshNodesResources] > Generic options supported are: > -conf specify an application configuration file > -Ddefine a value for a given property > -fs specify default filesystem URL to use, > overrides 'fs.defaultFS' property from configurations. > -jt specify a ResourceManager > -files specify a comma-separated list of files to > be copied to the map reduce cluster > -libjarsspecify a comma-separated list of jar files > to be included in the classpath > -archives specify a comma-separated list of archives > to be unarchived on the compute machines > The general command line syntax is: > command [genericOptions] [commandOptions] > {code} > > Expected: > {code:java} > $ yarn rmadmin -Dyarn.resourcemanager.ha.enabled=true -help > -refreshNodesResources > Usage: yarn rmadmin [-refreshNodesResources] >-refreshNodesResources: Refresh resources of NodeManagers at the > ResourceManager.< HERE > Generic options supported are: > -conf specify an application configuration file > -Ddefine a value for a given property > -fs specify default filesystem URL to use, > overrides 'fs.defaultFS' property from configurations. > -jt specify a ResourceManager > -files specify a comma-separated list of files to > be copied to the map reduce cluster > -libjarsspecify a comma-separated list of jar files > to be included in the classpath > -archives specify a comma-separated list of archives > to be unarchived on the compute machines > The general command line syntax is: > command [genericOptions] [commandOptions] > {code} > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10095) Fix help message for yarn rmadmin
[ https://issues.apache.org/jira/browse/YARN-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025813#comment-17025813 ] Hadoop QA commented on YARN-10095: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 32s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 3m 17s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 0 new + 84 unchanged - 4 fixed = 84 total (was 88) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 31s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 26m 19s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 65m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/hadoop:c44943d1fc3 | | JIRA Issue | YARN-10095 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12992099/YARN-10095.000.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 6ce0fe1c38c5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 825db8f | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_232 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/25462/testReport/ | | Max. process+thread count | 556 (vs. ulimit of 5500) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/25462/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Fix help message
[jira] [Commented] (YARN-10095) Fix help message for yarn rmadmin
[ https://issues.apache.org/jira/browse/YARN-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019791#comment-17019791 ] Xieming Li commented on YARN-10095: --- [~yehuanhuan] Thank you for pointing out. I have checked "hdfs haadmin -help" and it takes commands without leading '-'. Now, I am not sure if I should fix "yarn rmadmin" here or the "hdfs haadmin", or don't fix any of them at all. > Fix help message for yarn rmadmin > - > > Key: YARN-10095 > URL: https://issues.apache.org/jira/browse/YARN-10095 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Minor > > (This issue is identified by [~aajisaka] in > https://issues.apache.org/jira/browse/HADOOP-16753) > The help message of yarn rmadmin seems broken. > Current: > {code:java} > $ yarn rmadmin -help refreshNodes 2>/dev/null > $ > $ yarn rmadmin -help refreshNodes > Usage: yarn rmadmin >-refreshQueues >-refreshNodes [-g|graceful [timeout in seconds] -client|server] >-refreshNodesResources >-refreshSuperUserGroupsConfiguration >-refreshUserToGroupsMappings >-refreshAdminAcls >-refreshServiceAcl >-getGroups [username] >-addToClusterNodeLabels > <"label1(exclusive=true),label2(exclusive=false),label3"> >-removeFromClusterNodeLabels (label splitted by ",") >-replaceLabelsOnNode <"node1[:port]=label1,label2 > node2[:port]=label1,label2"> [-failOnUnknownNodes] >-directlyAccessNodeLabelStore >-refreshClusterMaxPriority >-updateNodeResource [NodeID] [MemSize] [vCores] ([OvercommitTimeout]) > or > [NodeID] [resourcetypes] ([OvercommitTimeout]). >-help [cmd]Generic options supported are: > -conf specify an application configuration file > -Ddefine a value for a given property > -fs specify default filesystem URL to use, > overrides 'fs.defaultFS' property from configurations. > -jt specify a ResourceManager > -files specify a comma-separated list of files to > be copied to the map reduce cluster > -libjarsspecify a comma-separated list of jar files > to be included in the classpath > -archives specify a comma-separated list of archives > to be unarchived on the compute machinesThe general command line syntax is: > command [genericOptions] [commandOptions] > {code} > > > Expected: > {code:java} > $ yarn rmadmin -help refreshNodes 2>/dev/null > -refreshNodes [-g|graceful [timeout in seconds] -client|server] > $ yarn rmadmin -help refreshNodes > -refreshNodes [-g|graceful [timeout in seconds] -client|server] > {code} > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10095) Fix help message for yarn rmadmin
[ https://issues.apache.org/jira/browse/YARN-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019300#comment-17019300 ] yehuanhuan commented on YARN-10095: --- Hi Xieming Li, I found that using this command “yarn rmadmin -help -refreshNodes” can solve. > Fix help message for yarn rmadmin > - > > Key: YARN-10095 > URL: https://issues.apache.org/jira/browse/YARN-10095 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Minor > > (This issue is identified by [~aajisaka] in > https://issues.apache.org/jira/browse/HADOOP-16753) > The help message of yarn rmadmin seems broken. > Current: > {code:java} > $ yarn rmadmin -help refreshNodes 2>/dev/null > $ > $ yarn rmadmin -help refreshNodes > Usage: yarn rmadmin >-refreshQueues >-refreshNodes [-g|graceful [timeout in seconds] -client|server] >-refreshNodesResources >-refreshSuperUserGroupsConfiguration >-refreshUserToGroupsMappings >-refreshAdminAcls >-refreshServiceAcl >-getGroups [username] >-addToClusterNodeLabels > <"label1(exclusive=true),label2(exclusive=false),label3"> >-removeFromClusterNodeLabels (label splitted by ",") >-replaceLabelsOnNode <"node1[:port]=label1,label2 > node2[:port]=label1,label2"> [-failOnUnknownNodes] >-directlyAccessNodeLabelStore >-refreshClusterMaxPriority >-updateNodeResource [NodeID] [MemSize] [vCores] ([OvercommitTimeout]) > or > [NodeID] [resourcetypes] ([OvercommitTimeout]). >-help [cmd]Generic options supported are: > -conf specify an application configuration file > -Ddefine a value for a given property > -fs specify default filesystem URL to use, > overrides 'fs.defaultFS' property from configurations. > -jt specify a ResourceManager > -files specify a comma-separated list of files to > be copied to the map reduce cluster > -libjarsspecify a comma-separated list of jar files > to be included in the classpath > -archives specify a comma-separated list of archives > to be unarchived on the compute machinesThe general command line syntax is: > command [genericOptions] [commandOptions] > {code} > > > Expected: > {code:java} > $ yarn rmadmin -help refreshNodes 2>/dev/null > -refreshNodes [-g|graceful [timeout in seconds] -client|server] > $ yarn rmadmin -help refreshNodes > -refreshNodes [-g|graceful [timeout in seconds] -client|server] > {code} > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10095) Fix help message for yarn rmadmin
[ https://issues.apache.org/jira/browse/YARN-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019272#comment-17019272 ] Akira Ajisaka commented on YARN-10095: -- Thank you for filing the jira. Moved the issue from Common to YARN. > Fix help message for yarn rmadmin > - > > Key: YARN-10095 > URL: https://issues.apache.org/jira/browse/YARN-10095 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Minor > > (This issue is identified by [~aajisaka] in > https://issues.apache.org/jira/browse/HADOOP-16753) > The help message of yarn rmadmin seems broken. > Current: > {code:java} > $ yarn rmadmin -help refreshNodes 2>/dev/null > $ > $ yarn rmadmin -help refreshNodes > Usage: yarn rmadmin >-refreshQueues >-refreshNodes [-g|graceful [timeout in seconds] -client|server] >-refreshNodesResources >-refreshSuperUserGroupsConfiguration >-refreshUserToGroupsMappings >-refreshAdminAcls >-refreshServiceAcl >-getGroups [username] >-addToClusterNodeLabels > <"label1(exclusive=true),label2(exclusive=false),label3"> >-removeFromClusterNodeLabels (label splitted by ",") >-replaceLabelsOnNode <"node1[:port]=label1,label2 > node2[:port]=label1,label2"> [-failOnUnknownNodes] >-directlyAccessNodeLabelStore >-refreshClusterMaxPriority >-updateNodeResource [NodeID] [MemSize] [vCores] ([OvercommitTimeout]) > or > [NodeID] [resourcetypes] ([OvercommitTimeout]). >-help [cmd]Generic options supported are: > -conf specify an application configuration file > -Ddefine a value for a given property > -fs specify default filesystem URL to use, > overrides 'fs.defaultFS' property from configurations. > -jt specify a ResourceManager > -files specify a comma-separated list of files to > be copied to the map reduce cluster > -libjarsspecify a comma-separated list of jar files > to be included in the classpath > -archives specify a comma-separated list of archives > to be unarchived on the compute machinesThe general command line syntax is: > command [genericOptions] [commandOptions] > {code} > > > Expected: > {code:java} > $ yarn rmadmin -help refreshNodes 2>/dev/null > -refreshNodes [-g|graceful [timeout in seconds] -client|server] > $ yarn rmadmin -help refreshNodes > -refreshNodes [-g|graceful [timeout in seconds] -client|server] > {code} > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org