[
https://issues.apache.org/jira/browse/YARN-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057774#comment-17057774
]
Hudson commented on YARN-10191:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18043 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/18043/])
YARN-10191. FS-CS converter: call System.exit function call for every (sunilg:
rev 0fd8bf5f6b2cd7af351a5a9ebdc98cb12d6a82aa)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverterMain.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverterMain.java
> FS-CS converter: call System.exit function call for every code path in main
> method
> ----------------------------------------------------------------------------------
>
> Key: YARN-10191
> URL: https://issues.apache.org/jira/browse/YARN-10191
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: YARN-10191-001.patch
>
>
> Note that we don't call {{System.exit()}} on the happy path scenario in the
> converter:
> {code:java}
> public static void main(String[] args) {
> try {
> FSConfigToCSConfigArgumentHandler fsConfigConversionArgumentHandler =
> new FSConfigToCSConfigArgumentHandler();
> int exitCode =
> fsConfigConversionArgumentHandler.parseAndConvert(args);
> if (exitCode != 0) {
> LOG.error(FATAL,
> "Error while starting FS configuration conversion, " +
> "see previous error messages for details!");
> System.exit(exitCode);
> }
> } catch (Throwable t) {
> LOG.error(FATAL,
> "Error while starting FS configuration conversion!", t);
> System.exit(-1);
> }
> }
> {code}
> This is a mistake. If there's any non-daemon thread hanging around which was
> started by either FS or CS, the tool will never terminate. We must call
> {{System.exit()}} in every occasion to make sure that it never blocks at the
> end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
