[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067624#comment-17067624 ] Hudson commented on YARN-10197: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18093 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18093/]) YARN-10197. FS-CS converter: fix emitted ordering policy string and (snemeth: rev 9a297ff31d3e5d16ac648de584d430fc856afefe) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java * (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-defaultMaxAmShareDisabled.xml * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-conversion.xml * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java > FS-CS converter: fix emitted ordering policy string and max-am-resource > percent value > - > > Key: YARN-10197 > URL: https://issues.apache.org/jira/browse/YARN-10197 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Fix For: 3.3.0 > > Attachments: YARN-10197-001.patch, YARN-10197-002.patch, > YARN-10197-003.patch > > > There are three problems that have to be addressed in the converter: > 1) For {{yarn.scheduler.capacity..ordering-policy}}, the emitted value > should be "fifo", not "FIFO". The reason we generate "FIFO" is because > {{FifoPolicy.NAME}} consists of uppercase letters. > 2) {{maximum-am-resource-percent}} calculation is faulty too. For example, in > FS, you can globally disable it with > {{-1.0}}. However this case > is not handled properly in > {{FSConfigToCSConfigConverter.emitDefaultMaxAMShare()}}. -1.0 means that max > AM check is disabled, therefore we have to generate the value "1.0" to allow > as many AMs as possible. In {{FSQueueConverter.emitMaxAMShare()}}, we should > also check if the current value differs from the global setting and only then > output "1.0" for a given queue. > 3) The multi-leaf queue check is no longer necessary and it doesn't work > anyway. The CS instance catches this kind of error during the verification > step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067611#comment-17067611 ] Szilard Nemeth commented on YARN-10197: --- Thanks [~pbacsko], Patch looks good to me. Committed to trunk. > FS-CS converter: fix emitted ordering policy string and max-am-resource > percent value > - > > Key: YARN-10197 > URL: https://issues.apache.org/jira/browse/YARN-10197 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-10197-001.patch, YARN-10197-002.patch, > YARN-10197-003.patch > > > There are three problems that have to be addressed in the converter: > 1) For {{yarn.scheduler.capacity..ordering-policy}}, the emitted value > should be "fifo", not "FIFO". The reason we generate "FIFO" is because > {{FifoPolicy.NAME}} consists of uppercase letters. > 2) {{maximum-am-resource-percent}} calculation is faulty too. For example, in > FS, you can globally disable it with > {{-1.0}}. However this case > is not handled properly in > {{FSConfigToCSConfigConverter.emitDefaultMaxAMShare()}}. -1.0 means that max > AM check is disabled, therefore we have to generate the value "1.0" to allow > as many AMs as possible. In {{FSQueueConverter.emitMaxAMShare()}}, we should > also check if the current value differs from the global setting and only then > output "1.0" for a given queue. > 3) The multi-leaf queue check is no longer necessary and it doesn't work > anyway. The CS instance catches this kind of error during the verification > step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060874#comment-17060874 ] Peter Bacsko commented on YARN-10197: - [~prabhujoseph] could you review & commit this patch? > FS-CS converter: fix emitted ordering policy string and max-am-resource > percent value > - > > Key: YARN-10197 > URL: https://issues.apache.org/jira/browse/YARN-10197 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-10197-001.patch, YARN-10197-002.patch, > YARN-10197-003.patch > > > There are three problems that have to be addressed in the converter: > 1) For {{yarn.scheduler.capacity..ordering-policy}}, the emitted value > should be "fifo", not "FIFO". The reason we generate "FIFO" is because > {{FifoPolicy.NAME}} consists of uppercase letters. > 2) {{maximum-am-resource-percent}} calculation is faulty too. For example, in > FS, you can globally disable it with > {{-1.0}}. However this case > is not handled properly in > {{FSConfigToCSConfigConverter.emitDefaultMaxAMShare()}}. -1.0 means that max > AM check is disabled, therefore we have to generate the value "1.0" to allow > as many AMs as possible. In {{FSQueueConverter.emitMaxAMShare()}}, we should > also check if the current value differs from the global setting and only then > output "1.0" for a given queue. > 3) The multi-leaf queue check is no longer necessary and it doesn't work > anyway. The CS instance catches this kind of error during the verification > step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060322#comment-17060322 ] Hadoop QA commented on YARN-10197: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 25m 0s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 40s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 47s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 33s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 10s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 59s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}165m 57s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:c44943d1fc3 | | JIRA Issue | YARN-10197 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12996826/YARN-10197-003.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 990f803519a3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / ea68863 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_242 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/25697/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/25697/testReport/ | | Max. process+thread count | 86
[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058936#comment-17058936 ] Hadoop QA commented on YARN-10197: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 20m 42s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 42s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 43s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 48s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 32s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}161m 19s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.fair.converter.TestFSQueueConverter | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:c44943d1fc3 | | JIRA Issue | YARN-10197 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12996662/YARN-10197-002.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 5f1af10e2d57 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / c83644d | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_242 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/25694/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/25694/testReport/ | | Max. process+thread count | 885 (vs. ulimit of 5500) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yar
[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058767#comment-17058767 ] Peter Bacsko commented on YARN-10197: - Note: patch v1 will be extended later with some more unit tests regarding max AM share. > FS-CS converter: fix emitted ordering policy string and max-am-resource > percent value > - > > Key: YARN-10197 > URL: https://issues.apache.org/jira/browse/YARN-10197 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-10197-001.patch > > > There are two problems that have to be addressed in the converter: > 1) For {{yarn.scheduler.capacity..ordering-policy}}, the emitted value > should be "fifo", not "FIFO". The reason we generate "FIFO" is because > {{FifoPolicy.NAME}} consists of uppercase letters. > 2) {{maximum-am-resource-percent}} calculation is faulty too. For example, in > FS, you can globally disable it with > {{-1.0}}. However this case > is not handled properly in > {{FSConfigToCSConfigConverter.emitDefaultMaxAMShare()}}. -1.0 means that max > AM check is disabled, therefore we have to generate the value "1.0" to allow > as many AMs as possible. In {{FSQueueConverter.emitMaxAMShare()}}, we should > also check if the current value differs from the global setting and only then > output "1.0" for a given queue. > 3) The multi-leaf queue check is no longer necessary and it doesn't work > anyway. The CS instance catches this kind of error during the verification > step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10197) FS-CS converter: fix emitted ordering policy string and max-am-resource percent value
[ https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058768#comment-17058768 ] Hadoop QA commented on YARN-10197: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color} | {color:red} YARN-10197 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | YARN-10197 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12996661/YARN-10197-001.patch | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/25693/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > FS-CS converter: fix emitted ordering policy string and max-am-resource > percent value > - > > Key: YARN-10197 > URL: https://issues.apache.org/jira/browse/YARN-10197 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Peter Bacsko >Assignee: Peter Bacsko >Priority: Major > Attachments: YARN-10197-001.patch > > > There are two problems that have to be addressed in the converter: > 1) For {{yarn.scheduler.capacity..ordering-policy}}, the emitted value > should be "fifo", not "FIFO". The reason we generate "FIFO" is because > {{FifoPolicy.NAME}} consists of uppercase letters. > 2) {{maximum-am-resource-percent}} calculation is faulty too. For example, in > FS, you can globally disable it with > {{-1.0}}. However this case > is not handled properly in > {{FSConfigToCSConfigConverter.emitDefaultMaxAMShare()}}. -1.0 means that max > AM check is disabled, therefore we have to generate the value "1.0" to allow > as many AMs as possible. In {{FSQueueConverter.emitMaxAMShare()}}, we should > also check if the current value differs from the global setting and only then > output "1.0" for a given queue. > 3) The multi-leaf queue check is no longer necessary and it doesn't work > anyway. The CS instance catches this kind of error during the verification > step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org