[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098648#comment-17098648 ] Brahma Reddy Battula commented on YARN-10247: - Pushed to branch-3.3.0 also as this was marked blocker for 3.3.0 release. Thanks all. > Application priority queue ACLs are not respected > - > > Key: YARN-10247 > URL: https://issues.apache.org/jira/browse/YARN-10247 > Project: Hadoop YARN > Issue Type: Task > Components: capacity scheduler >Reporter: Sunil G >Assignee: Sunil G >Priority: Blocker > Fix For: 3.3.0, 3.4.0 > > Attachments: YARN-10247.0001.patch > > > This is a regression from queue path jira. > App priority acls are not working correctly. > {code:java} > yarn.scheduler.capacity.root.B.acl_application_max_priority=[user=john > group=users max_priority=4] > {code} > max_priority enforcement is not working. For user john, maximum supported > priority is 4. However I can submit like priority 6 for this user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095490#comment-17095490 ] Hudson commented on YARN-10247: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18198 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18198/]) YARN-10247. Application priority queue ACLs are not respected. (snemeth: rev 410c605aec308a2ccd903f60aade3aaeefcaa610) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationPriorityACLs.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java > Application priority queue ACLs are not respected > - > > Key: YARN-10247 > URL: https://issues.apache.org/jira/browse/YARN-10247 > Project: Hadoop YARN > Issue Type: Task > Components: capacity scheduler >Reporter: Sunil G >Assignee: Sunil G >Priority: Blocker > Fix For: 3.3.0, 3.4.0 > > Attachments: YARN-10247.0001.patch > > > This is a regression from queue path jira. > App priority acls are not working correctly. > {code:java} > yarn.scheduler.capacity.root.B.acl_application_max_priority=[user=john > group=users max_priority=4] > {code} > max_priority enforcement is not working. For user john, maximum supported > priority is 4. However I can submit like priority 6 for this user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095476#comment-17095476 ] Szilard Nemeth commented on YARN-10247: --- Thanks [~sunilg] for the patch, latest patch LGTM, committed to trunk. Thanks [~shuzirra] for the quick review. > Application priority queue ACLs are not respected > - > > Key: YARN-10247 > URL: https://issues.apache.org/jira/browse/YARN-10247 > Project: Hadoop YARN > Issue Type: Task > Components: capacity scheduler >Reporter: Sunil G >Assignee: Sunil G >Priority: Blocker > Attachments: YARN-10247.0001.patch > > > This is a regression from queue path jira. > App priority acls are not working correctly. > {code:java} > yarn.scheduler.capacity.root.B.acl_application_max_priority=[user=john > group=users max_priority=4] > {code} > max_priority enforcement is not working. For user john, maximum supported > priority is 4. However I can submit like priority 6 for this user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095368#comment-17095368 ] Gergely Pollak commented on YARN-10247: --- Hi [~sunilg], thank you for the patch, LGTM + 1 (non-binding) The only thing I would change is we use the normalizeQueueName(queuePath) three times in the method, while we don't use the queuePath anymore, so it might be good to create a normalizedQueuePath variable and use it instead this way we would need to normalize only once. I've just noticed it now, I didn't see it when I made the changes to this method, and it is a really minor improvement, since normalisation is quite fast O(1) anyway. > Application priority queue ACLs are not respected > - > > Key: YARN-10247 > URL: https://issues.apache.org/jira/browse/YARN-10247 > Project: Hadoop YARN > Issue Type: Task > Components: capacity scheduler >Reporter: Sunil G >Assignee: Sunil G >Priority: Blocker > Attachments: YARN-10247.0001.patch > > > This is a regression from queue path jira. > App priority acls are not working correctly. > {code:java} > yarn.scheduler.capacity.root.B.acl_application_max_priority=[user=john > group=users max_priority=4] > {code} > max_priority enforcement is not working. For user john, maximum supported > priority is 4. However I can submit like priority 6 for this user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095107#comment-17095107 ] Brahma Reddy Battula commented on YARN-10247: - [~prabhujoseph] and [~shuzirra] could you help to review this.. Looks straightforwad change. > Application priority queue ACLs are not respected > - > > Key: YARN-10247 > URL: https://issues.apache.org/jira/browse/YARN-10247 > Project: Hadoop YARN > Issue Type: Task > Components: capacity scheduler >Reporter: Sunil G >Assignee: Sunil G >Priority: Blocker > Attachments: YARN-10247.0001.patch > > > This is a regression from queue path jira. > App priority acls are not working correctly. > {code:java} > yarn.scheduler.capacity.root.B.acl_application_max_priority=[user=john > group=users max_priority=4] > {code} > max_priority enforcement is not working. For user john, maximum supported > priority is 4. However I can submit like priority 6 for this user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094506#comment-17094506 ] Hadoop QA commented on YARN-10247: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 25s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 31s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 17m 49s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m 59s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 58s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 34s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 95 unchanged - 0 fixed = 96 total (was 95) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 6s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 95m 21s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}167m 14s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-YARN-Build/25946/artifact/out/Dockerfile | | JIRA Issue | YARN-10247 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13001446/YARN-10247.0001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux dae1af387d59 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 5e0eda5d5f6 | | Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/25946/artifact/out/diff-checkstyle-hadoop-y
[jira] [Commented] (YARN-10247) Application priority queue ACLs are not respected
[ https://issues.apache.org/jira/browse/YARN-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094374#comment-17094374 ] Sunil G commented on YARN-10247: [~shuzirra] [~prabhujoseph] pls help to review this change. > Application priority queue ACLs are not respected > - > > Key: YARN-10247 > URL: https://issues.apache.org/jira/browse/YARN-10247 > Project: Hadoop YARN > Issue Type: Task > Components: capacity scheduler >Reporter: Sunil G >Assignee: Sunil G >Priority: Blocker > Attachments: YARN-10247.0001.patch > > > This is a regression from queue path jira. > App priority acls are not working correctly. > {code:java} > yarn.scheduler.capacity.root.B.acl_application_max_priority=[user=john > group=users max_priority=4] > {code} > max_priority enforcement is not working. For user john, maximum supported > priority is 4. However I can submit like priority 6 for this user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org