[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-12 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134338#comment-17134338 ] Wangda Tan commented on YARN-10293: --- Missed last comments, thanks [~prabhujoseph]/[~Tao Yang]!  >

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134262#comment-17134262 ] Hudson commented on YARN-10293: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18347 (See

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-12 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134257#comment-17134257 ] Prabhu Joseph commented on YARN-10293: -- Thanks [~Tao Yang] and [~wangda]. > Reserved Containers not

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-11 Thread Tao Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133848#comment-17133848 ] Tao Yang commented on YARN-10293: - I think this patch is fine enough, and would like to commit the latest

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-10 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132565#comment-17132565 ] Prabhu Joseph commented on YARN-10293: -- Thanks [~Tao Yang] for the review. [~wangda] Let me know if

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-09 Thread Tao Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129091#comment-17129091 ] Tao Yang commented on YARN-10293: - Thanks [~prabhujoseph] for updating the patch. LGTM now, [~wangda], do

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128340#comment-17128340 ] Hadoop QA commented on YARN-10293: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-08 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128183#comment-17128183 ] Prabhu Joseph commented on YARN-10293: -- [~Tao Yang] Have used SchedulerNode#updateTotalResource to

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-07 Thread Tao Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127867#comment-17127867 ] Tao Yang commented on YARN-10293: - Thanks [~prabhujoseph] for updating the patch. Another concern in UT

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126771#comment-17126771 ] Hadoop QA commented on YARN-10293: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-05 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126655#comment-17126655 ] Prabhu Joseph commented on YARN-10293: -- Thanks [~Tao Yang] for the review. Have addressed below

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-04 Thread Tao Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126407#comment-17126407 ] Tao Yang commented on YARN-10293: - Thanks [~prabhujoseph] for this effort. I'm fine, please go ahead.

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-03 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124807#comment-17124807 ] Prabhu Joseph commented on YARN-10293: -- Thanks [~Tao Yang] for the comments. If you are fine, will

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-02 Thread Tao Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124527#comment-17124527 ] Tao Yang commented on YARN-10293: - Thanks [~wangda] for your confirmation. I think the proposed change

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-02 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124195#comment-17124195 ] Wangda Tan commented on YARN-10293: --- [~Tao Yang], the suggestion totally make sense to me. When we have

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123839#comment-17123839 ] Hadoop QA commented on YARN-10293: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-02 Thread Tao Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123686#comment-17123686 ] Tao Yang commented on YARN-10293: - Hi, [~prabhujoseph], [~wangda] This problem is similar to YARN-9598,

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-02 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123652#comment-17123652 ] Prabhu Joseph commented on YARN-10293: -- Have attached a patch with removing the if condition. Will

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-01 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121419#comment-17121419 ] Wangda Tan commented on YARN-10293: --- [~prabhujoseph], I agree with you, I think the entire {{if}} check

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-06-01 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120982#comment-17120982 ] Prabhu Joseph commented on YARN-10293: -- Thanks [~wangda] for reviewing. The older behavior of

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-05-29 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119866#comment-17119866 ] Wangda Tan commented on YARN-10293: --- [~prabhujoseph],   This looks like a valid bug, but I'm wondering

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-05-29 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119618#comment-17119618 ] Prabhu Joseph commented on YARN-10293: -- [~ztang] [~leftnoteasy] Can you review this Jira when you

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-05-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119616#comment-17119616 ] Hadoop QA commented on YARN-10293: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10293) Reserved Containers not allocated from available space of other nodes in CandidateNodeSet in MultiNodePlacement (YARN-10259)

2020-05-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118750#comment-17118750 ] Hadoop QA commented on YARN-10293: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||