[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-29 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187087#comment-17187087 ] Szilard Nemeth commented on YARN-10373: --- Hi [~shuzirra], Latest patch LGTM, committed to trunk.

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187073#comment-17187073 ] Hadoop QA commented on YARN-10373: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-29 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187014#comment-17187014 ] Szilard Nemeth commented on YARN-10373: --- [~shuzirra] OK, I realized this was obviously failed to

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-29 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186970#comment-17186970 ] Szilard Nemeth commented on YARN-10373: --- Hi [~shuzirra], Latest patch has a compilation error, see

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186964#comment-17186964 ] Hadoop QA commented on YARN-10373: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-29 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186948#comment-17186948 ] Gergely Pollak commented on YARN-10373: --- Fxied the typos and checkstyle issues. For the logging and

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-28 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186660#comment-17186660 ] Szilard Nemeth commented on YARN-10373: --- [~shuzirra] Thanks for working on this, good job! Again, I

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-28 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186652#comment-17186652 ] Szilard Nemeth commented on YARN-10373: --- As [~pbacsko] indicated on YARN-10371, it might be better

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-26 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185165#comment-17185165 ] Peter Bacsko commented on YARN-10373: - {noformat} public static MappingRuleMatcher

[jira] [Commented] (YARN-10373) Create Matchers for CS mapping rules

2020-08-25 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184853#comment-17184853 ] Hadoop QA commented on YARN-10373: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||