[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-09 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192859#comment-17192859 ] Szilard Nemeth commented on YARN-10387: --- Thanks [~pbacsko] for working on this. Latest patch LGTM,

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192845#comment-17192845 ] Hadoop QA commented on YARN-10387: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-09 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192768#comment-17192768 ] Gergely Pollak commented on YARN-10387: --- Thank you [~pbacsko] for the changes, LGTM +1

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192479#comment-17192479 ] Hadoop QA commented on YARN-10387: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-08 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192243#comment-17192243 ] Peter Bacsko commented on YARN-10387: - Thanks for the comments [~shuzirra]. 1) This is 100% valid,

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192210#comment-17192210 ] Hadoop QA commented on YARN-10387: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-08 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192198#comment-17192198 ] Gergely Pollak commented on YARN-10387: --- Hi [~pbacsko] thank you for the patch it's really clean

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-07 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191785#comment-17191785 ] Szilard Nemeth commented on YARN-10387: --- Hi [~pbacsko], Thanks for working on this. 1. Please

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191702#comment-17191702 ] Hadoop QA commented on YARN-10387: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-07 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191615#comment-17191615 ] Peter Bacsko commented on YARN-10387: - Todo: 1. Fix fall-through problem detected by findbugs 2. Add

[jira] [Commented] (YARN-10387) Implement logic which returns MappingRule objects based on mapping rules

2020-09-04 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190824#comment-17190824 ] Hadoop QA commented on YARN-10387: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||