[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230058#comment-17230058 ] Peter Bacsko commented on YARN-10425: - Thanks [~shuzirra], committed to trunk! Thanks [~snemeth],

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230047#comment-17230047 ] Peter Bacsko commented on YARN-10425: - Thanks [~shuzirra] the patch LGTM. +1. [~snemeth] do you have

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229548#comment-17229548 ] Hadoop QA commented on YARN-10425: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229321#comment-17229321 ] Hadoop QA commented on YARN-10425: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229220#comment-17229220 ] Peter Bacsko commented on YARN-10425: - BTW have you created the Jira you mentioned in response #1?

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229219#comment-17229219 ] Peter Bacsko commented on YARN-10425: - "ret represents return value, I think it's quite expressive,

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-10 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229206#comment-17229206 ] Gergely Pollak commented on YARN-10425: --- [~pbacsko] thank you for the feedback. 1) Added some

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-11-03 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225305#comment-17225305 ] Peter Bacsko commented on YARN-10425: - Thanks [~shuzirra] for the update. I have a question regarding

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-30 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223833#comment-17223833 ] Hadoop QA commented on YARN-10425: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-30 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223708#comment-17223708 ] Peter Bacsko commented on YARN-10425: - Thanks for the explanation [~shuzirra], I'll do another round

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-30 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223701#comment-17223701 ] Gergely Pollak commented on YARN-10425: --- Thank you for the review [~pbacsko], [~BilwaST] and

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223045#comment-17223045 ] Hadoop QA commented on YARN-10425: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-29 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222918#comment-17222918 ] Gergely Pollak commented on YARN-10425: --- Patch#4 is about bugfixes again, this time probably all of

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222391#comment-17222391 ] Hadoop QA commented on YARN-10425: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-28 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1777#comment-1777 ] Gergely Pollak commented on YARN-10425: --- Patch#3 is a rebased version and addressing a major issue

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-27 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221619#comment-17221619 ] Wangda Tan commented on YARN-10425: --- Thanks [~shuzirra], this is a really big and important effort :). 

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221489#comment-17221489 ] Hadoop QA commented on YARN-10425: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-27 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221487#comment-17221487 ] Gergely Pollak commented on YARN-10425: --- Reuploading patch#1 as patch#2 as the test results have

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-13 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213135#comment-17213135 ] Szilard Nemeth commented on YARN-10425: --- Hi [~shuzirra], Thanks for working on this. Some

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-09 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210927#comment-17210927 ] Bilwa S T commented on YARN-10425: -- Thanks [~shuzirra] for patch. I have minor nit 1. Why is null check

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-09 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210822#comment-17210822 ] Peter Bacsko commented on YARN-10425: - Thanks for the patch [~shuzirra]. I mostly have minor comments

[jira] [Commented] (YARN-10425) Replace the legacy placement engine in CS with the new one

2020-10-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210233#comment-17210233 ] Hadoop QA commented on YARN-10425: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||