[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295422#comment-17295422
]
Peter Bacsko commented on YARN-10532:
-
+1
Thanks [~zhuqi] for the patch and [~gandras] and [~bteke]
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295082#comment-17295082
]
Hadoop QA commented on YARN-10532:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294951#comment-17294951
]
Qi Zhu commented on YARN-10532:
---
Thanks [~gandras] for last confirm.
[~pbacsko] [~snemeth]
If you can
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293564#comment-17293564
]
Andras Gyori commented on YARN-10532:
-
You are right [~zhuqi], sorry. Thank you for fixing my
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293351#comment-17293351
]
Hadoop QA commented on YARN-10532:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293299#comment-17293299
]
Qi Zhu commented on YARN-10532:
---
Thanks [~bteke] for final check.
[~pbacsko] I have fixed it in latest
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293113#comment-17293113
]
Peter Bacsko commented on YARN-10532:
-
[~zhuqi] please fix the things that [~bteke] mentioned and I
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293075#comment-17293075
]
Hadoop QA commented on YARN-10532:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293008#comment-17293008
]
Benjamin Teke commented on YARN-10532:
--
[~zhuqi],
Thanks for the patch. Generally looks good to me,
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292953#comment-17292953
]
Qi Zhu commented on YARN-10532:
---
Thanks a lot [~gandras] for final check.
The yarn.scheduler.capacity in
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292912#comment-17292912
]
Andras Gyori commented on YARN-10532:
-
Hi [~zhuqi]. I have some final addition on the contribution
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292016#comment-17292016
]
Qi Zhu commented on YARN-10532:
---
Thanks [~pbacsko] for patient review.:D
Waiting for [~gandras]
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291889#comment-17291889
]
Peter Bacsko commented on YARN-10532:
-
[~zhuqi] I think it's very good now. Maybe I'll check another
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291515#comment-17291515
]
Qi Zhu commented on YARN-10532:
---
[~pbacsko] [~gandras]
The test is not related, if you have any other
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291497#comment-17291497
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291413#comment-17291413
]
Qi Zhu commented on YARN-10532:
---
Fixed checkstyle in latest patch.
> Capacity Scheduler Auto Queue
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290868#comment-17290868
]
Hadoop QA commented on YARN-10532:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290779#comment-17290779
]
Qi Zhu commented on YARN-10532:
---
Fixed check style in latest patch.:D
> Capacity Scheduler Auto Queue
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290712#comment-17290712
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290651#comment-17290651
]
Qi Zhu commented on YARN-10532:
---
Thanks [~pbacsko] for hard work review, i am appreciate with your valid
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289968#comment-17289968
]
Peter Bacsko commented on YARN-10532:
-
FIRST round review.
I might post more but these are that
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285373#comment-17285373
]
Hadoop QA commented on YARN-10532:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285256#comment-17285256
]
Qi Zhu commented on YARN-10532:
---
[~gandras] [~bteke] [~snemeth]
I have added a log for sending a deletion
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284706#comment-17284706
]
Qi Zhu commented on YARN-10532:
---
Thanks [~gandras] for your patient review and valid suggestions, i will
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284614#comment-17284614
]
Andras Gyori commented on YARN-10532:
-
Thank you [~zhuqi], the latest patch looks good to me. If
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283691#comment-17283691
]
Qi Zhu commented on YARN-10532:
---
!image-2021-02-12-21-32-02-267.png|width=1085,height=764!
cc [~gandras]
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281032#comment-17281032
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280899#comment-17280899
]
Qi Zhu commented on YARN-10532:
---
[~gandras]
I have updated it in testAutoCreateQueueAfterRemoval in latest
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280855#comment-17280855
]
Qi Zhu commented on YARN-10532:
---
Thanks a lot [~gandras] for your patient review.
You are right, after the
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280838#comment-17280838
]
Andras Gyori commented on YARN-10532:
-
Thank you [~zhuqi] for the latest patch, it looks good to me!
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280250#comment-17280250
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280215#comment-17280215
]
Qi Zhu commented on YARN-10532:
---
Fix the checkstyle in latest patch.
> Capacity Scheduler Auto Queue
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280104#comment-17280104
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280066#comment-17280066
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280065#comment-17280065
]
Qi Zhu commented on YARN-10532:
---
Thanks a lot [~gandras] for patient review.
In latest patch, I have fixed
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279769#comment-17279769
]
Andras Gyori commented on YARN-10532:
-
Hi [~zhuqi] and thanks for addressing the feedbacks. I have
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279677#comment-17279677
]
Hadoop QA commented on YARN-10532:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279521#comment-17279521
]
Qi Zhu commented on YARN-10532:
---
[~gandras]
The test error is not related to this jira.
Fixed check style
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279498#comment-17279498
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279370#comment-17279370
]
Qi Zhu commented on YARN-10532:
---
Thanks for [~gandras] valid suggestions!
I have updated a new patch.
1.
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278616#comment-17278616
]
Andras Gyori commented on YARN-10532:
-
Thank you [~zhuqi] for taking the time and fixing the
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278226#comment-17278226
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278029#comment-17278029
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277852#comment-17277852
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277789#comment-17277789
]
Qi Zhu commented on YARN-10532:
---
Fixed the java doc, finding bugs, and check style in latest patch.
>
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277713#comment-17277713
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277660#comment-17277660
]
Qi Zhu commented on YARN-10532:
---
Thanks for [~gandras] patient review.
I have fixed the above.
But the
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277186#comment-17277186
]
Andras Gyori commented on YARN-10532:
-
Thank you [~zhuqi] for the new patch. My additions are:
* use
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277166#comment-17277166
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277015#comment-17277015
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276902#comment-17276902
]
zhuqi commented on YARN-10532:
--
[~wangda] [~gandras]
Attached a new patch for review.
Thanks.
> Capacity
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276811#comment-17276811
]
zhuqi commented on YARN-10532:
--
Thanks a lot for [~gandras] patient review, it make sense to me.
# I used
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276450#comment-17276450
]
Andras Gyori commented on YARN-10532:
-
Hi [~zhuqi], thank you for the patch! I have analysed the
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275871#comment-17275871
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275832#comment-17275832
]
zhuqi commented on YARN-10532:
--
[~wangda] [~gandras]
I have updated a new patch to make the code more
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273287#comment-17273287
]
zhuqi commented on YARN-10532:
--
[~gandras]
Thanks for your review and valid suggestions.
It makes sense:
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272968#comment-17272968
]
Andras Gyori commented on YARN-10532:
-
Thank you [~zhuqi] for the patch. I have come up with several
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267736#comment-17267736
]
zhuqi commented on YARN-10532:
--
[~wangda] [~gandras]
Now it can be reviewed.
Another question is :
It
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267733#comment-17267733
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267623#comment-17267623
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267620#comment-17267620
]
zhuqi commented on YARN-10532:
--
Fix the test case in patch 006.
When policy edit is not finished, may get
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267415#comment-17267415
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267207#comment-17267207
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267111#comment-17267111
]
zhuqi commented on YARN-10532:
--
The latest patch, double check the
"An additional requirement we should
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267070#comment-17267070
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267022#comment-17267022
]
zhuqi commented on YARN-10532:
--
The latest patch support:
For old auto created leaf queue deletion:
1.
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266570#comment-17266570
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266529#comment-17266529
]
zhuqi commented on YARN-10532:
--
[~wangda] [~gandras]
I add a draft poc patch for 1, 2, 3 above.
I will
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266391#comment-17266391
]
Wangda Tan commented on YARN-10532:
---
[~zhuqi], thanks for the patch, I took a brief look (nothing in
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264189#comment-17264189
]
zhuqi commented on YARN-10532:
--
[~gandras]
In original auto created leaf queue, there are policy
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264160#comment-17264160
]
Andras Gyori commented on YARN-10532:
-
Thanks [~zhuqi] for the heads-up. I think this should be
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261718#comment-17261718
]
zhuqi commented on YARN-10532:
--
[~wangda] [~gandras]
The patch is based original capacity auto creation,
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249653#comment-17249653
]
Hadoop QA commented on YARN-10532:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249512#comment-17249512
]
zhuqi commented on YARN-10532:
--
[~wangda]
I want to take it , if no one to take.
Thanks.:)
> Capacity
74 matches
Mail list logo