[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343250#comment-17343250
]
Peter Bacsko commented on YARN-10571:
-
Thanks [~gandras], committed to trunk.
> Refactor dynamic
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343227#comment-17343227
]
Peter Bacsko commented on YARN-10571:
-
+1 LGTM
> Refactor dynamic queue handling logic
>
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342635#comment-17342635
]
Andras Gyori commented on YARN-10571:
-
The test is probably not related, I have managed to pass it
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342462#comment-17342462
]
Peter Bacsko commented on YARN-10571:
-
Finally, no javac issues!
[~gandras] please check the test
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342433#comment-17342433
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339150#comment-17339150
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338288#comment-17338288
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335845#comment-17335845
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334763#comment-17334763
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334675#comment-17334675
]
Andras Gyori commented on YARN-10571:
-
Thank you [~pbacsko]. I have no idea what is going on, but I
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334674#comment-17334674
]
Peter Bacsko commented on YARN-10571:
-
Thanks [~gandras] for the patch. Do you know what's going on
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334608#comment-17334608
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17333247#comment-17333247
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17333200#comment-17333200
]
Andras Gyori commented on YARN-10571:
-
Rebased on recent trunk.
> Refactor dynamic queue handling
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308393#comment-17308393
]
Qi Zhu commented on YARN-10571:
---
Thanks [~gandras] for update, LGTM +1 (Non-binding).
> Refactor dynamic
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307805#comment-17307805
]
Gergely Pollak commented on YARN-10571:
---
[~gandras] thank you for the update, patch 2 LGTM+1
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299567#comment-17299567
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299562#comment-17299562
]
Andras Gyori commented on YARN-10571:
-
Thank you [~pbacsko], [~shuzirra], [~zhuqi] for the reviews.
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299260#comment-17299260
]
Gergely Pollak commented on YARN-10571:
---
It's in the original code as well, but we can have a NPE
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298867#comment-17298867
]
Qi Zhu commented on YARN-10571:
---
Thanks [~gandras] for the patch.
LGTM, just fix the Javadoc and the
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298861#comment-17298861
]
Peter Bacsko commented on YARN-10571:
-
[~gandras] thanks for the patch.
I just have one question:
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295262#comment-17295262
]
Hadoop QA commented on YARN-10571:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295123#comment-17295123
]
Andras Gyori commented on YARN-10571:
-
This refactor intends to address two issues with the current
23 matches
Mail list logo
