[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331141#comment-17331141 ] Qi Zhu commented on YARN-10743: --- Thanks [~Jim_Brennan] for commit. I created a following Jira  YARN-10751 

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330998#comment-17330998 ] Jim Brennan commented on YARN-10743: [~zhuqi] thanks for updating the patch. I agree it would be

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330973#comment-17330973 ] Hadoop QA commented on YARN-10743: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330871#comment-17330871 ] Qi Zhu commented on YARN-10743: --- Thanks [~Jim_Brennan] for review. Fixed checkstyle and add document in 

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330834#comment-17330834 ] Jim Brennan commented on YARN-10743: Thanks for the patch [~zhuqi]! The code looks good to me. Can

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330372#comment-17330372 ] Hadoop QA commented on YARN-10743: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-23 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330225#comment-17330225 ] Qi Zhu commented on YARN-10743: --- Thanks [~ebadger] [~Jim_Brennan]  for confirm. Updated the patch for

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-20 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326052#comment-17326052 ] Jim Brennan commented on YARN-10743: [~ebadger] I was going to say the same thing. I'm ok with this

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-20 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326048#comment-17326048 ] Eric Badger commented on YARN-10743: I don't really have a big issue with adding this as an option

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-19 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325432#comment-17325432 ] Qi Zhu commented on YARN-10743: --- Thanks [~ebadger] for reply. One case in our cluster : If the container

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-19 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325343#comment-17325343 ] Eric Badger commented on YARN-10743: I have the same concern as [~Jim_Brennan]. If the flink logs are

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325112#comment-17325112 ] Hadoop QA commented on YARN-10743: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-19 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325109#comment-17325109 ] Qi Zhu commented on YARN-10743: --- Thanks [~Jim_Brennan] for reply. But in our cluster, some flink log size

[jira] [Commented] (YARN-10743) Add a policy for not aggregating for containers which are killed because exceeding container log size limit.

2021-04-19 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325102#comment-17325102 ] Jim Brennan commented on YARN-10743: I don't think this is necessary. The logs may actually be