[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385635#comment-17385635
]
Eric Badger commented on YARN-10860:
Thanks, [~zhuqi]!
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Fix For: 3.4.0, 2.10.2, 3.2.3, 3.3.2
>
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385195#comment-17385195
]
Qi Zhu commented on YARN-10860:
---
Thanks [~ebadger] for reminder.:)
I have cherry-picked back to the other active 3.x branches, which are
branch-3.3 and branch-3.2.
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Fix For: 3.4.0, 2.10.2, 3.2.3, 3.3.2
>
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385024#comment-17385024
]
Eric Badger commented on YARN-10860:
[~zhuqi], thanks for the review and commit! And thanks [~gandras] for the
additional review. Just a reminder that when committing patches you should
attempt to cherry-pick them as far back as you can unless they are risky and/or
unstable. In this case you committed patches to trunk (3.4) and branch-2.10.
However, the trunk patch should also be cherry-picked back to the other active
3.x branches, which are branch-3.3 and branch-3.2. Could you please cherry-pick
the trunk patch to those 2 branches? Thanks!
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Fix For: 3.4.0, 2.10.2
>
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384715#comment-17384715
]
Qi Zhu commented on YARN-10860:
---
Thanks [~ebadger] for patch and [~gandras] for review.
Committed to trunk and 2.10.
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Fix For: 3.4.0, 2.10.2
>
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384697#comment-17384697
]
Andras Gyori commented on YARN-10860:
-
Thanks [~ebadger] for the patch. It is straightforward. +1 non-binding.
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384603#comment-17384603
]
Qi Zhu commented on YARN-10860:
---
LGTM , if [~gandras] other comments.
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384560#comment-17384560
]
Hadoop QA commented on YARN-10860:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:blue}0{color} | {color:blue} markdownlint {color} | {color:blue} 0m
1s{color} | {color:blue}{color} | {color:blue} markdownlint was not available.
{color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
44s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
28s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
21s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
9s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
41s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
54s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
17m 8s{color} | {color:green}{color} | {color:green} branch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
37s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
35s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 23m
0s{color} | {color:blue}{color} | {color:blue} Both FindBugs and SpotBugs are
enabled, using SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
38s{color} | {color:blue}{color} | {color:blue}
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file
(spotbugsXml.xml) {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
7s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
46s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m
46s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
10s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m
10s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
44s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} |
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384499#comment-17384499
]
Hadoop QA commented on YARN-10860:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m
38s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:blue}0{color} | {color:blue} markdownlint {color} | {color:blue} 0m
0s{color} | {color:blue}{color} | {color:blue} markdownlint was not available.
{color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. {color} |
|| || || || {color:brown} branch-2.10 Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
21s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
21s{color} | {color:green}{color} | {color:green} branch-2.10 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
10s{color} | {color:green}{color} | {color:green} branch-2.10 passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
8s{color} | {color:green}{color} | {color:green} branch-2.10 passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
0s{color} | {color:green}{color} | {color:green} branch-2.10 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
34s{color} | {color:green}{color} | {color:green} branch-2.10 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green}{color} | {color:green} branch-2.10 passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green}{color} | {color:green} branch-2.10 passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 7m
43s{color} | {color:blue}{color} | {color:blue} Both FindBugs and SpotBugs are
enabled, using SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
34s{color} | {color:blue}{color} | {color:blue}
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file
(spotbugsXml.xml) {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
36s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
36s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
3s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
3s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
25s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch has no whitespace
issues. {color} |
| {color:green}+1{color} |
[jira] [Commented] (YARN-10860) Make max container per heartbeat configs refreshable
[
https://issues.apache.org/jira/browse/YARN-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383789#comment-17383789
]
Qi Zhu commented on YARN-10860:
---
Thanks [~ebadger] for filling this.
I totally agree with you that these should be refreshable.
> Make max container per heartbeat configs refreshable
>
>
> Key: YARN-10860
> URL: https://issues.apache.org/jira/browse/YARN-10860
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Badger
>Assignee: Eric Badger
>Priority: Major
> Attachments: YARN-10860.001.patch, YARN-10860.branch-2.10.001.patch
>
>
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-container-assignments}}
> and
> {{yarn.scheduler.capacity.per-node-heartbeat.multiple-assignments-enabled}}
> are currently *not* refreshable configs, but I believe they should be. This
> JIRA is to turn these into refreshable configs, just like
> {{yarn.scheduler.capacity.per-node-heartbeat.maximum-offswitch-assignments}}
> is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
