[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13786155#comment-13786155 ] Junping Du commented on YARN-1225: -- Hi [~vinodkv], would you help to review the patch here? I guess any protocol changes should be best to happen before branch-2 GA. Isn't it? The test failure on TestDistributedShell seems to be unrelated (also appear on previous JIRA like YARN-49). Thanks! FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Components: api Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du Attachments: YARN-1225-kickOffTestDS.patch, YARN-1225-v1.patch, YARN-1225-v2.patch, YARN-1225-v3.patch AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[
https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13786887#comment-13786887
]
Hadoop QA commented on YARN-1225:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12606956/YARN-1225-v4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.mapreduce.v2.app.local.TestLocalContainerAllocator
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2114//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2114//console
This message is automatically generated.
FinishApplicationMasterRequest should also have a final IPC/RPC address.
Key: YARN-1225
URL: https://issues.apache.org/jira/browse/YARN-1225
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Vinod Kumar Vavilapalli
Assignee: Junping Du
Attachments: YARN-1225-kickOffTestDS.patch, YARN-1225-v1.patch,
YARN-1225-v2.patch, YARN-1225-v3.patch, YARN-1225-v4.patch
AMs already can report final Http URL via FinishApplicationMasterRequest, but
there is no field to report an IPC/RPC address.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781283#comment-13781283 ] Vinod Kumar Vavilapalli commented on YARN-1225: --- Yup, makes sense. Please add a new API in there. Given beta is out, we are trying to avoid any breakage in compatibility. In any case, this is optional, so new API in FinishApplicationMasterRequest is the way to go. FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781404#comment-13781404 ] Junping Du commented on YARN-1225: -- Thanks [~vinodkv] for quick response. Attach the first patch which add two optional fields (host and rpcPort) there. Not sure if setting stable tag here is correct or Evolving should be a starter for an API? FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du Attachments: YARN-1225-v1.patch AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[
https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781411#comment-13781411
]
Hadoop QA commented on YARN-1225:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12605793/YARN-1225-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2036//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/2036//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2036//console
This message is automatically generated.
FinishApplicationMasterRequest should also have a final IPC/RPC address.
Key: YARN-1225
URL: https://issues.apache.org/jira/browse/YARN-1225
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Vinod Kumar Vavilapalli
Assignee: Junping Du
Attachments: YARN-1225-v1.patch
AMs already can report final Http URL via FinishApplicationMasterRequest, but
there is no field to report an IPC/RPC address.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781422#comment-13781422 ] Junping Du commented on YARN-1225: -- - javadoc issue is fixed in v2 patch - findbug issue is unrelated, I guess we may fix it in some other JIRA rather than fixing here - test failure on TestDistributedShell cannot be reproduced in local, looks like it is unrelated and submit the patch again. FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Components: api Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du Attachments: YARN-1225-v1.patch, YARN-1225-v2.patch AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[
https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781439#comment-13781439
]
Hadoop QA commented on YARN-1225:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12605806/YARN-1225-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2037//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/2037//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2037//console
This message is automatically generated.
FinishApplicationMasterRequest should also have a final IPC/RPC address.
Key: YARN-1225
URL: https://issues.apache.org/jira/browse/YARN-1225
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Vinod Kumar Vavilapalli
Assignee: Junping Du
Attachments: YARN-1225-v1.patch, YARN-1225-v2.patch
AMs already can report final Http URL via FinishApplicationMasterRequest, but
there is no field to report an IPC/RPC address.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[
https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781553#comment-13781553
]
Hadoop QA commented on YARN-1225:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12605844/YARN-1225-v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2038//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/2038//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2038//console
This message is automatically generated.
FinishApplicationMasterRequest should also have a final IPC/RPC address.
Key: YARN-1225
URL: https://issues.apache.org/jira/browse/YARN-1225
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Vinod Kumar Vavilapalli
Assignee: Junping Du
Attachments: YARN-1225-v1.patch, YARN-1225-v2.patch,
YARN-1225-v3.patch
AMs already can report final Http URL via FinishApplicationMasterRequest, but
there is no field to report an IPC/RPC address.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781559#comment-13781559 ] Junping Du commented on YARN-1225: -- For test failure in TestDistributedShell, given I cannot reproduce the failure locally, I will kick off a simple test patch for Jenkins to run. If also the same test failure which means this is a bug on existing trunk, then we should file a separated JIRA to track rather than fixing here. Make sense? FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Components: api Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du Attachments: YARN-1225-v1.patch, YARN-1225-v2.patch, YARN-1225-v3.patch AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781561#comment-13781561 ] Junping Du commented on YARN-1225: -- Just upload YARN-1225-kickOffTestDS.patch. FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Components: api Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du Attachments: YARN-1225-kickOffTestDS.patch, YARN-1225-v1.patch, YARN-1225-v2.patch, YARN-1225-v3.patch AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[
https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781565#comment-13781565
]
Hadoop QA commented on YARN-1225:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12605846/YARN-1225-kickOffTestDS.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell:
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2039//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2039//console
This message is automatically generated.
FinishApplicationMasterRequest should also have a final IPC/RPC address.
Key: YARN-1225
URL: https://issues.apache.org/jira/browse/YARN-1225
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Vinod Kumar Vavilapalli
Assignee: Junping Du
Attachments: YARN-1225-kickOffTestDS.patch, YARN-1225-v1.patch,
YARN-1225-v2.patch, YARN-1225-v3.patch
AMs already can report final Http URL via FinishApplicationMasterRequest, but
there is no field to report an IPC/RPC address.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781570#comment-13781570 ] Junping Du commented on YARN-1225: -- It is pretty clear that previous TestDistributedShell failure is unrelated, already filed YARN-1251 to track this. So I think v3 patch is ready for review. FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Components: api Reporter: Vinod Kumar Vavilapalli Assignee: Junping Du Attachments: YARN-1225-kickOffTestDS.patch, YARN-1225-v1.patch, YARN-1225-v2.patch, YARN-1225-v3.patch AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1225) FinishApplicationMasterRequest should also have a final IPC/RPC address.
[ https://issues.apache.org/jira/browse/YARN-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13780513#comment-13780513 ] Junping Du commented on YARN-1225: -- Nice catch, Vinod! I would like to work on it and the plan is to add host and rpc port field in FinishApplicationMasterRequest (like RegisterApplicationMasterRequest). How does it sounds like? FinishApplicationMasterRequest should also have a final IPC/RPC address. Key: YARN-1225 URL: https://issues.apache.org/jira/browse/YARN-1225 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli AMs already can report final Http URL via FinishApplicationMasterRequest, but there is no field to report an IPC/RPC address. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
