[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-25 Thread Sandy Ryza (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911797#comment-13911797
 ] 

Sandy Ryza commented on YARN-1760:
--

+1

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch, yarn-1760-3.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Sandy Ryza (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910944#comment-13910944
 ] 

Sandy Ryza commented on YARN-1760:
--

A couple nits:
* The same configuration is used for all the tests.  If the goal is to only use 
the capacity scheduler for a couple tests, then it should be instantiated in 
setup()
{code}
+configuration.set(YarnConfiguration.RM_SCHEDULER,
+
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler);
{code}
It looks like this goes over 80 characters.  Also, probably better to use 
CapacityScheduler.class.getName().

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910984#comment-13910984
 ] 

Hadoop QA commented on YARN-1760:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12630822/yarn-1760-1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3170//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3170//console

This message is automatically generated.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911034#comment-13911034
 ] 

Hadoop QA commented on YARN-1760:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12630834/yarn-1760-2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3171//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3171//console

This message is automatically generated.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Sandy Ryza (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911038#comment-13911038
 ] 

Sandy Ryza commented on YARN-1760:
--

Thanks. One more thing: Configuration.addDefaultResource is a static method 
that applies to all configurations.  So it should either go in setup or the 
non-static configuration.addResource should be used. 

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Vinod Kumar Vavilapalli (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911086#comment-13911086
 ] 

Vinod Kumar Vavilapalli commented on YARN-1760:
---

If you agree, then we can close this as invalid..

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Vinod Kumar Vavilapalli (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911085#comment-13911085
 ] 

Vinod Kumar Vavilapalli commented on YARN-1760:
---

Wait, from what I understand, Xuan will have a similar FairScheduler test via 
YARN-1679. That test explicitly was for CapacityScheduler, we will very likely 
rename it at YARN-1679.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Sandy Ryza (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911094#comment-13911094
 ] 

Sandy Ryza commented on YARN-1760:
--

The goal here is just to make the use of the Capacity Scheduler in the existing 
tests explicit, so that they will pass on distros that set other schedulers as 
default.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Vinod Kumar Vavilapalli (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911100#comment-13911100
 ] 

Vinod Kumar Vavilapalli commented on YARN-1760:
---

I have seen other JIRAs like this and I think I understand the goal. But I 
don't see this JIRA adding any value once YARN-1679 adds a fair-scheduler 
specific test in the same class.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Sandy Ryza (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911102#comment-13911102
 ] 

Sandy Ryza commented on YARN-1760:
--

I assume that YARN-1679 will have 
conf.setClass(YarnConfiguration.RM_SCHEDULER_CLASS, FairScheduler.class) in 
the FS-specific tests that it adds.  This JIRA adds the same to the CS-specific 
tests.  In some other JIRAs, I've tried to make it so that certain tests pass 
independent of whether the Fair or Capacity scheduler is used. But the goal 
with this patch is just to make the dependency of the existing tests on the 
Capacity Scheduler explicit so that it will override a non-CS default.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Vinod Kumar Vavilapalli (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911130#comment-13911130
 ] 

Vinod Kumar Vavilapalli commented on YARN-1760:
---

hm.. okay.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1760) TestRMAdminService assumes the use of CapacityScheduler

2014-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911229#comment-13911229
 ] 

Hadoop QA commented on YARN-1760:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12630878/yarn-1760-3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3174//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3174//console

This message is automatically generated.

 TestRMAdminService assumes the use of CapacityScheduler
 ---

 Key: YARN-1760
 URL: https://issues.apache.org/jira/browse/YARN-1760
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Trivial
  Labels: test
 Attachments: yarn-1760-1.patch, yarn-1760-2.patch, yarn-1760-3.patch


 YARN-1611 adds TestRMAdminService which assumes the use of CapacityScheduler. 
 {noformat}
 java.lang.ClassCastException: 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler 
 cannot be cast to 
 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testAdminRefreshQueuesWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:115)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)