[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020017#comment-14020017 ] Tsuyoshi OZAWA commented on YARN-1874: -- Thanks for your suggestion, Karthik. YARN-2130 is filed to address RMContext-related change. I'll plan to split a latest patches into 2 patches: 1. Moving RMActiveServices into its own file, 2. Adding getRMAppManager, getQueueACLsManager, getApplicationACLsManager to RMContext. Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch, YARN-1874.4.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019558#comment-14019558 ] Karthik Kambatla commented on YARN-1874: Barely skimmed through the patch, changes look reasonable. However, it would be easier if we could split this into smaller patches. At the least, RMContext related parts could be done in a separate JIRA first. Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch, YARN-1874.4.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018310#comment-14018310 ] Tsuyoshi OZAWA commented on YARN-1874: -- [~kkambatl], could you take a look? Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch, YARN-1874.4.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015228#comment-14015228 ] Tsuyoshi OZAWA commented on YARN-1874: -- I found that the test failure is not related to a patch - it's filed on YARN-2075. Resubmitted a patch without updating. Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch, YARN-1874.4.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[
https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015453#comment-14015453
]
Hadoop QA commented on YARN-1874:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647902/YARN-1874.4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 20 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.client.TestRMAdminCLI
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3886//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3886//console
This message is automatically generated.
Cleanup: Move RMActiveServices out of ResourceManager into its own file
---
Key: YARN-1874
URL: https://issues.apache.org/jira/browse/YARN-1874
Project: Hadoop YARN
Issue Type: Improvement
Components: resourcemanager
Reporter: Karthik Kambatla
Assignee: Tsuyoshi OZAWA
Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch,
YARN-1874.4.patch
As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We
should move RMActiveServices out to make it more manageable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[
https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015588#comment-14015588
]
Tsuyoshi OZAWA commented on YARN-1874:
--
It's ready for review. This patch includes following changes:
1. Moved RMActiveServices out of ResourceManager into its own file.
2. Added {{getRMAppManager}}, {{getQueueACLsManager}},
{{getApplicationACLsManager}} to RMContext.
3. Changed tests to override {{ResourceManager#createAndInitActiveServices}}
method.
Cleanup: Move RMActiveServices out of ResourceManager into its own file
---
Key: YARN-1874
URL: https://issues.apache.org/jira/browse/YARN-1874
Project: Hadoop YARN
Issue Type: Improvement
Components: resourcemanager
Reporter: Karthik Kambatla
Assignee: Tsuyoshi OZAWA
Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch,
YARN-1874.4.patch
As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We
should move RMActiveServices out to make it more manageable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[
https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990806#comment-13990806
]
Hadoop QA commented on YARN-1874:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12643560/YARN-1874.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 20 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3700//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3700//console
This message is automatically generated.
Cleanup: Move RMActiveServices out of ResourceManager into its own file
---
Key: YARN-1874
URL: https://issues.apache.org/jira/browse/YARN-1874
Project: Hadoop YARN
Issue Type: Improvement
Components: resourcemanager
Reporter: Karthik Kambatla
Assignee: Tsuyoshi OZAWA
Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch
As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We
should move RMActiveServices out to make it more manageable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990851#comment-13990851 ] Tsuyoshi OZAWA commented on YARN-1874: -- I'll be back on this issue after YARN-1474. Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch, YARN-1874.2.patch, YARN-1874.3.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13987767#comment-13987767 ] Tsuyoshi OZAWA commented on YARN-1874: -- I'll fix the patch to pass tests. Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[ https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950167#comment-13950167 ] Tsuyoshi OZAWA commented on YARN-1874: -- Maybe should we do this after YARN-1474? Cleanup: Move RMActiveServices out of ResourceManager into its own file --- Key: YARN-1874 URL: https://issues.apache.org/jira/browse/YARN-1874 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: Karthik Kambatla Assignee: Tsuyoshi OZAWA Attachments: YARN-1874.1.patch As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We should move RMActiveServices out to make it more manageable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1874) Cleanup: Move RMActiveServices out of ResourceManager into its own file
[
https://issues.apache.org/jira/browse/YARN-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950226#comment-13950226
]
Hadoop QA commented on YARN-1874:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12637290/YARN-1874.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 1490 javac
compiler warnings (more than the trunk's current 1489 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster
org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator
org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens
org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
org.apache.hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerUtils
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3478//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3478//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3478//console
This message is automatically generated.
Cleanup: Move RMActiveServices out of ResourceManager into its own file
---
Key: YARN-1874
URL: https://issues.apache.org/jira/browse/YARN-1874
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Reporter: Karthik Kambatla
Assignee: Tsuyoshi OZAWA
Attachments: YARN-1874.1.patch
As [~vinodkv] noticed on YARN-1867, ResourceManager is hard to maintain. We
should move RMActiveServices out to make it more manageable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
