[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-07-01 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049566#comment-14049566 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- bq. Talked with Vinod

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1404#comment-1404 ] Hudson commented on YARN-2074: -- FAILURE: Integrated in Hadoop-Yarn-trunk #594 (See

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043501#comment-14043501 ] Hudson commented on YARN-2074: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1785 (See

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043684#comment-14043684 ] Hudson commented on YARN-2074: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1812 (See

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-24 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042223#comment-14042223 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- This looks good, +1.

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042253#comment-14042253 ] Hudson commented on YARN-2074: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5761 (See

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-19 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038169#comment-14038169 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- Also

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-19 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038264#comment-14038264 ] Jian He commented on YARN-2074: --- Seem to find a bug in

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038300#comment-14038300 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-17 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033479#comment-14033479 ] Wangda Tan commented on YARN-2074: -- [~jianhe], thanks for your clarification. I think the

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-17 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033496#comment-14033496 ] Jian He commented on YARN-2074: --- Thanks for pointing out RMAppAttemptImpl.isLastAttempt,

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033531#comment-14033531 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033327#comment-14033327 ] Wangda Tan commented on YARN-2074: -- Hi Jian, I've reviewed your patch, one question, Is

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Tsuyoshi OZAWA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1405#comment-1405 ] Tsuyoshi OZAWA commented on YARN-2074: -- {quote} amContainerExitStatus will be set to

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033356#comment-14033356 ] Hadoop QA commented on YARN-2074: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033396#comment-14033396 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033402#comment-14033402 ] Wangda Tan commented on YARN-2074: -- [~jianhe], changes almost LGTM, one comment in test,

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033421#comment-14033421 ] Jian He commented on YARN-2074: --- testPreemptedAMRestartOnRMRestart is doing with multiple

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033423#comment-14033423 ] Jian He commented on YARN-2074: --- sorry, I meant testAMPreemptedNotCountedForAMFailures

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031007#comment-14031007 ] Hadoop QA commented on YARN-2074: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031083#comment-14031083 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-12 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030269#comment-14030269 ] Wangda Tan commented on YARN-2074: -- [~jianhe], I just found this patch is failed to apply

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007851#comment-14007851 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Mayank Bansal (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006459#comment-14006459 ] Mayank Bansal commented on YARN-2074: - Thanks [~jianhe] for the patch. Overall looks

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006525#comment-14006525 ] Jian He commented on YARN-2074: --- Thanks Xuan and Mayank for the review ! bq. maxAppAttempts

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Mayank Bansal (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006735#comment-14006735 ] Mayank Bansal commented on YARN-2074: - +1 LGTM Thanks, Mayank Preemption of AM

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005564#comment-14005564 ] Jian He commented on YARN-2074: --- bq. Use this condition to decide whether this RMAppAttempt

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003892#comment-14003892 ] Jian He commented on YARN-2074: --- I'd like to work on this. Taking this over.. Preemption of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-20 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003960#comment-14003960 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- [~sunilg], Agree that as

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004146#comment-14004146 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-19 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002800#comment-14002800 ] Sunil G commented on YARN-2074: --- Hi Vinod As per the description I understood that the AM