[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202511#comment-14202511
]
Jonathan Eagles commented on YARN-2229:
---
FYI: Filed YARN-2830 to help tez deal with
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132660#comment-14132660
]
Hudson commented on YARN-2229:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #679 (See
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132718#comment-14132718
]
Hudson commented on YARN-2229:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1895 (See
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132757#comment-14132757
]
Hudson commented on YARN-2229:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1870 (See
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132342#comment-14132342
]
Tsuyoshi OZAWA commented on YARN-2229:
--
Thanks for review and suggestions, Jian,
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130838#comment-14130838
]
Jian He commented on YARN-2229:
---
looks good, +1
ContainerId can overflow with RM restart
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129429#comment-14129429
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129528#comment-14129528
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129541#comment-14129541
]
Hadoop QA commented on YARN-2229:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129557#comment-14129557
]
Tsuyoshi OZAWA commented on YARN-2229:
--
The latest v16 patch is ready for review.
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118931#comment-14118931
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098301#comment-14098301
]
Hadoop QA commented on YARN-2229:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098024#comment-14098024
]
Jian He commented on YARN-2229:
---
the latest patch seems not applying on trunk any more. Can
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094957#comment-14094957
]
Tsuyoshi OZAWA commented on YARN-2229:
--
Thanks for your review, Jian. OK, it sounds
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093109#comment-14093109
]
Jian He commented on YARN-2229:
---
patch looks good to me. will commit in a day or two if no
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085855#comment-14085855
]
Hadoop QA commented on YARN-2229:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086174#comment-14086174
]
Tsuyoshi OZAWA commented on YARN-2229:
--
Thanks for the comment, Zhijie. Updated a
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080576#comment-14080576
]
Tsuyoshi OZAWA commented on YARN-2229:
--
Thanks for the comment, Jian and Anubhav. I
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074635#comment-14074635
]
Anubhav Dhoot commented on YARN-2229:
-
We cannot simply add a field and have old code
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073030#comment-14073030
]
Tsuyoshi OZAWA commented on YARN-2229:
--
[~sseth], thanks for your comment.
[~jianhe],
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074063#comment-14074063
]
Jian He commented on YARN-2229:
---
bq. ContainerTokenIdentifier serializes a long
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071853#comment-14071853
]
Tsuyoshi OZAWA commented on YARN-2229:
--
Thanks for the comments, Jian, Zhijie and Sid.
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071859#comment-14071859
]
Tsuyoshi OZAWA commented on YARN-2229:
--
{quote}
I'm not sure it's good to makr a
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072356#comment-14072356
]
Siddharth Seth commented on YARN-2229:
--
[~ozawa] - I was primarily looking at this
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069994#comment-14069994
]
Zhijie Shen commented on YARN-2229:
---
Some additional comments:
0. For those that have
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070501#comment-14070501
]
Jian He commented on YARN-2229:
---
Copied from protobuf guide, changing int32 to int64 seems to
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070541#comment-14070541
]
Zhijie Shen commented on YARN-2229:
---
bq. Copied from protobuf guide, changing int32 to
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065045#comment-14065045
]
Tsuyoshi OZAWA commented on YARN-2229:
--
Created YARN-2312 to address marking getId as
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065942#comment-14065942
]
Tsuyoshi OZAWA commented on YARN-2229:
--
[~jianhe], I appreciate if you can take a
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064440#comment-14064440
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064510#comment-14064510
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064547#comment-14064547
]
Tsuyoshi OZAWA commented on YARN-2229:
--
The compile error is caused by YARN-2219. I'll
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064597#comment-14064597
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064603#comment-14064603
]
Tsuyoshi OZAWA commented on YARN-2229:
--
The test failures looks not related to the
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063096#comment-14063096
]
Jian He commented on YARN-2229:
---
add comments to the new getContainerId method
Epoch#hashCode
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060041#comment-14060041
]
Tsuyoshi OZAWA commented on YARN-2229:
--
The test failure is not related, and javac
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059774#comment-14059774
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058461#comment-14058461
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058550#comment-14058550
]
Hadoop QA commented on YARN-2229:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058760#comment-14058760
]
Tsuyoshi OZAWA commented on YARN-2229:
--
The javac warning is by annotating getId as
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059430#comment-14059430
]
Jian He commented on YARN-2229:
---
Thanks for working on this ! some comments:
- setId(long
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059437#comment-14059437
]
Jian He commented on YARN-2229:
---
please suppress the javac warning also, maybe add suppress
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059575#comment-14059575
]
Jian He commented on YARN-2229:
---
bq. add suppress warning at class header
Or we may actually
[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053779#comment-14053779
]
Tsuyoshi OZAWA commented on YARN-2229:
--
I talked with [~jianhe] offline. We'll change
44 matches
Mail list logo
