[jira] [Commented] (YARN-2775) There is no close method in NMWebServices#getLogs()
[
https://issues.apache.org/jira/browse/YARN-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526366#comment-14526366
]
Tsuyoshi Ozawa commented on YARN-2775:
--
[~skrho], thank you for taking this issue. I agree with that we need to close
files after creating FileInputStream. How about using try-with-resources
statement since now we only supports JDK 7 or later?
http://docs.oracle.com/javase/7/docs/technotes/guides/language/try-with-resources.html
{code}
try (final FileInputStream fis = ContainerLogsUtils.openLogFileForRead(
containerIdStr, logFile, nmContext)) {
} catch () {
}
{code}
There is no close method in NMWebServices#getLogs()
---
Key: YARN-2775
URL: https://issues.apache.org/jira/browse/YARN-2775
Project: Hadoop YARN
Issue Type: Improvement
Components: nodemanager
Reporter: skrho
Priority: Minor
Attachments: YARN-2775_001.patch
If getLogs method is called, fileInputStream object is accumulated in
memory..
Because fileinputStream object is not closed..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2775) There is no close method in NMWebServices#getLogs()
[
https://issues.apache.org/jira/browse/YARN-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525641#comment-14525641
]
Hadoop QA commented on YARN-2775:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 31s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 37s | The applied patch generated 1
new checkstyle issues (total was 7, now 8). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 1m 3s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests | 5m 51s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 41m 47s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-server-nodemanager |
| | Nullcheck of NMWebServices$1.val$fis at line 251 of value previously
dereferenced in
org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebServices$1.write(OutputStream)
At NMWebServices.java:251 of value previously dereferenced in
org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebServices$1.write(OutputStream)
At NMWebServices.java:[line 247] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12678151/YARN-2775_001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e8d0ee5 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/7667/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/7667/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-YARN-Build/7667/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7667/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/7667/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7667/console |
This message was automatically generated.
There is no close method in NMWebServices#getLogs()
---
Key: YARN-2775
URL: https://issues.apache.org/jira/browse/YARN-2775
Project: Hadoop YARN
Issue Type: Improvement
Components: nodemanager
Reporter: skrho
Priority: Minor
Attachments: YARN-2775_001.patch
If getLogs method is called, fileInputStream object is accumulated in
memory..
Because fileinputStream object is not closed..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2775) There is no close method in NMWebServices#getLogs()
[ https://issues.apache.org/jira/browse/YARN-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14194239#comment-14194239 ] skrho commented on YARN-2775: - In oracle document.. Closes this file input stream and releases any system resources associated with the stream. If this stream has an associated channel then the channel is closed as well... If close method is not called, no release system resources associated with the stream.. Related URL : http://docs.oracle.com/javase/8/docs/api/java/io/FileInputStream.html There is no close method in NMWebServices#getLogs() --- Key: YARN-2775 URL: https://issues.apache.org/jira/browse/YARN-2775 Project: Hadoop YARN Issue Type: Improvement Components: nodemanager Reporter: skrho Priority: Minor Attachments: YARN-2775_001.patch If getLogs method is called, fileInputStream object is accumulated in memory.. Because fileinputStream object is not closed.. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2775) There is no close method in NMWebServices#getLogs()
[
https://issues.apache.org/jira/browse/YARN-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14194252#comment-14194252
]
Hadoop QA commented on YARN-2775:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678151/YARN-2775_001.patch
against trunk revision 27715ec.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5696//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/5696//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5696//console
This message is automatically generated.
There is no close method in NMWebServices#getLogs()
---
Key: YARN-2775
URL: https://issues.apache.org/jira/browse/YARN-2775
Project: Hadoop YARN
Issue Type: Improvement
Components: nodemanager
Reporter: skrho
Priority: Minor
Attachments: YARN-2775_001.patch
If getLogs method is called, fileInputStream object is accumulated in
memory..
Because fileinputStream object is not closed..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2775) There is no close method in NMWebServices#getLogs()
[ https://issues.apache.org/jira/browse/YARN-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191411#comment-14191411 ] Ravi Prakash commented on YARN-2775: Hi skrho! Thanks for the contribution. It seems the JAX-RS spec doesn't say anything about either closing or not closing the OutputStream. Have you seen these objects accumulate on the heap? Are you sure they are never reaped? There is no close method in NMWebServices#getLogs() --- Key: YARN-2775 URL: https://issues.apache.org/jira/browse/YARN-2775 Project: Hadoop YARN Issue Type: Improvement Components: nodemanager Reporter: skrho Priority: Minor Attachments: YARN-2775_001.patch If getLogs method is called, fileInputStream object is accumulated in memory.. Because fileinputStream object is not closed.. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
