[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269220#comment-14269220
]
Hudson commented on YARN-2936:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #67 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269247#comment-14269247
]
Hudson commented on YARN-2936:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #801 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269356#comment-14269356
]
Hudson commented on YARN-2936:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1999 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269379#comment-14269379
]
Hudson commented on YARN-2936:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #64 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269414#comment-14269414
]
Hudson commented on YARN-2936:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #68 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269429#comment-14269429
]
Hudson commented on YARN-2936:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2018 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268570#comment-14268570
]
Hudson commented on YARN-2936:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6825 (See
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266925#comment-14266925
]
Varun Saxena commented on YARN-2936:
[~jianhe], sorry couldnt get you. What do you mean
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267098#comment-14267098
]
Varun Saxena commented on YARN-2936:
[~jianhe], changed the test. Kindly review.
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267077#comment-14267077
]
Varun Saxena commented on YARN-2936:
Oh you mean, the newly added test code passes even
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266930#comment-14266930
]
Jian He commented on YARN-2936:
---
sorry for confusion, I meant the core/production code (not
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267153#comment-14267153
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260263#comment-14260263
]
Zhijie Shen commented on YARN-2936:
---
bq. Maybe a simply way is to do this:
If either
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260321#comment-14260321
]
Zhijie Shen commented on YARN-2936:
---
Or to keep simple, for
{code}
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260329#comment-14260329
]
Jian He commented on YARN-2936:
---
bq. Can we do something like
thanks Zhijie ! +1 for this
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260445#comment-14260445
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260463#comment-14260463
]
Jian He commented on YARN-2936:
---
looks good, one nit:
{{builder.getOwner().toString()}}
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260477#comment-14260477
]
Jian He commented on YARN-2936:
---
just one more thing, the newly added test is passing without
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260496#comment-14260496
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260502#comment-14260502
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260519#comment-14260519
]
Varun Saxena commented on YARN-2936:
eclipse:eclipse failing due to some problem in
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260525#comment-14260525
]
Varun Saxena commented on YARN-2936:
eclipse:eclipse passes in my local build
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260568#comment-14260568
]
Jian He commented on YARN-2936:
---
bq. the newly added test is passing without the core change.
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259320#comment-14259320
]
Varun Saxena commented on YARN-2936:
bq. Maybe a simply way is to do this.
Hmm...Sounds
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259342#comment-14259342
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259545#comment-14259545
]
Jian He commented on YARN-2936:
---
thanks, looks good, mind writing a unit test?
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259582#comment-14259582
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259585#comment-14259585
]
Varun Saxena commented on YARN-2936:
Weird. How is it -1 overall when its +1 for
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259245#comment-14259245
]
Jian He commented on YARN-2936:
---
[~varun_saxena], thanks for taking on this !
Maybe a simply
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252139#comment-14252139
]
Hadoop QA commented on YARN-2936:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252213#comment-14252213
]
Varun Saxena commented on YARN-2936:
[~zjshen], [~jianhe], kindly review.
Findbugs to
31 matches
Mail list logo
