[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304943#comment-14304943
]
Hudson commented on YARN-3075:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #828 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304928#comment-14304928
]
Hudson commented on YARN-3075:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #94 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305109#comment-14305109
]
Hudson commented on YARN-3075:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2026 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305136#comment-14305136
]
Hudson commented on YARN-3075:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #91 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305218#comment-14305218
]
Hudson commented on YARN-3075:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #95 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305271#comment-14305271
]
Hudson commented on YARN-3075:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2045 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303656#comment-14303656
]
Wangda Tan commented on YARN-3075:
--
[~varun_saxena],
Patch looks good, +1, will commit it
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303977#comment-14303977
]
Hudson commented on YARN-3075:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #6993 (See
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301923#comment-14301923
]
Wangda Tan commented on YARN-3075:
--
Hi [~varun_saxena],
Overall looks good to me, minor
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302511#comment-14302511
]
Hadoop QA commented on YARN-3075:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302603#comment-14302603
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy], kindly review
Test failures
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302615#comment-14302615
]
Wangda Tan commented on YARN-3075:
--
Rekicked Jenkins.
NodeLabelsManager implementation
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302639#comment-14302639
]
Varun Saxena commented on YARN-3075:
bq. When a node/host has no label, it belongs to a
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302685#comment-14302685
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy], {{TestFSRMStateStore}} failure is
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302683#comment-14302683
]
Hadoop QA commented on YARN-3075:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299173#comment-14299173
]
Hadoop QA commented on YARN-3075:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299180#comment-14299180
]
Hadoop QA commented on YARN-3075:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298069#comment-14298069
]
Wangda Tan commented on YARN-3075:
--
I meant we can add one, it should have :)
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298061#comment-14298061
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy],
bq. If we have node id in each
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298142#comment-14298142
]
Varun Saxena commented on YARN-3075:
Ok...
NodeLabelsManager implementation to
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298141#comment-14298141
]
Varun Saxena commented on YARN-3075:
Ok...
NodeLabelsManager implementation to
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293256#comment-14293256
]
Sunil G commented on YARN-3075:
---
Hi [~varun_saxena]
{noformat}
public MapString, SetNodeId
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293277#comment-14293277
]
Varun Saxena commented on YARN-3075:
bq. It is always better to have 2 methods with
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294389#comment-14294389
]
Wangda Tan commented on YARN-3075:
--
Agree, it's better to have two different APIs instead
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294388#comment-14294388
]
Wangda Tan commented on YARN-3075:
--
bq. Sorry didn't quite get as to what you mean by
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292159#comment-14292159
]
Wangda Tan commented on YARN-3075:
--
bq. Right now, when we getLabelsToNodes we simply
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293090#comment-14293090
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy], for other review comments.
bq. 2)
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292755#comment-14292755
]
Wangda Tan commented on YARN-3075:
--
You're right, I mis-read your test :).
Besides 6), I
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292520#comment-14292520
]
Hadoop QA commented on YARN-3075:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292697#comment-14292697
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy],
bq. This seems not correct to me.
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290247#comment-14290247
]
Wangda Tan commented on YARN-3075:
--
{code}
I had put it inside node.labels != null
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290415#comment-14290415
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy], regarding your comment below.
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289123#comment-14289123
]
Varun Saxena commented on YARN-3075:
bq. 4) In add(remove/replace)NodeToLabels, such
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289130#comment-14289130
]
Varun Saxena commented on YARN-3075:
bq. 2) When op is on a node, as mentioned by
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289062#comment-14289062
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy], thanks for the review. Kindly find
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289432#comment-14289432
]
Sunil G commented on YARN-3075:
---
Hi Varun
{code}
+ removeNodeFromLabels(nodeId,
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289435#comment-14289435
]
Varun Saxena commented on YARN-3075:
bq. I think first call to removeNodeFromLabels can
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289465#comment-14289465
]
Sunil G commented on YARN-3075:
---
Thank you [~varun_saxena] for clarifying.
So as we
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286056#comment-14286056
]
Varun Saxena commented on YARN-3075:
[~leftnoteasy], kindly review
NodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286039#comment-14286039
]
Hadoop QA commented on YARN-3075:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286155#comment-14286155
]
Sunil G commented on YARN-3075:
---
Hi [~varun_saxena]
Thanks for taking this item up..
I have
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286560#comment-14286560
]
Wangda Tan commented on YARN-3075:
--
Varun, Thanks for working on this, and also thanks for
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286927#comment-14286927
]
Varun Saxena commented on YARN-3075:
[~sunilg], thanks for your comments.
bq. same as
[
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286982#comment-14286982
]
Varun Saxena commented on YARN-3075:
bq. Yes you are correct, replaceNodeFromLabels can
44 matches
Mail list logo
