[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555810#comment-14555810
]
Lars Francke commented on YARN-3594:
I don't think an additional test is needed as it should already be covered by
existing tests.
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555964#comment-14555964
]
Junping Du commented on YARN-3594:
--
+1. Patch LGTM. Committing this in.
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556000#comment-14556000
]
Hudson commented on YARN-3594:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7892 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7892/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556083#comment-14556083
]
Hudson commented on YARN-3594:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
* hadoop-yarn-project/CHANGES.txt
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556069#comment-14556069
]
Hudson commented on YARN-3594:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/935/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556188#comment-14556188
]
Hudson commented on YARN-3594:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
* hadoop-yarn-project/CHANGES.txt
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556215#comment-14556215
]
Hudson commented on YARN-3594:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
* hadoop-yarn-project/CHANGES.txt
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556321#comment-14556321
]
Hudson commented on YARN-3594:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
* hadoop-yarn-project/CHANGES.txt
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556286#comment-14556286
]
Hudson commented on YARN-3594:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/])
YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams.
Contributed by Lars Francke. (junping_du: rev
132d909d4a6509af9e63e24cbb719be10006b6cd)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Lars Francke
Priority: Trivial
Labels: newbie
Fix For: 2.8.0
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
[
https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554950#comment-14554950
]
Hadoop QA commented on YARN-3594:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 42s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 32s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 38s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 3s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 6m 31s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 42m 31s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12734617/YARN-3594.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 05e04f3 |
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8046/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8046/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8046/console |
This message was automatically generated.
WintuilsProcessStubExecutor.startStreamReader leaks streams
---
Key: YARN-3594
URL: https://issues.apache.org/jira/browse/YARN-3594
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 3.0.0
Reporter: Steve Loughran
Priority: Trivial
Labels: newbie
Attachments: YARN-3594.1.patch
while looking at the file, my IDE highlights that the thread runnables
started by
{{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams
as they exit.
a java7 try-with-resources would trivially fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
