[jira] [Commented] (YARN-3785) Support for vcores during submitApp in MockRM test class

2015-06-08 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577652#comment-14577652
 ] 

Hadoop QA commented on YARN-3785:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   6m 29s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 4 new or modified test files. |
| {color:green}+1{color} | javac |   7m 34s | There were no new javac warning 
messages. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 46s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 2  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 24s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  50m 22s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  68m 59s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | 
hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12738393/0001-YARN-3785.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 0e80d51 |
| whitespace | 
https://builds.apache.org/job/PreCommit-YARN-Build/8221/artifact/patchprocess/whitespace.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8221/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8221/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8221/console |


This message was automatically generated.

> Support for vcores during submitApp in MockRM test class
> 
>
> Key: YARN-3785
> URL: https://issues.apache.org/jira/browse/YARN-3785
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Reporter: Sunil G
>Assignee: Sunil G
>Priority: Minor
> Attachments: 0001-YARN-3785.patch
>
>
> Currently MockRM#submitApp supports only memory. Adding test cases to support 
> vcores so that DominentResourceCalculator can be tested with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3785) Support for vcores during submitApp in MockRM test class

2015-06-08 Thread Xuan Gong (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577611#comment-14577611
 ] 

Xuan Gong commented on YARN-3785:
-

Thanks for working on this. [~sunilg].
Looks like that we have added a new subApps() method which accept Resource as 
parameter in MockRM, and re-write all other subApps() method by using this new 
subApps() method. 
But I did not see "vcores". I understand that with this patch in the future, if 
we want to support vcores, we have already support Resource as parameter. 
Could you re-name the ticket title a little bit ?

> Support for vcores during submitApp in MockRM test class
> 
>
> Key: YARN-3785
> URL: https://issues.apache.org/jira/browse/YARN-3785
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Reporter: Sunil G
>Assignee: Sunil G
>Priority: Minor
> Attachments: 0001-YARN-3785.patch
>
>
> Currently MockRM#submitApp supports only memory. Adding test cases to support 
> vcores so that DominentResourceCalculator can be tested with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)