[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-07-08 Thread Anubhav Dhoot (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619767#comment-14619767
 ] 

Anubhav Dhoot commented on YARN-3800:
-

Test failure seems unrelated and filed as flaky test in YARN-3342
Checkstyle issue is preexisting (number of parameters  7)

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch, 
 YARN-3800.005.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-07-08 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619761#comment-14619761
 ] 

Hadoop QA commented on YARN-3800:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m 20s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 7 new or modified test files. |
| {color:green}+1{color} | javac |   7m 47s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 48s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 48s | The applied patch generated  1 
new checkstyle issues (total was 55, now 50). |
| {color:green}+1{color} | whitespace |   0m  4s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 22s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 24s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  51m  5s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  89m 37s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | 
hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
 |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12744375/YARN-3800.005.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2e3d83f |
| checkstyle |  
https://builds.apache.org/job/PreCommit-YARN-Build/8466/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8466/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8466/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8466/console |


This message was automatically generated.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch, 
 YARN-3800.005.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-07-08 Thread Carlo Curino (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619550#comment-14619550
 ] 

Carlo Curino commented on YARN-3800:


Patch generally looks good, and I spoke with [~subru] that explained me why you 
are making these changes, and overall makes sense. 

A couple nits and then I am ok to commit this:
1) I think it is nicer to have types in HashMap and TreeMap initializations.
2) In other places you did this change already, but in 
TestRLESparseResourceAllocation  you have a generateAllocation that still 
produces ReservationRequests and then you immediately convert to Resource. 
Probably easier to change generateAllocation

Thanks for the work on this patch.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-30 Thread Anubhav Dhoot (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609174#comment-14609174
 ] 

Anubhav Dhoot commented on YARN-3800:
-

[~kasha] [~jianhe] appreciate your review of this.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598860#comment-14598860
 ] 

Hadoop QA commented on YARN-3800:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m 17s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 7 new or modified test files. |
| {color:green}+1{color} | javac |   7m 38s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 48s | The applied patch generated  1 
new checkstyle issues (total was 54, now 49). |
| {color:green}+1{color} | whitespace |   0m  3s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 25s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |  50m 56s | Tests passed in 
hadoop-yarn-server-resourcemanager. |
| | |  89m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12741412/YARN-3800.004.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 49dfad9 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-YARN-Build/8330/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8330/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8330/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8330/console |


This message was automatically generated.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-23 Thread Anubhav Dhoot (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598647#comment-14598647
 ] 

Anubhav Dhoot commented on YARN-3800:
-

Addressed feedback

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-23 Thread Subru Krishnan (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598612#comment-14598612
 ] 

Subru Krishnan commented on YARN-3800:
--

Thanks [~adhoot] for the updated patch. Overall it looks good, a few minor nits:
   * Can we rename _ReservationUtil_ to _ReservationSystemUtil_ to avoid 
confusion.
   * In _TestInMemoryPlan_, can we use *allocations* instead of *allocs* to 
minimize the diff.
   * In _TestInMemoryReservationAllocation_, we can continue using the previous 
constructor for non-gang allocations as the flag is required only for gang.
   * There is a redundant format change in _TestInMemoryReservationAllocation_ :
bq. -Assert.assertEquals(allocations, rAllocation.getAllocationRequests());
+Assert.assertEquals(allocations,
+rAllocation.getAllocationRequests());

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-22 Thread Subru Krishnan (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596663#comment-14596663
 ] 

Subru Krishnan commented on YARN-3800:
--

Thanks [~adhoot] for the patch. I looked at it  just had a couple of comments:
   1. Can we have _toResource(ReservationRequest request)_ in a Reservation 
utility class rather than in _InMemoryReservationAllocation_
   2. I feel we can update the constructor of _InMemoryReservationAllocation_ 
to take in _MapReservationInterval, Resource_ instead of 
_MapReservationInterval, ReservationRequest_ so that we do the translation 
only once. This should simplify the state in GreedyReservationAgent also.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596957#comment-14596957
 ] 

Hadoop QA commented on YARN-3800:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m  6s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 7 new or modified test files. |
| {color:green}+1{color} | javac |   7m 37s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 47s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 50s | The applied patch generated  7 
new checkstyle issues (total was 55, now 56). |
| {color:green}+1{color} | whitespace |   0m  4s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 27s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  51m  0s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  89m 29s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | 
hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
 |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12741165/YARN-3800.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / fac4e04 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-YARN-Build/8318/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8318/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8318/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8318/console |


This message was automatically generated.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597189#comment-14597189
 ] 

Hadoop QA commented on YARN-3800:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  20m  5s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 7 new or modified test files. |
| {color:green}+1{color} | javac |  10m 39s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  12m  6s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 28s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m  0s | The applied patch generated  1 
new checkstyle issues (total was 54, now 49). |
| {color:green}+1{color} | whitespace |   0m  5s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 58s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 37s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 35s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  45m 33s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  94m 11s | |
\\
\\
|| Reason || Tests ||
| Timed out tests | 
org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
 |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart 
|
|   | 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
 |
|   | 
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12741211/YARN-3800.003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 99271b7 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-YARN-Build/8321/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8321/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8321/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8321/console |


This message was automatically generated.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch, 
 YARN-3800.002.patch, YARN-3800.003.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584888#comment-14584888
 ] 

Hadoop QA commented on YARN-3800:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m  7s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:green}+1{color} | javac |   7m 35s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 42s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 45s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 26s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  50m 46s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  88m 53s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | 
hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12739453/YARN-3800.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / b8341f1 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8245/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8245/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8245/console |


This message was automatically generated.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch, YARN-3800.002.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-13 Thread Anubhav Dhoot
The failure seems unrelated. That test has been failing for a while
On Jun 13, 2015 5:00 PM, Hadoop QA (JIRA) j...@apache.org wrote:


 [
 https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584888#comment-14584888
 ]

 Hadoop QA commented on YARN-3800:
 -

 \\
 \\
 | (x) *{color:red}-1 overall{color}* |
 \\
 \\
 || Vote || Subsystem || Runtime || Comment ||
 | {color:blue}0{color} | pre-patch |  16m  7s | Pre-patch trunk
 compilation is healthy. |
 | {color:green}+1{color} | @author |   0m  0s | The patch does not contain
 any @author tags. |
 | {color:green}+1{color} | tests included |   0m  0s | The patch appears
 to include 2 new or modified test files. |
 | {color:green}+1{color} | javac |   7m 35s | There were no new javac
 warning messages. |
 | {color:green}+1{color} | javadoc |   9m 42s | There were no new javadoc
 warning messages. |
 | {color:green}+1{color} | release audit |   0m 23s | The applied patch
 does not increase the total number of release audit warnings. |
 | {color:green}+1{color} | checkstyle |   0m 45s | There were no new
 checkstyle issues. |
 | {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines
 that end in whitespace. |
 | {color:green}+1{color} | install |   1m 31s | mvn install still works. |
 | {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built
 with eclipse:eclipse. |
 | {color:green}+1{color} | findbugs |   1m 26s | The patch does not
 introduce any new Findbugs (version 3.0.0) warnings. |
 | {color:red}-1{color} | yarn tests |  50m 46s | Tests failed in
 hadoop-yarn-server-resourcemanager. |
 | | |  88m 53s | |
 \\
 \\
 || Reason || Tests ||
 | Failed unit tests |
 hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
 \\
 \\
 || Subsystem || Report/Notes ||
 | Patch URL |
 http://issues.apache.org/jira/secure/attachment/12739453/YARN-3800.002.patch
 |
 | Optional Tests | javadoc javac unit findbugs checkstyle |
 | git revision | trunk / b8341f1 |
 | hadoop-yarn-server-resourcemanager test log |
 https://builds.apache.org/job/PreCommit-YARN-Build/8245/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
 | Test Results |
 https://builds.apache.org/job/PreCommit-YARN-Build/8245/testReport/ |
 | Java | 1.7.0_55 |
 | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu
 SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
 | Console output |
 https://builds.apache.org/job/PreCommit-YARN-Build/8245/console |


 This message was automatically generated.

  Simplify inmemory state for ReservationAllocation
  -
 
  Key: YARN-3800
  URL: https://issues.apache.org/jira/browse/YARN-3800
  Project: Hadoop YARN
   Issue Type: Sub-task
   Components: capacityscheduler, fairscheduler, resourcemanager
 Reporter: Anubhav Dhoot
 Assignee: Anubhav Dhoot
  Attachments: YARN-3800.001.patch, YARN-3800.002.patch
 
 
  Instead of storing the ReservationRequest we store the Resource for
 allocations, as thats the only thing we need. Ultimately we convert
 everything to resources anyway



 --
 This message was sent by Atlassian JIRA
 (v6.3.4#6332)



[jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation

2015-06-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584269#comment-14584269
 ] 

Hadoop QA commented on YARN-3800:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m 44s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:green}+1{color} | javac |   7m 50s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 57s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 47s | The applied patch generated  7 
new checkstyle issues (total was 54, now 55). |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 27s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  46m 30s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  85m 50s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | 
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens |
|   | hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps |
|   | hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
| Timed out tests | 
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
 |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12739350/YARN-3800.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / eef7b50 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-YARN-Build/8242/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8242/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8242/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8242/console |


This message was automatically generated.

 Simplify inmemory state for ReservationAllocation
 -

 Key: YARN-3800
 URL: https://issues.apache.org/jira/browse/YARN-3800
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: capacityscheduler, fairscheduler, resourcemanager
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3800.001.patch


 Instead of storing the ReservationRequest we store the Resource for 
 allocations, as thats the only thing we need. Ultimately we convert 
 everything to resources anyway



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)