[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369819#comment-15369819
]
Hudson commented on YARN-3836:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620861#comment-14620861
]
Li Lu commented on YARN-3836:
-
bq. Regarding metric, can't id uniquely identify a metric ? Do
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620868#comment-14620868
]
Sangjin Lee commented on YARN-3836:
---
I tend to think that using type + id is probably a
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621010#comment-14621010
]
Sangjin Lee commented on YARN-3836:
---
Thanks for updating the patch [~gtCarrera9].
I went
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621033#comment-14621033
]
Sangjin Lee commented on YARN-3836:
---
I take back my comment about the null check for
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621545#comment-14621545
]
Zhijie Shen commented on YARN-3836:
---
+1 LGTM
add equals and hashCode to TimelineEntity
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621559#comment-14621559
]
Sangjin Lee commented on YARN-3836:
---
Great. I'll commit the patch this evening unless
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620049#comment-14620049
]
Hadoop QA commented on YARN-3836:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620045#comment-14620045
]
Varun Saxena commented on YARN-3836:
Regarding metric, can't id uniquely identify a
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621288#comment-14621288
]
Sangjin Lee commented on YARN-3836:
---
Understood. Somehow I got the impression that the
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621209#comment-14621209
]
Zhijie Shen commented on YARN-3836:
---
bq. l.550: It sounds like now the type takes
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621398#comment-14621398
]
Hadoop QA commented on YARN-3836:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621338#comment-14621338
]
Hadoop QA commented on YARN-3836:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621501#comment-14621501
]
Sangjin Lee commented on YARN-3836:
---
The latest patch (v.4) looks good to me. Any other
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619140#comment-14619140
]
Li Lu commented on YARN-3836:
-
Hi [~vrushalic], I'd like to check the progress of this JIRA.
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619145#comment-14619145
]
Vrushali C commented on YARN-3836:
--
Hi [~gtCarrera]
Sounds good, will reassign to you.
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619245#comment-14619245
]
Li Lu commented on YARN-3836:
-
Thanks [~vrushalic]!
add equals and hashCode to TimelineEntity
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619678#comment-14619678
]
Hadoop QA commented on YARN-3836:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619702#comment-14619702
]
Sangjin Lee commented on YARN-3836:
---
Thanks [~gtCarrera9] for your quick patch! I agree
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619729#comment-14619729
]
Zhijie Shen commented on YARN-3836:
---
bq. I see that we're implementing the Comparable
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594229#comment-14594229
]
Vrushali C commented on YARN-3836:
--
I'll take this up unless someone else wants to.
add
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594416#comment-14594416
]
Vrushali C commented on YARN-3836:
--
Alright, sounds good. Will do the above..
add
[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594413#comment-14594413
]
Joep Rottinghuis commented on YARN-3836:
[~vrushalic] when you're tackling
23 matches
Mail list logo
