[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863117#comment-15863117
]
Hadoop QA commented on YARN-3933:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863093#comment-15863093
]
Karthik Kambatla commented on YARN-3933:
Sorry [~guoshiwei] for not getting to this sooner and
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860593#comment-15860593
]
Miklos Szegedi commented on YARN-3933:
--
I could not repro the unit test issues above.
> Race
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860552#comment-15860552
]
Hadoop QA commented on YARN-3933:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612089#comment-15612089
]
Sunil G commented on YARN-3933:
---
Test case failure is tracked in YARN-5043
> Race condition when calling
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612034#comment-15612034
]
Hadoop QA commented on YARN-3933:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425802#comment-15425802
]
Shiwei Guo commented on YARN-3933:
--
Sorry, guys. I'am sorry for no reply to this issue for a long time. I
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366469#comment-15366469
]
Sunil G commented on YARN-3933:
---
HI [~kasha],
Could you pls help to review the updated patch.
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350710#comment-15350710
]
Hadoop QA commented on YARN-3933:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334463#comment-15334463
]
Hadoop QA commented on YARN-3933:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334352#comment-15334352
]
Sunil G commented on YARN-3933:
---
Hi [~guoshiwei]
Could you pls help to share a patch as we discussed. If you
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300087#comment-15300087
]
Sunil G commented on YARN-3933:
---
Hi [~guoshiwei],
Could you please help to update the patch as discussed.
>
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272636#comment-15272636
]
Sunil G commented on YARN-3933:
---
HI [~guoshiwei]
Could you pls update new patch with the suggested update.
>
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233960#comment-15233960
]
Sunil G commented on YARN-3933:
---
Thanks. I feel this can go in independently and for other refactoring we can
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227456#comment-15227456
]
Shiwei Guo commented on YARN-3933:
--
And I didn't figure out how YARN-4809 fix the race condition, may be
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227453#comment-15227453
]
Shiwei Guo commented on YARN-3933:
--
Hi, I do think remove the duplicated code is a better way.
My only
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212866#comment-15212866
]
Sunil G commented on YARN-3933:
---
Hi
In current patch, below code is added in
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212853#comment-15212853
]
Shiwei Guo commented on YARN-3933:
--
Sorry, I didn't catch the point, I am not a YARN source code expert,
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212851#comment-15212851
]
Shiwei Guo commented on YARN-3933:
--
Seems CS do not have this issue. And as reply to Karthik Kambatla
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212844#comment-15212844
]
Shiwei Guo commented on YARN-3933:
--
Sorry for long time to reply. Did you mean adding this check in the
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203746#comment-15203746
]
Sunil G commented on YARN-3933:
---
As per existing patch, new liveContainers check is done before below code
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203723#comment-15203723
]
Wangda Tan commented on YARN-3933:
--
Looked at this issue, it seems only FairScheduler has this issue.
CS
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203404#comment-15203404
]
Karthik Kambatla commented on YARN-3933:
The fix here seems benign and should be okay to get in.
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203136#comment-15203136
]
Hadoop QA commented on YARN-3933:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192582#comment-15192582
]
Shiwei Guo commented on YARN-3933:
--
I noticed this, will fix it soon.
> Race condition when calling
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190344#comment-15190344
]
Karthik Kambatla commented on YARN-3933:
The patch fails to apply. [~guoshiwei] - mind refreshing
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074819#comment-15074819
]
Hadoop QA commented on YARN-3933:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740520#comment-14740520
]
Shiwei Guo commented on YARN-3933:
--
[~djp], would you like to review the patch or give me some pointer for
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733301#comment-14733301
]
Shiwei Guo commented on YARN-3933:
--
Excuse me, Junping, I'm wondering what to do next about this patch, to
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721422#comment-14721422
]
Shiwei Guo commented on YARN-3933:
--
I improved the patch and resubmitted it here, seems OK
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721418#comment-14721418
]
Hadoop QA commented on YARN-3933:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721290#comment-14721290
]
Junping Du commented on YARN-3933:
--
Sorry. I didn't see the patch you were mentioning. Did
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14719318#comment-14719318
]
Junping Du commented on YARN-3933:
--
I cancel the patch, please see Jenkins' comments: The
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14719298#comment-14719298
]
Junping Du commented on YARN-3933:
--
Looks like you are not YARN contributors yet, adding
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14719313#comment-14719313
]
Junping Du commented on YARN-3933:
--
This is not a lucky thing but a default behavior for
[
https://issues.apache.org/jira/browse/YARN-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720963#comment-14720963
]
Shiwei Guo commented on YARN-3933:
--
Thanks for add me to the contributer list, so
36 matches
Mail list logo