[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2016-07-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369825#comment-15369825 ] Hudson commented on YARN-4025: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-19 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703465#comment-14703465 ] Sangjin Lee commented on YARN-4025: --- Thanks everyone! Deal with byte representations of

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701656#comment-14701656 ] Junping Du commented on YARN-4025: -- bq. The EntityTable.java file is already fixed in the

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701672#comment-14701672 ] Sangjin Lee commented on YARN-4025: --- Oh OK. Got it. I thought you meant the line you

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701645#comment-14701645 ] Sangjin Lee commented on YARN-4025: --- Thanks for your review [~djp]! {quote} Do we handle

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702212#comment-14702212 ] Hadoop QA commented on YARN-4025: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702274#comment-14702274 ] Junping Du commented on YARN-4025: -- bq. We can treat that method as the default

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701325#comment-14701325 ] Junping Du commented on YARN-4025: -- bq. One major change I did is that now

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701309#comment-14701309 ] Junping Du commented on YARN-4025: -- Thanks [~sjlee0] for updating the patch. 003 patch

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-17 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700524#comment-14700524 ] Li Lu commented on YARN-4025: - Latest patch LGTM. Thanks [~sjlee0]! Deal with byte

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700628#comment-14700628 ] Hadoop QA commented on YARN-4025: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-17 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1472#comment-1472 ] Sangjin Lee commented on YARN-4025: --- That's a good point [~gtCarrera9]. Let me see if I

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-14 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697531#comment-14697531 ] Vrushali C commented on YARN-4025: -- Hmm, yes I think some more comments there might help

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-14 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697534#comment-14697534 ] Vrushali C commented on YARN-4025: -- I changed it from '?' to '='. Sangjin was also

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-14 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697545#comment-14697545 ] Li Lu commented on YARN-4025: - Oh sorry I missed that line... That looks fine. Deal with

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694840#comment-14694840 ] Hadoop QA commented on YARN-4025: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-13 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696268#comment-14696268 ] Li Lu commented on YARN-4025: - Hi [~sjlee0], thanks for the work! The patch overall LGTM. One

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-13 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696271#comment-14696271 ] Li Lu commented on YARN-4025: - Oh and, BTW, why are we changing Separator.VALUES? Deal with

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-12 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694177#comment-14694177 ] Vrushali C commented on YARN-4025: -- Reassigning to Sangjin Deal with byte

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-11 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692511#comment-14692511 ] Vrushali C commented on YARN-4025: -- Yes, +1 Deal with byte representations of Longs in

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-11 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692468#comment-14692468 ] Sangjin Lee commented on YARN-4025: --- For the record, we will go ahead with YARN-3906

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-10 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680393#comment-14680393 ] Li Lu commented on YARN-4025: - Hi [~sjlee0][~vrushalic], I slightly prefer to firstly move with

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680388#comment-14680388 ] Sangjin Lee commented on YARN-4025: --- Thanks for the patch [~vrushalic]. I believe you

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680450#comment-14680450 ] Sangjin Lee commented on YARN-4025: --- No, not really. I just wanted to understand the

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-10 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680410#comment-14680410 ] Sangjin Lee commented on YARN-4025: --- Went over the patch pretty quickly, and have some

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-10 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680430#comment-14680430 ] Vrushali C commented on YARN-4025: -- Thanks [~sjlee0] and [~gtCarrera9] I will rebase and

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-08 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662833#comment-14662833 ] Vrushali C commented on YARN-4025: -- The function {code} public MapString, Object

[jira] [Commented] (YARN-4025) Deal with byte representations of Longs in writer code

2015-08-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662869#comment-14662869 ] Hadoop QA commented on YARN-4025: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||