[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369756#comment-15369756
]
Hudson commented on YARN-4062:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200736#comment-15200736
]
Hadoop QA commented on YARN-4062:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200414#comment-15200414
]
Sangjin Lee commented on YARN-4062:
---
LGTM pending jenkins. I'll commit it once the jenkins comes back
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199604#comment-15199604
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184269#comment-15184269
]
Sangjin Lee commented on YARN-4062:
---
Sorry [~vrushalic] it took a while to get to this. It looks good for
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173396#comment-15173396
]
Hadoop QA commented on YARN-4062:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173303#comment-15173303
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170144#comment-15170144
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169876#comment-15169876
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169640#comment-15169640
]
Vrushali C commented on YARN-4062:
--
Attaching patch YARN-4062-YARN-2928.04.patch rebased to the right
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143909#comment-15143909
]
Joep Rottinghuis commented on YARN-4062:
Been slow to make progress on review mainly due to other
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113484#comment-15113484
]
Sangjin Lee commented on YARN-4062:
---
Regarding getting access to YarnConfiguration, generically speaking
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095129#comment-15095129
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095209#comment-15095209
]
Vrushali C commented on YARN-4062:
--
I see the javadoc and whitespace warnings, I am fixing them.
> Add
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088472#comment-15088472
]
Vrushali C commented on YARN-4062:
--
Thanks [~sjlee0], I will go over these and make the relevant changes.
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088407#comment-15088407
]
Vrushali C commented on YARN-4062:
--
Note: filed jira YARN-4561 for adding in enhancements like ability to
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088436#comment-15088436
]
Sangjin Lee commented on YARN-4062:
---
Thanks [~vrushalic] for the work! She and I went over the patch
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068650#comment-15068650
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068450#comment-15068450
]
Sangjin Lee commented on YARN-4062:
---
You'll need to use a name like
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069174#comment-15069174
]
Vrushali C commented on YARN-4062:
--
I will fix the findbug warning and take a look at the whitespace
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067616#comment-15067616
]
Hadoop QA commented on YARN-4062:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791625#comment-14791625
]
Vrushali C commented on YARN-4062:
--
No, we do use it in ColumnHelper#getPutTimestamp to be able to get the
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790987#comment-14790987
]
Joep Rottinghuis commented on YARN-4062:
While discussing flush and compaction with [~vrushalic] I
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791447#comment-14791447
]
Joep Rottinghuis commented on YARN-4062:
Based on YARN-3901-YARN-2928.9.patch
[
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791459#comment-14791459
]
Joep Rottinghuis commented on YARN-4062:
In FlowRunCoprocessor#getCellTimestamp is it possible to
25 matches
Mail list logo