[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317212#comment-16317212
]
Ray Chiang commented on YARN-4227:
--
+1. LGTM.
I'll commit this upstream soon.
> FairSch
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315915#comment-16315915
]
genericqa commented on YARN-4227:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314170#comment-16314170
]
Ray Chiang commented on YARN-4227:
--
Minor nit: The LOG.debug() calls for skipping containe
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299461#comment-16299461
]
Wilfred Spiegelenburg commented on YARN-4227:
-
Tests pass locally
Test failures
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298346#comment-16298346
]
genericqa commented on YARN-4227:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216201#comment-16216201
]
Steven Rand commented on YARN-4227:
---
Maybe we could have ClusterNodeTracker#getNode check
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216148#comment-16216148
]
Steven Rand commented on YARN-4227:
---
Sorry, I was mistaken when I said the patch attached
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153423#comment-16153423
]
Steven Rand commented on YARN-4227:
---
[~wilfreds], I can rebase the patch if you like. It
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135938#comment-16135938
]
Steven Rand commented on YARN-4227:
---
I'm seeing a similar issue on what's roughly branch-
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963885#comment-14963885
]
zhihai xu commented on YARN-4227:
-
Currently I didn't find other code path except YARN-3675
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962935#comment-14962935
]
Wilfred Spiegelenburg commented on YARN-4227:
-
I dug through the logs and it lo
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958402#comment-14958402
]
zhihai xu commented on YARN-4227:
-
Is it possible the root cause of this issue is YARN-3675
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957372#comment-14957372
]
Anubhav Dhoot commented on YARN-4227:
-
The previous statement should also be updated to
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956318#comment-14956318
]
Hadoop QA commented on YARN-4227:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955654#comment-14955654
]
Ray Chiang commented on YARN-4227:
--
+1 (nonbinding) after fixing the checkstyle issue (add
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954732#comment-14954732
]
Hadoop QA commented on YARN-4227:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954506#comment-14954506
]
Wilfred Spiegelenburg commented on YARN-4227:
-
Something wrong on the build sys
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954486#comment-14954486
]
Hadoop QA commented on YARN-4227:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954003#comment-14954003
]
Ray Chiang commented on YARN-4227:
--
+1 (nonbinding)
The only comment I have is whether it
[
https://issues.apache.org/jira/browse/YARN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944602#comment-14944602
]
Hadoop QA commented on YARN-4227:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
20 matches
Mail list logo