[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369797#comment-15369797 ] Hudson commented on YARN-4356: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083947#comment-15083947 ] Vrushali C commented on YARN-4356: -- Hmm. I am not sure if it is inconsistent. The actual behavior right

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083959#comment-15083959 ] Li Lu commented on YARN-4356: - Ah OK. But we do need to update the actual code when we introduce a new version

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083938#comment-15083938 ] Li Lu commented on YARN-4356: - One quick query w.r.t changes in this JIRA: I just noticed that in

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083994#comment-15083994 ] Vrushali C commented on YARN-4356: -- Yes, if we want the behavior to be different. If the 2.1 behavior

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084415#comment-15084415 ] Sangjin Lee commented on YARN-4356: --- The current code *does* consider the case where the version is

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084419#comment-15084419 ] Li Lu commented on YARN-4356: - Oh I missed this part... Thanks for the reminder! > ensure the timeline

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084002#comment-15084002 ] Li Lu commented on YARN-4356: - I'm fine to live with it for now. However, if anyone happen to have time I can

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052792#comment-15052792 ] Junping Du commented on YARN-4356: -- +1 on 006 patch. [~gtCarrera9], may be you want to commit this in? >

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053902#comment-15053902 ] Hadoop QA commented on YARN-4356: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053478#comment-15053478 ] Sangjin Lee commented on YARN-4356: --- Thanks folks for the review! > ensure the timeline service v.2 is

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053117#comment-15053117 ] Li Lu commented on YARN-4356: - Sure. If there's no objections, I'll commit this patch later this morning. >

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051498#comment-15051498 ] Sangjin Lee commented on YARN-4356: --- Thanks for the feedback. Now that YARN-3623 has been committed, I'll

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051966#comment-15051966 ] Li Lu commented on YARN-4356: - I can see in the v.6 patch both concerns are addressed. Any other

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050645#comment-15050645 ] Junping Du commented on YARN-4356: -- Thanks [~sjlee0] for updating the patch! bq. This is the java 7

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051306#comment-15051306 ] Hadoop QA commented on YARN-4356: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048671#comment-15048671 ] Junping Du commented on YARN-4356: -- I would like to review this as many of this patch related to my

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048970#comment-15048970 ] Sangjin Lee commented on YARN-4356: --- The jenkins run above is suspect as it doesn't seem to match v.3.

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049039#comment-15049039 ] Junping Du commented on YARN-4356: -- Thanks [~sjlee0] for delivering the patch. 004 patch looks good to me

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049204#comment-15049204 ] Naganarasimha G R commented on YARN-4356: - Hi [~sjlee0] few points from my side # I felt better to

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049392#comment-15049392 ] Hadoop QA commented on YARN-4356: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049817#comment-15049817 ] Sangjin Lee commented on YARN-4356: --- Thanks [~djp] for your comments. I addressed most of your comments

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049982#comment-15049982 ] Naganarasimha G R commented on YARN-4356: - Hi [~sjlee0], bq. Right now those null checks are still

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047055#comment-15047055 ] Sangjin Lee commented on YARN-4356: --- The jenkins build didn't fire automatically. Kicking off a manual

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047232#comment-15047232 ] Hadoop QA commented on YARN-4356: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047738#comment-15047738 ] Hadoop QA commented on YARN-4356: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048106#comment-15048106 ] Li Lu commented on YARN-4356: - Latest patch LGTM. +1 pending Jenkins. I'll wait for one more day and if

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048049#comment-15048049 ] Sangjin Lee commented on YARN-4356: --- Thanks for your review [~gtCarrera9]. bq. I noticed in some files

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047912#comment-15047912 ] Li Lu commented on YARN-4356: - Hi [~sjlee0], thanks for the work! Mostly LGTM, just a few thing to check: 1. I

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048067#comment-15048067 ] Sangjin Lee commented on YARN-4356: --- Oh I see. Yes, there is no NM metrics publisher in ATS v.1.x, so it

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045528#comment-15045528 ] Sangjin Lee commented on YARN-4356: --- Thanks for your quick comments [~vrushalic]! bq. +1 on creating a

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042180#comment-15042180 ] Vrushali C commented on YARN-4356: -- Thanks Sangjin for the initial patch! I had a few discussion points.

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011604#comment-15011604 ] Li Lu commented on YARN-4356: - bq. I haven't looked at YARN-4234 in detail yet. Are you referring to the

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012525#comment-15012525 ] Sangjin Lee commented on YARN-4356: --- Sounds good. That other JIRA is YARN-4368. > ensure the timeline

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012535#comment-15012535 ] Sangjin Lee commented on YARN-4356: --- In order to make progress with this work, I would like to propose

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009932#comment-15009932 ] Li Lu commented on YARN-4356: - Thanks for the long list [~sjlee0] and [~jrottinghuis]! I'm gradually shifting

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010094#comment-15010094 ] Sangjin Lee commented on YARN-4356: --- I haven't looked at YARN-4234 in detail yet. Are you referring to

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010172#comment-15010172 ] Naganarasimha G R commented on YARN-4356: - Yes [~varun_saxena], i agree that the approach which is

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004714#comment-15004714 ] Varun Saxena commented on YARN-4356: That's quite a comprehensive list. I was wondering if we should

[jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off

[ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004661#comment-15004661 ] Sangjin Lee commented on YARN-4356: --- This is the rough note I jotted down while going over the changes