[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650545#comment-13650545
]
Hadoop QA commented on YARN-45:
---
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650568#comment-13650568
]
Hudson commented on YARN-45:
Integrated in Hadoop-trunk-Commit #3713 (See
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650698#comment-13650698
]
Hudson commented on YARN-45:
Integrated in Hadoop-Yarn-trunk #202 (See
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650846#comment-13650846
]
Hudson commented on YARN-45:
Integrated in Hadoop-Mapreduce-trunk #1418 (See
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650527#comment-13650527
]
Carlo Curino commented on YARN-45:
--
bq. Would be great if you could add a version number to
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648986#comment-13648986
]
Carlo Curino commented on YARN-45:
--
Based on all the feedback here, including discussions
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13644327#comment-13644327
]
Bikas Saha commented on YARN-45:
My understanding is the the containers being presented in
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13644626#comment-13644626
]
Chris Douglas commented on YARN-45:
---
I'm also a fan of {{ResourceRequest}}, but we're not
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13644664#comment-13644664
]
Carlo Curino commented on YARN-45:
--
[~acmurthy] I see your point, which was in fact
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13644675#comment-13644675
]
Chris Douglas commented on YARN-45:
---
bq. we could express the ResourceRequest as a multiple
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642886#comment-13642886
]
Thomas Graves commented on YARN-45:
---
A couple of very nit picks that we might fix before
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642889#comment-13642889
]
Karthik Kambatla commented on YARN-45:
--
Also, for the javadoc, do we prefer codeblahcode
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642939#comment-13642939
]
Karthik Kambatla commented on YARN-45:
--
Thanks Thomas. Those are the only comments I
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643045#comment-13643045
]
Carlo Curino commented on YARN-45:
--
Thanks for the feedback, we will make sure these
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643061#comment-13643061
]
Carlo Curino commented on YARN-45:
--
About the choice between code and @link there are almost
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643065#comment-13643065
]
Karthik Kambatla commented on YARN-45:
--
IIUC, the compiler and IDEs understand @link:
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643373#comment-13643373
]
Bikas Saha commented on YARN-45:
I like PreemptionMessage or PreemptionNotification.
The
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643444#comment-13643444
]
Carlo Curino commented on YARN-45:
--
We modified the patch to account for the most recent
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643458#comment-13643458
]
Hadoop QA commented on YARN-45:
---
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643461#comment-13643461
]
Carlo Curino commented on YARN-45:
--
Reposting the patch with included BuilderUtils changes
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643473#comment-13643473
]
Hadoop QA commented on YARN-45:
---
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642163#comment-13642163
]
Chris Douglas commented on YARN-45:
---
If everyone's OK with the current patch as a base,
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639595#comment-13639595
]
Karthik Kambatla commented on YARN-45:
--
Barely skimmed through the patch, it looks good.
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638783#comment-13638783
]
Carlo Curino commented on YARN-45:
--
Updated the protocol patch (and the implementation for
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638814#comment-13638814
]
Hadoop QA commented on YARN-45:
---
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632630#comment-13632630
]
Chris Douglas commented on YARN-45:
---
bq. ResourceRequest is not actionable in the sense
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632511#comment-13632511
]
Carlo Curino commented on YARN-45:
--
[~bikassaha]
Sounds good, I totally agree with the
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632531#comment-13632531
]
Alejandro Abdelnur commented on YARN-45:
Got it, makes sense.
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632542#comment-13632542
]
Bikas Saha commented on YARN-45:
I took a quick look at this patch and the others and from
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632571#comment-13632571
]
Arun C Murthy commented on YARN-45:
---
Sorry, I've been away for a couple of weeks due to
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631400#comment-13631400
]
Bikas Saha commented on YARN-45:
My personal preference would be to not have an API that is
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630964#comment-13630964
]
Carlo Curino commented on YARN-45:
--
[~tucu00] Care to elaborate which properties we don't
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630734#comment-13630734
]
Sandy Ryza commented on YARN-45:
Carlo,
I'm glad that this is being proposed. Have you
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630769#comment-13630769
]
Bikas Saha commented on YARN-45:
I like the idea of the RM giving information to the AM about
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630893#comment-13630893
]
Chris Douglas commented on YARN-45:
---
[~sandyr]: Yes, but the correct format/semantics for
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630898#comment-13630898
]
Carlo Curino commented on YARN-45:
--
As you pointed out, any decision made in the RM needs to
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630925#comment-13630925
]
Alejandro Abdelnur commented on YARN-45:
Comments on the patch.
* Reusing
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628889#comment-13628889
]
Alejandro Abdelnur commented on YARN-45:
Carlo, what about a small twist?
A preempt
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628893#comment-13628893
]
Alejandro Abdelnur commented on YARN-45:
Forgot to add, unless I'm missing something
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628922#comment-13628922
]
Carlo Curino commented on YARN-45:
--
Our main focus for now is to rebalance capacity, in this
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628938#comment-13628938
]
Alejandro Abdelnur commented on YARN-45:
I'm just trying to see if we can have (at
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628950#comment-13628950
]
Carlo Curino commented on YARN-45:
--
Agreed on a single message, where the semantics is:
1)
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629070#comment-13629070
]
Alejandro Abdelnur commented on YARN-45:
sounds good
Scheduler
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629620#comment-13629620
]
Bikas Saha commented on YARN-45:
All API changes at this point are being tracked under
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629635#comment-13629635
]
Karthik Kambatla commented on YARN-45:
--
Great discussion, glad to see this coming along
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629638#comment-13629638
]
Karthik Kambatla commented on YARN-45:
--
[~bikassaha], shouldn't this be under YARN-397?
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629660#comment-13629660
]
Carlo Curino commented on YARN-45:
--
[~kkambatl], yes ResourceRequests can be used to capture
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629707#comment-13629707
]
Hadoop QA commented on YARN-45:
---
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629806#comment-13629806
]
Carlo Curino commented on YARN-45:
--
Note: we don't have tests as there are no tests for the
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628247#comment-13628247
]
Alejandro Abdelnur commented on YARN-45:
Nice, the proposed functionality comes quite
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628305#comment-13628305
]
Carlo Curino commented on YARN-45:
--
Alejandro, thanks for the feedback, and yes you are spot
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628358#comment-13628358
]
Alejandro Abdelnur commented on YARN-45:
Carlo, I may be missing something then.
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628503#comment-13628503
]
Alejandro Abdelnur commented on YARN-45:
My soft objection to #1 is just it is
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628625#comment-13628625
]
Carlo Curino commented on YARN-45:
--
Agreed.
As for #1, your previous comments made us
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626139#comment-13626139
]
Carlo Curino commented on YARN-45:
--
High level idea:
The philosophy behind preemption is
[
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626162#comment-13626162
]
Hadoop QA commented on YARN-45:
---
{color:red}-1 overall{color}. Here are the results of testing
56 matches
Mail list logo