[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110537#comment-15110537 ] Hadoop QA commented on YARN-4584: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110363#comment-15110363 ] Hadoop QA commented on YARN-4584: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110637#comment-15110637 ] Hadoop QA commented on YARN-4584: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-21 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111897#comment-15111897 ] Rohith Sharma K S commented on YARN-4584: - +1 LGTM, committing shortly > RM startup failure when

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111928#comment-15111928 ] Hudson commented on YARN-4584: -- FAILURE: Integrated in Hadoop-trunk-Commit #9159 (See

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-20 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109970#comment-15109970 ] Jun Gong commented on YARN-4584: [~bibinchundatt] Thanks for the patch, the patch looks good to me too. >

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-20 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110022#comment-15110022 ] Rohith Sharma K S commented on YARN-4584: - [~bibinchundatt] While committing I observed that the

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-20 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109953#comment-15109953 ] Jun Gong commented on YARN-4584: Thanks for comment. Yes, maxAttempt need be considered, it makes things a

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-20 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110010#comment-15110010 ] Rohith Sharma K S commented on YARN-4584: - +1 LGTM, committing shortly > RM startup failure when

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109360#comment-15109360 ] Jian He commented on YARN-4584: --- the patch looks fine to me, thanks [~rohithsharma], [~hex108], any other

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-19 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107897#comment-15107897 ] Bibin A Chundatt commented on YARN-4584: [~jianhe] /[~rohithsharma]/[~hex108] Could you please

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-18 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104930#comment-15104930 ] Bibin A Chundatt commented on YARN-4584: [~rohithsharma] # Attached patch after updating comments.

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105116#comment-15105116 ] Hadoop QA commented on YARN-4584: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-17 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104187#comment-15104187 ] Rohith Sharma K S commented on YARN-4584: - Overall patch looks neat. nits : Test : wait for killed

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-17 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104202#comment-15104202 ] Rohith Sharma K S commented on YARN-4584: - bq. Do we need to deal with these cases? I understand

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-17 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104158#comment-15104158 ] Jun Gong commented on YARN-4584: [~bibinchundatt] Thanks for the patch. {quote} Remove attempts whose

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103231#comment-15103231 ] Hadoop QA commented on YARN-4584: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-14 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097958#comment-15097958 ] Bibin A Chundatt commented on YARN-4584: [~rohithsharma] Thank you for looking into the issue . As

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-14 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098076#comment-15098076 ] Bibin A Chundatt commented on YARN-4584: [~rohithsharma] Testcase failures are not related to patch

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098067#comment-15098067 ] Hadoop QA commented on YARN-4584: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-14 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15099209#comment-15099209 ] Bibin A Chundatt commented on YARN-4584: [~jianhe] The AM is getting pre-empted and exceeds the max

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-14 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101222#comment-15101222 ] Rohith Sharma K S commented on YARN-4584: - I had offline discussion with [~jianhe] regarding this

[jira] [Commented] (YARN-4584) RM startup failure when AM attempts greater than max-attempts

2016-01-14 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098996#comment-15098996 ] Jian He commented on YARN-4584: --- I have one question, normally, if FailuresValidityInterval <=0, no attempts