[jira] [Commented] (YARN-4897) dataTables_wrapper change min height
[ https://issues.apache.org/jira/browse/YARN-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236801#comment-15236801 ] Bibin A Chundatt commented on YARN-4897: [~rohithsharma] Thank you for review and commit > dataTables_wrapper change min height > > > Key: YARN-4897 > URL: https://issues.apache.org/jira/browse/YARN-4897 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt >Priority: Minor > Fix For: 2.9.0 > > Attachments: 0001-YARN-4897.patch, Border and DefaultHeight.png > > > Incase of dataTables_wrapper the min height is 302 , Need to set the same to > 10px. > For pages containing 2 tables causes layout problem when min_height=302 > When dataTables_wrapper is in DIV rendering with border at min_height -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4897) dataTables_wrapper change min height
[ https://issues.apache.org/jira/browse/YARN-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236648#comment-15236648 ] Hudson commented on YARN-4897: -- FAILURE: Integrated in Hadoop-trunk-Commit #9595 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9595/]) YARN-4897. dataTables_wrapper change min height. Contributed by Bibin A (rohithsharmaks: rev 4ee7f0a3e7814d66d6e11aa4b559da5ac93c4b99) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/css/jui-dt.css > dataTables_wrapper change min height > > > Key: YARN-4897 > URL: https://issues.apache.org/jira/browse/YARN-4897 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt >Priority: Minor > Fix For: 2.9.0 > > Attachments: 0001-YARN-4897.patch, Border and DefaultHeight.png > > > Incase of dataTables_wrapper the min height is 302 , Need to set the same to > 10px. > For pages containing 2 tables causes layout problem when min_height=302 > When dataTables_wrapper is in DIV rendering with border at min_height -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4897) dataTables_wrapper change min height
[ https://issues.apache.org/jira/browse/YARN-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225667#comment-15225667 ] Rohith Sharma K S commented on YARN-4897: - This change make sense to me. +1 lgtm, I will commit it if no objections > dataTables_wrapper change min height > > > Key: YARN-4897 > URL: https://issues.apache.org/jira/browse/YARN-4897 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt >Priority: Minor > Attachments: 0001-YARN-4897.patch, Border and DefaultHeight.png > > > Incase of dataTables_wrapper the min height is 302 , Need to set the same to > 10px. > For pages containing 2 tables causes layout problem when min_height=302 > When dataTables_wrapper is in DIV rendering with border at min_height -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4897) dataTables_wrapper change min height
[
https://issues.apache.org/jira/browse/YARN-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224302#comment-15224302
]
Hadoop QA commented on YARN-4897:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
28s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 30s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 2 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s
{color} | {color:green} hadoop-yarn-common in the patch passed with JDK
v1.8.0_74. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 8s
{color} | {color:green} hadoop-yarn-common in the patch passed with JDK
v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 2s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12796845/0001-YARN-4897.patch |
| JIRA Issue | YARN-4897 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit |
| uname | Linux 938707b4d6e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 5092c94 |
| Default Java | 1.7.0_95 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_74
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/10956/artifact/patchprocess/whitespace-tabs.txt
|
| JDK v1.7.0_95 Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/10956/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common |
| Console output |
[jira] [Commented] (YARN-4897) dataTables_wrapper change min height
[ https://issues.apache.org/jira/browse/YARN-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217615#comment-15217615 ] Bibin A Chundatt commented on YARN-4897: Attached snapshot for the same. > dataTables_wrapper change min height > > > Key: YARN-4897 > URL: https://issues.apache.org/jira/browse/YARN-4897 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt >Priority: Minor > Attachments: Border and DefaultHeight.png > > > Incase of dataTables_wrapper the min height is 302 , Need to set the same to > 10px. > For pages containing 2 tables causes layout problem when min_height=302 > When dataTables_wrapper is in DIV rendering with border at min_height -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4897) dataTables_wrapper change min height
[ https://issues.apache.org/jira/browse/YARN-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217591#comment-15217591 ] Rohith Sharma K S commented on YARN-4897: - Would you attach screen shot to know which page has been affected? It is just to know about how UI looks.. > dataTables_wrapper change min height > > > Key: YARN-4897 > URL: https://issues.apache.org/jira/browse/YARN-4897 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt >Priority: Minor > Attachments: Border and DefaultHeight.png > > > Incase of dataTables_wrapper the min height is 302 , Need to set the same to > 10px. > For pages containing 2 tables causes layout problem when min_height=302 > When dataTables_wrapper is in DIV rendering with border at min_height -- This message was sent by Atlassian JIRA (v6.3.4#6332)
