[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369740#comment-15369740 ] Hudson commented on YARN-5097: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301031#comment-15301031 ] Sangjin Lee commented on YARN-5097: --- +1. Committing it shortly. > NPE in Separator.joinEncoded() >

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299584#comment-15299584 ] Joep Rottinghuis commented on YARN-5097: YARN-5097-YARN-2928.04.patch looks good to me. I think we

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298972#comment-15298972 ] Hadoop QA commented on YARN-5097: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298952#comment-15298952 ] Vrushali C commented on YARN-5097: -- Alright filed https://issues.apache.org/jira/browse/YARN-5138 for the

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298922#comment-15298922 ] Vrushali C commented on YARN-5097: -- Alright, setting the following {code} true {code} in

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298895#comment-15298895 ] Li Lu commented on YARN-5097: - bq. But do we want to enable findbugs for tests ? I think it's much easier to

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298869#comment-15298869 ] Varun Saxena commented on YARN-5097: There is a includeTests optional parameter for maven findbugs

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297447#comment-15297447 ] Hadoop QA commented on YARN-5097: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297326#comment-15297326 ] Sangjin Lee commented on YARN-5097: --- Thanks [~vrushalic]. I understand Joep also was suggesting a logging

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297277#comment-15297277 ] Sangjin Lee commented on YARN-5097: --- Thanks [~vrushalic] for your patch! To clarify, fixing YARN-5018

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297269#comment-15297269 ] Joep Rottinghuis commented on YARN-5097: Overall looks good. Why don't you lift 136 if ((flowName

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294173#comment-15294173 ] Li Lu commented on YARN-5097: - Seems like we're not generating findbugs files for the newly added module? >

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294149#comment-15294149 ] Vrushali C commented on YARN-5097: -- Not completely sure what that findbugs error means: {code}

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292835#comment-15292835 ] Hadoop QA commented on YARN-5097: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292736#comment-15292736 ] Hadoop QA commented on YARN-5097: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5097) NPE in Separator.joinEncoded()

[ https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292498#comment-15292498 ] Sangjin Lee commented on YARN-5097: --- I suspect this is indeed related with YARN-5018. The entire context