[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733405#comment-15733405
]
Miklos Szegedi commented on YARN-5600:
--
The unit test issue is YARN-5857
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732961#comment-15732961
]
Miklos Szegedi commented on YARN-5600:
--
The unit test issue is not related to the change. I cannot
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730803#comment-15730803
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730449#comment-15730449
]
Miklos Szegedi commented on YARN-5600:
--
Thank you, [~templedf]! I addressed most issues. Here are my
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729872#comment-15729872
]
Daniel Templeton commented on YARN-5600:
Thanks, [~miklos.szeg...@cloudera.com] for all the
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675547#comment-15675547
]
Miklos Szegedi commented on YARN-5600:
--
Thank you, [~vvasudev] for the comment!
We will get 600 in all
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674060#comment-15674060
]
Varun Vasudev commented on YARN-5600:
-
[~miklos.szeg...@cloudera.com] - can you explain when the
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669156#comment-15669156
]
Hadoop QA commented on YARN-5600:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668813#comment-15668813
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668543#comment-15668543
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668474#comment-15668474
]
Miklos Szegedi commented on YARN-5600:
--
Thank you, [~vvasudev] for the comments! I addressed all the
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667245#comment-15667245
]
Varun Vasudev commented on YARN-5600:
-
Thanks for the updated patch [~miklos.szeg...@cloudera.com]!
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665680#comment-15665680
]
Hadoop QA commented on YARN-5600:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665441#comment-15665441
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665283#comment-15665283
]
Miklos Szegedi commented on YARN-5600:
--
Thank you, [~vvasudev] for the review!
I will send a revised
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663130#comment-15663130
]
Varun Vasudev commented on YARN-5600:
-
Thanks for the patch [~miklos.szeg...@cloudera.com]! My
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657638#comment-15657638
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656248#comment-15656248
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655828#comment-15655828
]
Miklos Szegedi commented on YARN-5600:
--
Thank you for reviewing the patch [~wangda], and also thank
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655703#comment-15655703
]
Tan, Wangda commented on YARN-5600:
---
This is a very useful feature without any doubt, thanks
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655581#comment-15655581
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654874#comment-15654874
]
Miklos Szegedi commented on YARN-5600:
--
The build error seems to be unrelated to the change:
Failed to
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654842#comment-15654842
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653290#comment-15653290
]
Hadoop QA commented on YARN-5600:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653151#comment-15653151
]
Miklos Szegedi commented on YARN-5600:
--
Thank you, for the useful comments [~templedf]!
I fixed most
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649299#comment-15649299
]
Daniel Templeton commented on YARN-5600:
New comments:
* Maybe define a constant for {{new
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637202#comment-15637202
]
Hadoop QA commented on YARN-5600:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634927#comment-15634927
]
Hadoop QA commented on YARN-5600:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634788#comment-15634788
]
Miklos Szegedi commented on YARN-5600:
--
Thank you for the review [~templedf]!
It seems to me that
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634787#comment-15634787
]
Miklos Szegedi commented on YARN-5600:
--
Thank you for the review [~templedf]!
It seems to me that
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630951#comment-15630951
]
Daniel Templeton commented on YARN-5600:
Thanks for the patch, [~miklos.szeg...@cloudera.com].
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569739#comment-15569739
]
Hadoop QA commented on YARN-5600:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569608#comment-15569608
]
Miklos Szegedi commented on YARN-5600:
--
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567250#comment-15567250
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563897#comment-15563897
]
Hadoop QA commented on YARN-5600:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457573#comment-15457573
]
Naganarasimha G R commented on YARN-5600:
-
+1 for the approach.
> Add a parameter to
36 matches
Mail list logo