[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810832#comment-15810832 ] Sunil G commented on YARN-5709: --- Looks like EmbeddedElector is started earlier to AdminService and causing

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15786492#comment-15786492 ] Junping Du commented on YARN-5709: -- The javadoc error is caused by YARN-4567. [~leftnoteasy] just identify

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15786320#comment-15786320 ] Junping Du commented on YARN-5709: -- Thanks [~jianhe]! > Cleanup leader election configs and pluggability

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15786265#comment-15786265 ] Junping Du commented on YARN-5709: -- The good news is I checked all classes affected in changes - no one

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785818#comment-15785818 ] Daniel Templeton commented on YARN-5709: It looks to me what's happening is that Yetus isn't

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784442#comment-15784442 ] Junping Du commented on YARN-5709: -- Interesting...Why these javadoc warnings only against jdk v1.8? >

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784177#comment-15784177 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781487#comment-15781487 ] Jian He commented on YARN-5709: --- Could you re-submit the patch with your change and retry ? > Cleanup leader

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781465#comment-15781465 ] Daniel Templeton commented on YARN-5709: Hmmm... Looks like

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781367#comment-15781367 ] Jian He commented on YARN-5709: --- I'm not sure which part of the patch is causing javadoc failure,

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781360#comment-15781360 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771628#comment-15771628 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771301#comment-15771301 ] Jian He commented on YARN-5709: --- I fixed the javac warnings, javadoc warnings seems be existing. > Cleanup

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768189#comment-15768189 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15767971#comment-15767971 ] Junping Du commented on YARN-5709: -- I noticed the same issue in other JIRAs and filed an infra ticket:

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765938#comment-15765938 ] Karthik Kambatla commented on YARN-5709: The precommit build seems to be having issues doing a "git

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765681#comment-15765681 ] Karthik Kambatla commented on YARN-5709: Posting a branch-2.8 patch to address some of the

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765189#comment-15765189 ] Junping Du commented on YARN-5709: -- Sure. Sounds good to me. > Cleanup leader election configs and

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765158#comment-15765158 ] Karthik Kambatla commented on YARN-5709: Sorry for dropping the ball on this. I ll take a look at

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762999#comment-15762999 ] Junping Du commented on YARN-5709: -- Hi [~kasha], do you get chance to look at it recently? If not, I am OK

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749766#comment-15749766 ] Karthik Kambatla commented on YARN-5709: Will take a look later today or tomorrow. > Cleanup

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749734#comment-15749734 ] Junping Du commented on YARN-5709: -- [~kasha] (or [~ka...@cloudera.com]), do you have plan to backport this

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746358#comment-15746358 ] Junping Du commented on YARN-5709: -- Sounds like we already make consensus here. Hi [~kasha], I have

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743822#comment-15743822 ] Jian He commented on YARN-5709: --- I agree with what you suggested, include it. > Cleanup leader election

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743309#comment-15743309 ] Karthik Kambatla commented on YARN-5709: [~jianhe] - I didn't quite get that. Are you suggested we

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738355#comment-15738355 ] Jian He commented on YARN-5709: --- oh,, ok. Sounds good to me, given that those do not affect existing code.

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738172#comment-15738172 ] Karthik Kambatla commented on YARN-5709: I just pushed YARN-5677 to branch-2.8, but just realized

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736918#comment-15736918 ] Hudson commented on YARN-5709: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10982 (See

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736886#comment-15736886 ] Jian He commented on YARN-5709: --- branch-2, and trunk is committed. Unfortunately, there seems quite some

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736827#comment-15736827 ] Jian He commented on YARN-5709: --- +1, committing > Cleanup leader election configs and pluggability >

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736696#comment-15736696 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736679#comment-15736679 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733166#comment-15733166 ] Jian He commented on YARN-5709: --- thanks Karthik for the refactoring, it indeed looks cleaner ! minor comment

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731087#comment-15731087 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730457#comment-15730457 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730455#comment-15730455 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730016#comment-15730016 ] Jian He commented on YARN-5709: --- i see, sounds good to me. > Cleanup leader election configs and

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730006#comment-15730006 ] Karthik Kambatla commented on YARN-5709: Since it is a config that users should be able to use, I

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729865#comment-15729865 ] Jian He commented on YARN-5709: --- yeah, looks good to me overall should CURATOR_LEADER_ELECTOR in

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729835#comment-15729835 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5709) Cleanup leader election configs and pluggability

[ https://issues.apache.org/jira/browse/YARN-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727593#comment-15727593 ] Hadoop QA commented on YARN-5709: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||